New issue
Advanced search Search tips

Issue 673522 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Convert EmbedContentViewActivity to use CustomTabActivity.

Project Member Reported by xingliu@chromium.org, Dec 12 2016

Issue description

EmbedContentViewActivity is used to show term of policy pages or help pages, we plan to remove the class and use CustomTabActivity instead.

 
Status: Started (was: Untriaged)
Screen shots for EmbedContentViewActivity and CustomTabActivity.
old_embedded_view_screen.png
502 KB View Download
new_custom_tab_0.png
383 KB View Download

Comment 3 Deleted

Try to hide the url, but on tablet the color of the security icon close to the title is not correct.
new_hide_url_screen.png
220 KB View Download
Uploaded a CL for this:

https://codereview.chromium.org/2571553003/
Summary: Convert EmbedContentViewActivity to use CustomTabActivity. (was: convert EmbedContentViewActivity to use CustomTabActivity.)
Cc: tedc...@chromium.org
New screenshot, new updates to the CL. Found an issue after rebase, so I have to add some new logic here.

1. Hide the app menu button to avoid weird issue in FRE, also a bit more consistent with EmbedContentViewActivity.

2. Fix for the new sign in logic for FRE in CustomTabActivity. So on phone, it won't launch FRE over and over after open the term of service.

new_custom_tab_hide_app_menu.png
629 KB View Download
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c81574599b63cc6d9af0285aa0876983be526e5c

commit c81574599b63cc6d9af0285aa0876983be526e5c
Author: xingliu <xingliu@chromium.org>
Date: Fri Dec 16 19:35:38 2016

Converts usage of EmbeddedContentViewActivity to CustomTabActivity.

This CL changes all call sites of EmbedContentViewActivity to use
CustomTabActivity.

Didn't delete the EmbedContentViewActivity code yet, also not sure if
we should clean the chrome strings for the titles if we don't need them.

There are a couple of details in the UI:

1. Title is now using html document title instead of chrome strings.
Not sure which one should we use here.

2. The color of the toolbar is same as EmbeddedContentViewActivity. But
the color of icons or other components depends on their own logic and
theme color of the activity, etc.

3. The url bar is not hidden for now, since the security icon color on
tablet is not correct.(Black icon on a dark background). Don't have
a spec so not sure if we would hide the url bar here and fix the icon
color logic.

Screen shots are attached in crbug.
BUG= 673522 

Review-Url: https://codereview.chromium.org/2571553003
Cr-Commit-Position: refs/heads/master@{#439168}

[modify] https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[modify] https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java
[modify] https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
[modify] https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c/chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java
[modify] https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
[modify] https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java
[modify] https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c/chrome/android/java/src/org/chromium/chrome/browser/firstrun/LightweightFirstRunActivity.java
[modify] https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c/chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java
[modify] https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java
[modify] https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c/chrome/android/java/src/org/chromium/chrome/browser/preferences/HyperlinkPreference.java
[modify] https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerCardEditor.java
[modify] https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerProfilePreferences.java
[modify] https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c/chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java

Status: Fixed (was: Started)

Sign in to add a comment