Screen shots for EmbedContentViewActivity and CustomTabActivity.

Deleted: old_embedded_view_screen.png 502 KB

	old_embedded_view_screen.png 502 KB View Download

Deleted: new_custom_tab_0.png 383 KB

	new_custom_tab_0.png 383 KB View Download

Try to hide the url, but on tablet the color of the security icon close to the title is not correct.

Deleted: new_hide_url_screen.png 220 KB

	new_hide_url_screen.png 220 KB View Download

Uploaded a CL for this:

https://codereview.chromium.org/2571553003/

New screenshot, new updates to the CL. Found an issue after rebase, so I have to add some new logic here.

1. Hide the app menu button to avoid weird issue in FRE, also a bit more consistent with EmbedContentViewActivity.

2. Fix for the new sign in logic for FRE in CustomTabActivity. So on phone, it won't launch FRE over and over after open the term of service.

Deleted: new_custom_tab_hide_app_menu.png 629 KB

	new_custom_tab_hide_app_menu.png 629 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c81574599b63cc6d9af0285aa0876983be526e5c

commit c81574599b63cc6d9af0285aa0876983be526e5c
Author: xingliu <xingliu@chromium.org>
Date: Fri Dec 16 19:35:38 2016

Converts usage of EmbeddedContentViewActivity to CustomTabActivity.

This CL changes all call sites of EmbedContentViewActivity to use
CustomTabActivity.

Didn't delete the EmbedContentViewActivity code yet, also not sure if
we should clean the chrome strings for the titles if we don't need them.

There are a couple of details in the UI:

1. Title is now using html document title instead of chrome strings.
Not sure which one should we use here.

2. The color of the toolbar is same as EmbeddedContentViewActivity. But
the color of icons or other components depends on their own logic and
theme color of the activity, etc.

3. The url bar is not hidden for now, since the security icon color on
tablet is not correct.(Black icon on a dark background). Don't have
a spec so not sure if we would hide the url bar here and fix the icon
color logic.

Screen shots are attached in crbug.
BUG= 673522 

Review-Url: https://codereview.chromium.org/2571553003
Cr-Commit-Position: refs/heads/master@{#439168}

[modify] https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[modify] https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java
[modify] https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
[modify] https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c/chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java
[modify] https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
[modify] https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java
[modify] https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c/chrome/android/java/src/org/chromium/chrome/browser/firstrun/LightweightFirstRunActivity.java
[modify] https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c/chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java
[modify] https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java
[modify] https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c/chrome/android/java/src/org/chromium/chrome/browser/preferences/HyperlinkPreference.java
[modify] https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerCardEditor.java
[modify] https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerProfilePreferences.java
[modify] https://crrev.com/c81574599b63cc6d9af0285aa0876983be526e5c/chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3746e638dd83ea76ea0aa45cd2ef595527bf8c0f

commit 3746e638dd83ea76ea0aa45cd2ef595527bf8c0f
Author: tedchoc <tedchoc@chromium.org>
Date: Wed Dec 28 22:01:30 2016

Disable contextual search if the FRE has not been completed.

BUG= 673522 

Review-Url: https://codereview.chromium.org/2602813002
Cr-Commit-Position: refs/heads/master@{#440898}

[modify] https://crrev.com/3746e638dd83ea76ea0aa45cd2ef595527bf8c0f/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java
[modify] https://crrev.com/3746e638dd83ea76ea0aa45cd2ef595527bf8c0f/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ca0e85e1bdac87da82efd8835974adc5620c5e7

commit 5ca0e85e1bdac87da82efd8835974adc5620c5e7
Author: xingliu <xingliu@chromium.org>
Date: Tue Jan 10 19:59:40 2017

Clean the deprecated class EmbedContentViewActivity.

Removed all related code, we converted all call sites to
CustomTabActivity.

BUG= 673522 

Review-Url: https://codereview.chromium.org/2587193002
Cr-Commit-Position: refs/heads/master@{#442665}

[modify] https://crrev.com/5ca0e85e1bdac87da82efd8835974adc5620c5e7/chrome/android/java/AndroidManifest.xml
[delete] https://crrev.com/94c9d5e1abe7f13266495ec180988376728a2415/chrome/android/java/src/org/chromium/chrome/browser/EmbedContentViewActivity.java
[modify] https://crrev.com/5ca0e85e1bdac87da82efd8835974adc5620c5e7/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/5ca0e85e1bdac87da82efd8835974adc5620c5e7/chrome/android/java_sources.gni
[delete] https://crrev.com/94c9d5e1abe7f13266495ec180988376728a2415/chrome/android/javatests/src/org/chromium/chrome/browser/hardware_acceleration/EmbedContentViewActivityHWATest.java
[modify] https://crrev.com/5ca0e85e1bdac87da82efd8835974adc5620c5e7/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabWindowManagerTest.java