New issue
Advanced search Search tips

Issue 673520 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Remove expected_size argument from webViewContainingBlockedImage

Project Member Reported by eugene...@chromium.org, Dec 12 2016

Issue description

expected_size can be calculated internally and there is no reason for passing it inside.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7bff5102552f69db92d31b3496bb197101e0770

commit f7bff5102552f69db92d31b3496bb197101e0770
Author: eugenebut <eugenebut@chromium.org>
Date: Wed Dec 14 19:29:15 2016

[ios] webViewContainingBlockedImage which does not need size argument.

webViewContainingBlockedImage will be used in various SSL tests and
passing image_size to every call is unnecessary and simply clutters the
tests.

BUG= 673520 

Review-Url: https://codereview.chromium.org/2569103002
Cr-Commit-Position: refs/heads/master@{#438589}

[modify] https://crrev.com/f7bff5102552f69db92d31b3496bb197101e0770/ios/web/BUILD.gn
[modify] https://crrev.com/f7bff5102552f69db92d31b3496bb197101e0770/ios/web/public/test/earl_grey/web_view_matchers.h
[modify] https://crrev.com/f7bff5102552f69db92d31b3496bb197101e0770/ios/web/public/test/earl_grey/web_view_matchers.mm

Status: Fixed (was: Started)

Sign in to add a comment