New issue
Advanced search Search tips

Issue 673501 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 667075



Sign in to add a comment

daisydog: add a uma stat to track watchdog startup failures

Project Member Reported by vapier@chromium.org, Dec 12 2016

Issue description

as part of the cleanup work for  bug 667075 , we should add a uma stat to track how often the watchdog service fails to start up properly.  we don't think it's a problem in practice, but we want to be confident before we start making the failure a soft one for the purposes of booting in a VM.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52b9aba37043a56f2ca0f01b0a07a0cda629cc40

commit 52b9aba37043a56f2ca0f01b0a07a0cda629cc40
Author: vapier <vapier@chromium.org>
Date: Wed Dec 14 06:09:25 2016

metrics: improve histogram docs

BUG= 673501 

Review-Url: https://codereview.chromium.org/2574533003
Cr-Commit-Position: refs/heads/master@{#438446}

[modify] https://crrev.com/52b9aba37043a56f2ca0f01b0a07a0cda629cc40/tools/metrics/histograms/README.md

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/396ff217b076ce67acbdc2bf1be716d5cd3c0e56

commit 396ff217b076ce67acbdc2bf1be716d5cd3c0e56
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Dec 12 23:14:36 2016

metrics: register new Watchdog.StartupFailed enum

This is used whenever the watchdog service (daisydog) fails to start up
correctly.  We don't expect this to happen on real devices, so we want
to get a handle if it actually does (and how often).

Chrome CL: https://codereview.chromium.org/2571873002

BUG= chromium:673501 
TEST=`metrics_client -v Watchdog.StartupFailed` now works

Change-Id: I493569a9e62dd7ef6f6c4809948c5ec6950a1884
Reviewed-on: https://chromium-review.googlesource.com/418836
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/396ff217b076ce67acbdc2bf1be716d5cd3c0e56/metrics/metrics_library.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74931624d8d247d97e7b32afe0e666c51c3f598b

commit 74931624d8d247d97e7b32afe0e666c51c3f598b
Author: vapier <vapier@chromium.org>
Date: Wed Dec 14 21:55:41 2016

histograms: register new CrOS watchdog event

This is used whenever the watchdog service (daisydog) fails to start up
correctly.  We don't expect this to happen on real devices, so we want
to get a handle if it actually does (and how often).

BUG= 673501 

Review-Url: https://codereview.chromium.org/2571873002
Cr-Commit-Position: refs/heads/master@{#438643}

[modify] https://crrev.com/74931624d8d247d97e7b32afe0e666c51c3f598b/tools/metrics/histograms/histograms.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/daisydog/+/60338a8ef06d801b6d2e343dbb14697a16f85c1b

commit 60338a8ef06d801b6d2e343dbb14697a16f85c1b
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Dec 12 22:57:04 2016

init: log a metric when service startup fails

Today, if daisydog fails to start up properly, it gets logged as respawn
too fast failure by upstart, and that's it.  Add a metric to track this
better over all devices so we can see if we need to add more logic here
in the future.

BUG= chromium:673501 
TEST=start up logged the metric
CQ-DEPEND=CL:418836

Change-Id: I5f317c408581b4892a1c3d61a58f2d79f66fa97a
Reviewed-on: https://chromium-review.googlesource.com/420363
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Luigi Semenzato <semenzato@chromium.org>

[modify] https://crrev.com/60338a8ef06d801b6d2e343dbb14697a16f85c1b/daisydog.conf

Comment 5 by vapier@chromium.org, Dec 16 2016

Status: Fixed (was: Started)
i set up a reminder on my cal to check this stat over the next few months to make sure it doesn't show up

https://uma.googleplex.com/histograms/?histograms=Platform.CrOSEvent
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edcdd4921c3c767372d8bb911b5e509f03f28347

commit edcdd4921c3c767372d8bb911b5e509f03f28347
Author: vapier <vapier@chromium.org>
Date: Tue Dec 20 01:59:01 2016

histograms: fix my e-mail address

BUG= 673501 

Review-Url: https://codereview.chromium.org/2589753003
Cr-Commit-Position: refs/heads/master@{#439666}

[modify] https://crrev.com/edcdd4921c3c767372d8bb911b5e509f03f28347/tools/metrics/histograms/histograms.xml

Comment 7 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9976f8b0c25eb6d716ad76bb97b7c2f5481395b8

commit 9976f8b0c25eb6d716ad76bb97b7c2f5481395b8
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Mar 17 03:30:46 2017

metrics: convert docs to markdown

BUG= chromium:673501 
TEST=read the rendered content

Change-Id: Ibd6afbb7cf3fb3f137fcd0af90ed6f67eccbd726
Reviewed-on: https://chromium-review.googlesource.com/419295
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Luigi Semenzato <semenzato@chromium.org>

[delete] https://crrev.com/570b787c4020b8cb29f0fb16f1c8d52f5f8371a9/metrics/README
[add] https://crrev.com/9976f8b0c25eb6d716ad76bb97b7c2f5481395b8/metrics/README.md

Comment 9 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 10 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 12 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/a10bd4caca08ae74b8ccabec6e93ef3a62c7bf13

commit a10bd4caca08ae74b8ccabec6e93ef3a62c7bf13
Author: Mike Frysinger <vapier@chromium.org>
Date: Sat Nov 18 04:18:39 2017

metrics: improve docs a bit

BUG= chromium:673501 
TEST=read the rendered content

Change-Id: I6a541aabc88bb434d22881b8225ef66cf3fc8e67
Reviewed-on: https://chromium-review.googlesource.com/767347
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Luigi Semenzato <semenzato@chromium.org>

[modify] https://crrev.com/a10bd4caca08ae74b8ccabec6e93ef3a62c7bf13/metrics/README.md

Status: Fixed (was: Archived)

Sign in to add a comment