New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 673500 link

Starred by 1 user
Status: Fixed
Owner:
█ trchen@chromium.org
Last visit > 30 days ago
Closed: Sep 13
Cc:
pdr@chromium.org
chrishtr@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[SPv2] PaintPropertyTreeBuilder::updateEffect should handle SVG with more care

Project Member Reported by trchen@chromium.org, Dec 12 2016 
At the top of the function we just early out if !style.isStackingContext(). Stacking context is a HTML/CSS concept that is not applicable to SVG.

What we really want to determine is whether the element starts an isolated group. In HTML it is true that an element is isolating if and only if an element is stacking context [1]. SVG uses a different criteria [2].

[1] https://www.w3.org/TR/compositing-1/#csscompositingrules_CSS
[2] https://www.w3.org/TR/compositing-1/#csscompositingrules_SVG
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edf04d1d0d3ecd74b9ea1e11d65dfa9113797511

commit edf04d1d0d3ecd74b9ea1e11d65dfa9113797511
Author: trchen <trchen@chromium.org>
Date: Sun Dec 25 00:49:34 2016

[SPv2] Associate effect property nodes for SVG paint chunks

Previously we only created the effect nodes for SVG effects but without
actually using them. This CL adds SPv2 support to SVGPaintContext.

As a side change, guard LayoutObject::hasNonIsolatedBlendingDescendants()
with NOTREACHED() because it is only implemented for SVG.

BUG= 673500 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2570223002
Cr-Commit-Position: refs/heads/master@{#440678}

[modify] https://crrev.com/edf04d1d0d3ecd74b9ea1e11d65dfa9113797511/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/edf04d1d0d3ecd74b9ea1e11d65dfa9113797511/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
[modify] https://crrev.com/edf04d1d0d3ecd74b9ea1e11d65dfa9113797511/third_party/WebKit/Source/core/paint/SVGPaintContext.cpp
[modify] https://crrev.com/edf04d1d0d3ecd74b9ea1e11d65dfa9113797511/third_party/WebKit/Source/core/paint/SVGPaintContext.h

Comment 2 by trchen@chromium.org, Sep 13

Status: Fixed (was: Assigned)
►

Sign in to add a comment