BLE Advertising: Existing registered single ad not affected by changing Advertising Interval. |
||||||||||||||||||||||||||
Issue descriptionChrome Version: M56-Beta channel, Build 9000.26.0, chrome 56.0.2924.26 OS: ChromeOS Device: Ninja chromebox. What steps will reproduce the problem? (1) Enterprise enroll a device to an Org. Unit with these Device Settings: a) Other:Bluetooth:Disable Bluetooth on Device set to "Do not disable". b) Managed Kiosk apps includes the "Krish Kiosk BLE freq app" (webstore id: akbaeokbhhplcacgmkkcbjghgbhchkib) c) The Krish Kiosk BLE freq app is auto-launched. (2) Ensure the device has Bluetooth enabled. (3) Reboot and wait for the Krish Kiosk BLE freq app to auto-launch. (4) Choose a short advertising interval between 20 and 1000ms, and click [Update Advertising Interval]. I chose 20ms in my specific case, but the symptom happens at other intervals, too. (5) Click [Advertise] to create one ad. Verify the ad is broadcasting at the expected interval (I use an android phone with the "nRF Connect" app.) (6) Pick another very different interval and click [Update Advertising Interval]. In my case I chose 1000ms. What is the expected result? As soon as the existing registered ad has completed its current cycle (20ms), it should begin advertising at the new interval (1000ms). What happens instead? The ad continued broadcasting at 20ms for a lengthy time (I waited five minutes, and it looked like that ad would continue at 20ms forever). I registered a second ad, and then both advertisements ran at the 1000ms interval.
,
Dec 12 2016
I think this may happen when there is only a single advertisement. When there is a single advertisement, the kernel just caches the advertisement data and parameters on the controller and does not bother to update controller. If the theory is correct, I need to update the caching condition about when the kernel should actually push the advertising data/parameters to the controller. In the bluetooth_AdapterLEAdvertising autotest, we only implemented test cases for multi-advertising. We should implement test cases for single advertisement as well to capture this kind of problems.
,
Dec 12 2016
Yes, your explanation in #2 matches what I'm seeing. If I register two ads, then change the interval frequency, the two ads are affected immediately.
,
Dec 14 2016
,
Jan 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/c3146bdf8e8765bbdbe727bbbda24d641609f39e commit c3146bdf8e8765bbdbe727bbbda24d641609f39e Author: Joseph Hwang <josephsih@chromium.org> Date: Thu Jan 05 08:39:07 2017 CHROMIUM: bluetooth: update advertising parameters for single advertisement Currently, the advertisement scheduling algorithm does not update the advertising data and parameters on the controller if there is only one advertisement. This saves effort when the advertisement data and parameters are not changed. Since new methods have been provided to change advertising intervals and duration, it is needed to have a flag to indicate the change and update the controller accordingly when the flag is set true. BUG= chromium:673499 TEST=Use the "nRF Connect" android app to verify. Single advertisement: - register a single advertisement, - change the advertising interval, and - check if the new interval takes effect immediately. Also verify multiple advertisements work correctly as well. Change-Id: I058e4c7a9feeee691f507903037e581e9eb2978d Reviewed-on: https://chromium-review.googlesource.com/425558 Commit-Ready: Shyh-In Hwang <josephsih@chromium.org> Tested-by: Shyh-In Hwang <josephsih@chromium.org> Tested-by: Miao-chen Chou <mcchou@chromium.org> Reviewed-by: Shyh-In Hwang <josephsih@chromium.org> Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by: Miao-chen Chou <mcchou@chromium.org> [modify] https://crrev.com/c3146bdf8e8765bbdbe727bbbda24d641609f39e/net/bluetooth/mgmt.c [modify] https://crrev.com/c3146bdf8e8765bbdbe727bbbda24d641609f39e/net/bluetooth/hci_core.c [modify] https://crrev.com/c3146bdf8e8765bbdbe727bbbda24d641609f39e/include/net/bluetooth/hci_core.h [modify] https://crrev.com/c3146bdf8e8765bbdbe727bbbda24d641609f39e/net/bluetooth/hci_request.c
,
Jan 14 2017
Hi Michale, could you test again to see if it behaves correctly now? Thanks.
,
Jan 18 2017
Just tried M-56 Beta, build 9000.66.0, but the single ad problem is still happening. Is your fix going into some later build?
,
Jan 19 2017
It is my bad that I forgot to cherry-pick the patch to R56. Besides, I also need to cherry-pick the patch to other kernel versions of R57 too. The patches for R56 and R57 are now submitted for review. Michael, could you do the test using an image on the 3.14 kernel after R57-9176.0.0 ? (This is the only kernel that we have the patch landed for the present time.) Thanks!
,
Jan 19 2017
This bug requires manual review: We are only 11 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 19 2017
HI Machael, there are only a few days from stable for R56, do you think we should still target for R56? Or maybe R57?
,
Jan 19 2017
This bug requires manual review: We don't branch M57 until 2017-01-19. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 19 2017
Hi Joseph, We are fine with waiting for M57 but I'll have Raj make the final call. Raj, what do you think regarding #10?
,
Jan 19 2017
Let us go with M57 given that there is not much time before M56 stable. Thanks.
,
Jan 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/ff701ac57791801e9f60eee8f54811c548d97281 commit ff701ac57791801e9f60eee8f54811c548d97281 Author: Joseph Hwang <josephsih@chromium.org> Date: Thu Jan 05 08:39:07 2017 CHROMIUM: bluetooth: update advertising parameters for single advertisement Currently, the advertisement scheduling algorithm does not update the advertising data and parameters on the controller if there is only one advertisement. This saves effort when the advertisement data and parameters are not changed. Since new methods have been provided to change advertising intervals and duration, it is needed to have a flag to indicate the change and update the controller accordingly when the flag is set true. BUG= chromium:673499 TEST=Use the "nRF Connect" android app to verify. Single advertisement: - register a single advertisement, - change the advertising interval, and - check if the new interval takes effect immediately. Also verify multiple advertisements work correctly as well. Change-Id: I058e4c7a9feeee691f507903037e581e9eb2978d Reviewed-on: https://chromium-review.googlesource.com/425558 Commit-Ready: Shyh-In Hwang <josephsih@chromium.org> Tested-by: Shyh-In Hwang <josephsih@chromium.org> Tested-by: Miao-chen Chou <mcchou@chromium.org> Reviewed-by: Shyh-In Hwang <josephsih@chromium.org> Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by: Miao-chen Chou <mcchou@chromium.org> (cherry picked from commit c3146bdf8e8765bbdbe727bbbda24d641609f39e) Reviewed-on: https://chromium-review.googlesource.com/430457 Commit-Ready: Miao-chen Chou <mcchou@chromium.org> [modify] https://crrev.com/ff701ac57791801e9f60eee8f54811c548d97281/net/bluetooth/mgmt.c [modify] https://crrev.com/ff701ac57791801e9f60eee8f54811c548d97281/net/bluetooth/hci_core.c [modify] https://crrev.com/ff701ac57791801e9f60eee8f54811c548d97281/include/net/bluetooth/hci_core.h [modify] https://crrev.com/ff701ac57791801e9f60eee8f54811c548d97281/net/bluetooth/hci_request.c
,
Jan 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/57744b471c63ea63ba9932207fe1749eb2b28baa commit 57744b471c63ea63ba9932207fe1749eb2b28baa Author: Joseph Hwang <josephsih@chromium.org> Date: Thu Jan 05 08:39:07 2017 CHROMIUM: bluetooth: update advertising parameters for single advertisement Currently, the advertisement scheduling algorithm does not update the advertising data and parameters on the controller if there is only one advertisement. This saves effort when the advertisement data and parameters are not changed. Since new methods have been provided to change advertising intervals and duration, it is needed to have a flag to indicate the change and update the controller accordingly when the flag is set true. BUG= chromium:673499 TEST=Use the "nRF Connect" android app to verify. Single advertisement: - register a single advertisement, - change the advertising interval, and - check if the new interval takes effect immediately. Also verify multiple advertisements work correctly as well. Change-Id: I058e4c7a9feeee691f507903037e581e9eb2978d Reviewed-on: https://chromium-review.googlesource.com/425558 Commit-Ready: Shyh-In Hwang <josephsih@chromium.org> Tested-by: Shyh-In Hwang <josephsih@chromium.org> Tested-by: Miao-chen Chou <mcchou@chromium.org> Reviewed-by: Shyh-In Hwang <josephsih@chromium.org> Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by: Miao-chen Chou <mcchou@chromium.org> (cherry picked from commit c3146bdf8e8765bbdbe727bbbda24d641609f39e) Reviewed-on: https://chromium-review.googlesource.com/430456 Commit-Ready: Miao-chen Chou <mcchou@chromium.org> [modify] https://crrev.com/57744b471c63ea63ba9932207fe1749eb2b28baa/net/bluetooth/mgmt.c [modify] https://crrev.com/57744b471c63ea63ba9932207fe1749eb2b28baa/net/bluetooth/hci_core.c [modify] https://crrev.com/57744b471c63ea63ba9932207fe1749eb2b28baa/include/net/bluetooth/hci_core.h [modify] https://crrev.com/57744b471c63ea63ba9932207fe1749eb2b28baa/net/bluetooth/hci_request.c
,
Jan 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/7e28173e9785072936d2a95fa89e902c2b3833ef commit 7e28173e9785072936d2a95fa89e902c2b3833ef Author: Joseph Hwang <josephsih@chromium.org> Date: Thu Jan 05 08:39:07 2017 CHROMIUM: bluetooth: update advertising parameters for single advertisement Currently, the advertisement scheduling algorithm does not update the advertising data and parameters on the controller if there is only one advertisement. This saves effort when the advertisement data and parameters are not changed. Since new methods have been provided to change advertising intervals and duration, it is needed to have a flag to indicate the change and update the controller accordingly when the flag is set true. BUG= chromium:673499 TEST=Use the "nRF Connect" android app to verify. Single advertisement: - register a single advertisement, - change the advertising interval, and - check if the new interval takes effect immediately. Also verify multiple advertisements work correctly as well. Change-Id: I058e4c7a9feeee691f507903037e581e9eb2978d Reviewed-on: https://chromium-review.googlesource.com/425558 Commit-Ready: Shyh-In Hwang <josephsih@chromium.org> Tested-by: Shyh-In Hwang <josephsih@chromium.org> Tested-by: Miao-chen Chou <mcchou@chromium.org> Reviewed-by: Shyh-In Hwang <josephsih@chromium.org> Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by: Miao-chen Chou <mcchou@chromium.org> (cherry picked from commit c3146bdf8e8765bbdbe727bbbda24d641609f39e) Reviewed-on: https://chromium-review.googlesource.com/430458 Commit-Ready: Miao-chen Chou <mcchou@chromium.org> [modify] https://crrev.com/7e28173e9785072936d2a95fa89e902c2b3833ef/net/bluetooth/mgmt.c [modify] https://crrev.com/7e28173e9785072936d2a95fa89e902c2b3833ef/net/bluetooth/hci_core.c [modify] https://crrev.com/7e28173e9785072936d2a95fa89e902c2b3833ef/include/net/bluetooth/hci_core.h [modify] https://crrev.com/7e28173e9785072936d2a95fa89e902c2b3833ef/net/bluetooth/hci_request.c
,
Jan 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/8848bb4b93d693a9295f66a677eba75c71dfa78a commit 8848bb4b93d693a9295f66a677eba75c71dfa78a Author: Joseph Hwang <josephsih@chromium.org> Date: Thu Jan 05 08:39:07 2017 CHROMIUM: bluetooth: update advertising parameters for single advertisement Currently, the advertisement scheduling algorithm does not update the advertising data and parameters on the controller if there is only one advertisement. This saves effort when the advertisement data and parameters are not changed. Since new methods have been provided to change advertising intervals and duration, it is needed to have a flag to indicate the change and update the controller accordingly when the flag is set true. BUG= chromium:673499 TEST=Use the "nRF Connect" android app to verify. Single advertisement: - register a single advertisement, - change the advertising interval, and - check if the new interval takes effect immediately. Also verify multiple advertisements work correctly as well. Change-Id: I058e4c7a9feeee691f507903037e581e9eb2978d Reviewed-on: https://chromium-review.googlesource.com/425558 Commit-Ready: Shyh-In Hwang <josephsih@chromium.org> Tested-by: Shyh-In Hwang <josephsih@chromium.org> Tested-by: Miao-chen Chou <mcchou@chromium.org> Reviewed-by: Shyh-In Hwang <josephsih@chromium.org> Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by: Miao-chen Chou <mcchou@chromium.org> (cherry picked from commit c3146bdf8e8765bbdbe727bbbda24d641609f39e) Reviewed-on: https://chromium-review.googlesource.com/430455 Commit-Ready: Miao-chen Chou <mcchou@chromium.org> [modify] https://crrev.com/8848bb4b93d693a9295f66a677eba75c71dfa78a/net/bluetooth/mgmt.c [modify] https://crrev.com/8848bb4b93d693a9295f66a677eba75c71dfa78a/net/bluetooth/hci_core.c [modify] https://crrev.com/8848bb4b93d693a9295f66a677eba75c71dfa78a/include/net/bluetooth/hci_core.h [modify] https://crrev.com/8848bb4b93d693a9295f66a677eba75c71dfa78a/net/bluetooth/hci_request.c
,
Jan 24 2017
Let me move the milestone from M56 to M57 and remove Merge-Review-56. Thanks.
,
Jan 25 2017
,
Jan 25 2017
,
Feb 1 2017
Verified in M-57 Dev-channel build 9202.12.0.
,
Feb 6 2017
Sorry that I used the wrong lable. It should be Merge-Request-57 instead of Merge-Review-57.
,
Feb 7 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/e9520b5dc2551b7024918b7bc75f4b1b65f3d162 commit e9520b5dc2551b7024918b7bc75f4b1b65f3d162 Author: Joseph Hwang <josephsih@chromium.org> Date: Fri Feb 10 01:37:08 2017 CHROMIUM: bluetooth: update advertising parameters for single advertisement Currently, the advertisement scheduling algorithm does not update the advertising data and parameters on the controller if there is only one advertisement. This saves effort when the advertisement data and parameters are not changed. Since new methods have been provided to change advertising intervals and duration, it is needed to have a flag to indicate the change and update the controller accordingly when the flag is set true. BUG= chromium:673499 TEST=Use the "nRF Connect" android app to verify. Single advertisement: - register a single advertisement, - change the advertising interval, and - check if the new interval takes effect immediately. Also verify multiple advertisements work correctly as well. Change-Id: I058e4c7a9feeee691f507903037e581e9eb2978d Reviewed-on: https://chromium-review.googlesource.com/425558 Commit-Ready: Shyh-In Hwang <josephsih@chromium.org> Tested-by: Shyh-In Hwang <josephsih@chromium.org> Tested-by: Miao-chen Chou <mcchou@chromium.org> Reviewed-by: Shyh-In Hwang <josephsih@chromium.org> Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by: Miao-chen Chou <mcchou@chromium.org> (cherry picked from commit c3146bdf8e8765bbdbe727bbbda24d641609f39e) Reviewed-on: https://chromium-review.googlesource.com/439054 Trybot-Ready: Miao-chen Chou <mcchou@chromium.org> Trybot-Ready: Shyh-In Hwang <josephsih@chromium.org> Commit-Queue: Shyh-In Hwang <josephsih@chromium.org> [modify] https://crrev.com/e9520b5dc2551b7024918b7bc75f4b1b65f3d162/net/bluetooth/mgmt.c [modify] https://crrev.com/e9520b5dc2551b7024918b7bc75f4b1b65f3d162/net/bluetooth/hci_core.c [modify] https://crrev.com/e9520b5dc2551b7024918b7bc75f4b1b65f3d162/include/net/bluetooth/hci_core.h [modify] https://crrev.com/e9520b5dc2551b7024918b7bc75f4b1b65f3d162/net/bluetooth/hci_request.c
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/b6e71c000dec1dce4153afbe2dc87fcecd08b5fd commit b6e71c000dec1dce4153afbe2dc87fcecd08b5fd Author: Joseph Hwang <josephsih@chromium.org> Date: Fri Feb 10 01:37:14 2017 CHROMIUM: bluetooth: update advertising parameters for single advertisement Currently, the advertisement scheduling algorithm does not update the advertising data and parameters on the controller if there is only one advertisement. This saves effort when the advertisement data and parameters are not changed. Since new methods have been provided to change advertising intervals and duration, it is needed to have a flag to indicate the change and update the controller accordingly when the flag is set true. BUG= chromium:673499 TEST=Use the "nRF Connect" android app to verify. Single advertisement: - register a single advertisement, - change the advertising interval, and - check if the new interval takes effect immediately. Also verify multiple advertisements work correctly as well. Change-Id: I058e4c7a9feeee691f507903037e581e9eb2978d Reviewed-on: https://chromium-review.googlesource.com/425558 Commit-Ready: Shyh-In Hwang <josephsih@chromium.org> Tested-by: Shyh-In Hwang <josephsih@chromium.org> Tested-by: Miao-chen Chou <mcchou@chromium.org> Reviewed-by: Shyh-In Hwang <josephsih@chromium.org> Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by: Miao-chen Chou <mcchou@chromium.org> (cherry picked from commit c3146bdf8e8765bbdbe727bbbda24d641609f39e) Reviewed-on: https://chromium-review.googlesource.com/439052 Trybot-Ready: Miao-chen Chou <mcchou@chromium.org> Trybot-Ready: Shyh-In Hwang <josephsih@chromium.org> Commit-Queue: Shyh-In Hwang <josephsih@chromium.org> [modify] https://crrev.com/b6e71c000dec1dce4153afbe2dc87fcecd08b5fd/net/bluetooth/mgmt.c [modify] https://crrev.com/b6e71c000dec1dce4153afbe2dc87fcecd08b5fd/net/bluetooth/hci_core.c [modify] https://crrev.com/b6e71c000dec1dce4153afbe2dc87fcecd08b5fd/include/net/bluetooth/hci_core.h [modify] https://crrev.com/b6e71c000dec1dce4153afbe2dc87fcecd08b5fd/net/bluetooth/hci_request.c
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/f83aa1167ca6b4c9f6257b9c5097cc12447f7b8b commit f83aa1167ca6b4c9f6257b9c5097cc12447f7b8b Author: Joseph Hwang <josephsih@chromium.org> Date: Fri Feb 10 01:37:19 2017 CHROMIUM: bluetooth: update advertising parameters for single advertisement Currently, the advertisement scheduling algorithm does not update the advertising data and parameters on the controller if there is only one advertisement. This saves effort when the advertisement data and parameters are not changed. Since new methods have been provided to change advertising intervals and duration, it is needed to have a flag to indicate the change and update the controller accordingly when the flag is set true. BUG= chromium:673499 TEST=Use the "nRF Connect" android app to verify. Single advertisement: - register a single advertisement, - change the advertising interval, and - check if the new interval takes effect immediately. Also verify multiple advertisements work correctly as well. Change-Id: I058e4c7a9feeee691f507903037e581e9eb2978d Reviewed-on: https://chromium-review.googlesource.com/425558 Commit-Ready: Shyh-In Hwang <josephsih@chromium.org> Tested-by: Shyh-In Hwang <josephsih@chromium.org> Tested-by: Miao-chen Chou <mcchou@chromium.org> Reviewed-by: Shyh-In Hwang <josephsih@chromium.org> Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by: Miao-chen Chou <mcchou@chromium.org> (cherry picked from commit c3146bdf8e8765bbdbe727bbbda24d641609f39e) Reviewed-on: https://chromium-review.googlesource.com/439053 Trybot-Ready: Miao-chen Chou <mcchou@chromium.org> Trybot-Ready: Shyh-In Hwang <josephsih@chromium.org> Commit-Queue: Shyh-In Hwang <josephsih@chromium.org> [modify] https://crrev.com/f83aa1167ca6b4c9f6257b9c5097cc12447f7b8b/net/bluetooth/mgmt.c [modify] https://crrev.com/f83aa1167ca6b4c9f6257b9c5097cc12447f7b8b/net/bluetooth/hci_core.c [modify] https://crrev.com/f83aa1167ca6b4c9f6257b9c5097cc12447f7b8b/include/net/bluetooth/hci_core.h [modify] https://crrev.com/f83aa1167ca6b4c9f6257b9c5097cc12447f7b8b/net/bluetooth/hci_request.c
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/cb839b310da78edb82cbb41e352b2cc3163b3800 commit cb839b310da78edb82cbb41e352b2cc3163b3800 Author: Joseph Hwang <josephsih@chromium.org> Date: Fri Feb 10 01:37:23 2017 CHROMIUM: bluetooth: update advertising parameters for single advertisement Currently, the advertisement scheduling algorithm does not update the advertising data and parameters on the controller if there is only one advertisement. This saves effort when the advertisement data and parameters are not changed. Since new methods have been provided to change advertising intervals and duration, it is needed to have a flag to indicate the change and update the controller accordingly when the flag is set true. BUG= chromium:673499 TEST=Use the "nRF Connect" android app to verify. Single advertisement: - register a single advertisement, - change the advertising interval, and - check if the new interval takes effect immediately. Also verify multiple advertisements work correctly as well. Change-Id: I058e4c7a9feeee691f507903037e581e9eb2978d Reviewed-on: https://chromium-review.googlesource.com/425558 Commit-Ready: Shyh-In Hwang <josephsih@chromium.org> Tested-by: Shyh-In Hwang <josephsih@chromium.org> Tested-by: Miao-chen Chou <mcchou@chromium.org> Reviewed-by: Shyh-In Hwang <josephsih@chromium.org> Reviewed-by: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by: Miao-chen Chou <mcchou@chromium.org> (cherry picked from commit c3146bdf8e8765bbdbe727bbbda24d641609f39e) Reviewed-on: https://chromium-review.googlesource.com/439051 Trybot-Ready: Miao-chen Chou <mcchou@chromium.org> Trybot-Ready: Shyh-In Hwang <josephsih@chromium.org> Commit-Queue: Shyh-In Hwang <josephsih@chromium.org> [modify] https://crrev.com/cb839b310da78edb82cbb41e352b2cc3163b3800/net/bluetooth/mgmt.c [modify] https://crrev.com/cb839b310da78edb82cbb41e352b2cc3163b3800/net/bluetooth/hci_core.c [modify] https://crrev.com/cb839b310da78edb82cbb41e352b2cc3163b3800/include/net/bluetooth/hci_core.h [modify] https://crrev.com/cb839b310da78edb82cbb41e352b2cc3163b3800/net/bluetooth/hci_request.c
,
Feb 10 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 13 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 16 2017
,
Mar 3 2017
,
Mar 3 2017
|
||||||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||||
Comment 1 by harpreet@chromium.org
, Dec 12 2016