New issue
Advanced search Search tips

Issue 673498 link

Starred by 1 user
Status: Archived
Owner: ----
Closed: Sep 13
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Clean up threading in TaskManager's SharedSampler

Project Member Reported by w...@chromium.org, Dec 12 2016 
SharedSampler uses a single implementation object which is called on the UI thread but does work on the blocking worker pool, using the same object.

We should split the worker-pool state out to a separate private core object to protect against unintended multi-threaded use of SharedSampler fields.

Comment 1 by w...@chromium.org, Dec 13 2016 

Since this code is working with an internal NT API, perhaps we should also consider adding dump-without-crashing logic somewhere in here, to give us some visibility if we start seeing new problem behaviours?

Comment 2 by stanisc@chromium.org, Dec 13 2016 

That is a good suggestion. I think any time this code fails to produce a snapshot there should be a dump without crash (with a flag to prevent doing that continuously).

Comment 3 by stanisc@chromium.org, Feb 3 2017

Cc: -stanisc@chromium.org
Owner: stanisc@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by stanisc@chromium.org, Nov 1 2017

Owner: ----
Status: Untriaged (was: Assigned)
Flagging this for re-triage. I won't be able to work on this.

Comment 5 by robliao@chromium.org, Sep 13

Status: Archived (was: Untriaged)
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
►

Sign in to add a comment