New issue
Advanced search Search tips

Issue 673463 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

fast/forms/associatedFormControls-leak-nodes.html failing on WebKit Linux bots

Project Member Reported by asargent@chromium.org, Dec 12 2016

Issue description

The webkit_tests step is failing due to the  fast/forms/associatedFormControls-leak-nodes.html test on 3 different Linux builders (I haven't noticed it failing on other platforms - not sure if it runs everywhere or just on linux though). This has happened several times in a row now, and according to sheriff-o-mattic this seemed to start with revision range 437893 - 437901:

https://chromium.googlesource.com/chromium/src/+log/140c9756623a2e4357a1385726cb6d0e898addc3%5E..d8f3464da24b2cdc50ed3169e45d431299786edb?pretty=fuller

Nothing in that revision range jumps out to me as an obvious cause, but I'm relatively unfamiliar with this area of code. 


---------------------------
Here's a snippet of the log output from a recent failure:


11:36:41.024 14902 "/usr/bin/wdiff --start-delete=##WDIFF_DEL## --end-delete=##WDIFF_END## --start-insert=##WDIFF_ADD## --end-insert=##WDIFF_END## /b/rr/tmpvn33Sx/w/layout-test-results/fast/forms/associatedFormControls-leak-nodes-expected.txt /b/rr/tmpvn33Sx/w/layout-test-results/fast/forms/associatedFormControls-leak-nodes-actual.txt" took 0.02s
11:36:41.115 14902 "ruby -I /b/c/b/linux_layout/src/third_party/WebKit/Tools/Scripts/webkitruby/PrettyPatch /b/c/b/linux_layout/src/third_party/WebKit/Tools/Scripts/webkitruby/PrettyPatch/prettify.rb /b/rr/tmpvn33Sx/w/layout-test-results/fast/forms/associatedFormControls-leak-nodes-diff.txt" took 0.09s
11:36:41.116 14814 [21922/47988] fast/forms/associatedFormControls-leak-nodes.html failed unexpectedly (text diff)
11:36:41.115 14902 worker/7 fast/forms/associatedFormControls-leak-nodes.html failed:
11:36:41.115 14902 worker/7  text diff

This was from https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/20940/steps/webkit_tests/logs/stdio

---------------------------

 
Cc: haraken@chromium.org
Owner: keishi@chromium.org
Status: Assigned (was: Untriaged)
Assigning to keishi and +cc haraken, since I see some related work you two have been doing for  bug 585328 . Note that there was a V8 roll in the revision range when this started failing; maybe something GC related changed that is making the test fail?

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d788939ee6fbab475c463e1d441a1688d31cda7

commit 7d788939ee6fbab475c463e1d441a1688d31cda7
Author: Antony Sargent <asargent@chromium.org>
Date: Mon Dec 12 20:50:56 2016

Change expectations for associatedFormControls-leak-nodes.html on linux

This test has been failing on the WebKit Linux bots today.

TBR=keishi@chromium.org

BUG= 673463 

Review-Url: https://codereview.chromium.org/2568273002 .
Cr-Commit-Position: refs/heads/master@{#437911}

[modify] https://crrev.com/7d788939ee6fbab475c463e1d441a1688d31cda7/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/206ae7f05c22113462df0364b5d8b8c8cfccfc2a

commit 206ae7f05c22113462df0364b5d8b8c8cfccfc2a
Author: tkent <tkent@chromium.org>
Date: Wed Dec 14 03:22:46 2016

Remove an entry for associatedFormControls-leak-nodes.html.

Looks like a clang roll caused a failure, and the roll was reverted.

BUG= 673463 
TBR=asargent@chromium.org, thakis@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2574963002
Cr-Commit-Position: refs/heads/master@{#438411}

[modify] https://crrev.com/206ae7f05c22113462df0364b5d8b8c8cfccfc2a/third_party/WebKit/LayoutTests/TestExpectations

Comment 4 by tkent@chromium.org, Dec 14 2016

Status: WontFix (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/299b2474f698a03d54cb12e484c389b82c47d9ca

commit 299b2474f698a03d54cb12e484c389b82c47d9ca
Author: thakis <thakis@chromium.org>
Date: Wed Dec 14 19:38:00 2016

Make an existing workaround a bit broader.

Without this, the test seems to fail after clang roll
https://codereview.chromium.org/2577523002
Since there's already a workaround, this is likely triggering
the same existing bug that already has a workaround, and not
due to a new compiler bug.

BUG= 673463 , 674194 
TBR=tkent

Review-Url: https://codereview.chromium.org/2569763006
Cr-Commit-Position: refs/heads/master@{#438595}

[modify] https://crrev.com/299b2474f698a03d54cb12e484c389b82c47d9ca/third_party/WebKit/LayoutTests/fast/forms/associatedFormControls-leak-nodes.html

Sign in to add a comment