New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 673462 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

codesearch finds tons of files ending in "filepaths" that don't exist in the checkout

Project Member Reported by jochen@chromium.org, Dec 12 2016

Issue description

see attached screenshot
 
filepaths.png
103 KB View Download
Owner: dsansome@chromium.org
Status: Assigned (was: Untriaged)
Interesting, this looks like an artefact of the way we build the grok index packs.  I'll look into it.

Comment 2 by emso@chromium.org, Dec 13 2016

Labels: Stability
These files are used to create the Xref index pack, e.g., each .filepaths file lists the files needed to replay the compilation of the corresponding file. They should not be included in the source tar ball used for indexing. 

The fix is simple so I sent out a CL: https://chromium-review.googlesource.com/c/419018/

Note that this does not happen on staging (https://cs-staging.chromium.org/search/?q=.*filepaths+package:%5Echromium$&type=cs), where files are read from the Git repo and the intermediate files are not checked in. 
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/691add00f8f9ba2813e1b3a02bb98c41a38c6556

commit 691add00f8f9ba2813e1b3a02bb98c41a38c6556
Author: Emma Soederberg <emso@chromium.org>
Date: Tue Dec 13 08:34:24 2016

Adds filtering of .filepaths files.

These files are generated and used to create the index pack sent to the Xrefs service.
They should not be included in the tar ball with source files.

BUG= 673462 

Change-Id: I134144b5e18fb314715b247f531b8911bae0da66
Reviewed-on: https://chromium-review.googlesource.com/419018
Commit-Queue: Emma Söderberg <emso@chromium.org>
Commit-Queue: Dave Sansome <dsansome@chromium.org>
Reviewed-by: Dave Sansome <dsansome@chromium.org>

[modify] https://crrev.com/691add00f8f9ba2813e1b3a02bb98c41a38c6556/scripts/slave/archive_source_codesearch.py

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/fd30e6d4d3755bddbb81e675531f97db12e27e75

commit fd30e6d4d3755bddbb81e675531f97db12e27e75
Author: Emma Soederberg <emso@chromium.org>
Date: Tue Dec 13 08:57:42 2016

Updates comments to include info about .filepaths filtering.

BUG= 673462 

Change-Id: Id0c0d6395be4859b7d1293dea4d230c8c57c4a44
Reviewed-on: https://chromium-review.googlesource.com/418720
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Emma Söderberg <emso@chromium.org>

[modify] https://crrev.com/fd30e6d4d3755bddbb81e675531f97db12e27e75/scripts/slave/archive_source_codesearch.py

Comment 5 by emso@chromium.org, Dec 14 2016

Owner: emso@chromium.org
Status: Verified (was: Assigned)

Sign in to add a comment