New issue
Advanced search Search tips

Issue 673458 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Chrome on Android sometimes using stale locale .pak files

Project Member Reported by agrieve@chromium.org, Dec 12 2016

Issue description

For full context, see mailing-list thread:
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/S7ueJ65wtv4/discussion

Repro steps:

1. Obtain root on the device
2. Install version A of the browser
3. Move the browser app to SD card (we don't allow it in the manifest, but with root privileges it is still possible)
4. Remove the SD card
5. Install version B of the browser with different v8 snapshot version as compared to A.
 
For some reason, PackageInfo.lastUpdateTime is not changed in this scenario, so resources are not extracted from the version B, instead, extracted resources from version A remain (the extracted resources are part of app data which is not part of ASEC container so it is not moved to SD card).
 
And this line from logcat looks interesting, because it describes what seems to be happening:
 
12-09 14:37:27.972 I/PackageManager( 820): Package com.yandex.browser codePath changed from /mnt/asec/com.yandex.browser-1/pkg.apk to /data/app/com.yandex.browser-1.apk; Retaining data and using new
 
An alternative scenario is to install version A on SD card 1, remove SD card 1, insert SD card 2, install version B on SD card 2, then remove SD card 2 and put SD card 1 back in.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ceb34ed05b1ba1240e34ebc8f268a7049ddb7af

commit 3ceb34ed05b1ba1240e34ebc8f268a7049ddb7af
Author: agrieve <agrieve@chromium.org>
Date: Tue Dec 13 19:52:09 2016

Android: Use both versionCode and lastUpdateTime for change-detection

I haven't gone through the (obscure) steps to repro the failure, but
this change is easy enough and I can't see how it could hurt anything.

BUG= 673458 

Review-Url: https://codereview.chromium.org/2573633002
Cr-Commit-Position: refs/heads/master@{#438263}

[modify] https://crrev.com/3ceb34ed05b1ba1240e34ebc8f268a7049ddb7af/base/android/java/src/org/chromium/base/ResourceExtractor.java

Status: Fixed (was: Started)
Cc: -vabr@chromium.org

Sign in to add a comment