New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 673450 link

Starred by 1 user
Status: Fixed
Owner:
█ romax@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Test harness would crash due to violating StrictMode

Project Member Reported by romax@chromium.org, Dec 12 2016 
Since logging was called on UI thread, it might violate StrictMode which would lead to a crash. Should instead using async tasks.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fc9052b9a898a37d8a191522ee8c0a2ce86fa20

commit 7fc9052b9a898a37d8a191522ee8c0a2ce86fa20
Author: romax <romax@chromium.org>
Date: Thu Dec 15 19:47:37 2016

[Offline Pages] Use async log writing to avoid violating StrictMode.

Fixed the crash caused by logging to files on UI thread and violating
StrictMode by changing log to AsyncTask.

BUG= 673450 

Review-Url: https://codereview.chromium.org/2562283004
Cr-Commit-Position: refs/heads/master@{#438896}

[modify] https://crrev.com/7fc9052b9a898a37d8a191522ee8c0a2ce86fa20/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/evaluation/OfflinePageEvaluationBridge.java

Comment 2 by romax@chromium.org, Dec 15 2016

Status: Fixed (was: Started)
►

Sign in to add a comment