New issue
Advanced search Search tips

Issue 673446 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Open select dropdown flickers when "selectedIndex" property is set

Reported by jcar...@stainlesscode.com, Dec 12 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.79 Safari/537.36 Edge/14.14393

Steps to reproduce the problem:
1. Go to this URL: https://jsfiddle.net/845w541n/12/
2. Open the select dropdown in the "preview" pane
3. Watch the flicker

What is the expected behavior?
When you open the dropdown, it shouldn't flicker, even thought "selectedIndex" is being set.

What went wrong?
When you open the dropdown, it flickers because "selectedIndex" is being set.

Did this work before? Yes 49.0.2623.87

Does this work in other browsers? Yes

Chrome version: 55.0.2883.87  Channel: stable
OS Version: 10.11.6
Flash Version: 23.0.0.207

- According to our client (end-user) This DOES NOT happen on 49.0.2623.87 OSX, but DOES happen on 53.0.2785.143 OSX. 
- We (web developers) have confirmed it DOES happen on 55.0.2883.87 OSX.
- We have confirmed this DOES NOT happen on Chrome on Windows (55.0.2883.87), Edge & Opera on Windows, nor Firefox on OSX.
 
Typo correction:
When you open the dropdown, it shouldn't flicker, even *though "selectedIndex" is being set.

Comment 2 by rsesek@chromium.org, Dec 12 2016

Components: Blink>Forms>Select
Owner: tkent@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 392952 (known good), but no later than 392967 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/3e302bd544e4ac9ac1b119424a5b4d100340c70b..22863bca75277a5abce27fe961680e73171bb462

Probably https://chromium.googlesource.com/chromium/src/+/1d5b6507ac2cbfdbb733cbefa1dbbce091b11a06. This would have first gone bad in 52.0.2733.0.

Comment 3 by tkent@chromium.org, Dec 14 2016

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abc1c2f1d368e085dd3556f45c0fb861965abc75

commit abc1c2f1d368e085dd3556f45c0fb861965abc75
Author: tkent <tkent@chromium.org>
Date: Wed Dec 14 08:22:17 2016

SELECT element: Do not update popup menu content by touching selectedIndex

* HTMLSelectElement::selectOption
 Calls PopupMenu::updateFromElement() only if OPTION selection state was changed.

BUG= 673446 

Review-Url: https://codereview.chromium.org/2572953002
Cr-Commit-Position: refs/heads/master@{#438461}

[modify] https://crrev.com/abc1c2f1d368e085dd3556f45c0fb861965abc75/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
[modify] https://crrev.com/abc1c2f1d368e085dd3556f45c0fb861965abc75/third_party/WebKit/Source/core/html/HTMLSelectElement.h

Comment 5 by tkent@chromium.org, Dec 14 2016

Labels: M-57
Status: Fixed (was: Started)

Sign in to add a comment