New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 673445 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

DevTools: speed up closure dependency checking

Project Member Reported by chenwilliam@chromium.org, Dec 12 2016

Issue description

Currently DevTools runs closure compiler with multiple passes to ensure that each module does not rely on other modules that are not its dependencies (either directly or transitively).

By generating a devtools front-end before the closure compilation step with poisoned namespaces, we can do a single-pass closure compilation and still verify module dependencies
 
Summary: DevTools: speed up closure dependency checking (was: DevTools: use closure's module system for type checking )
Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bc46a6dd144aa85e0aecd8f16631dc6bbdfa11e

commit 2bc46a6dd144aa85e0aecd8f16631dc6bbdfa11e
Author: chenwilliam <chenwilliam@chromium.org>
Date: Wed Jan 11 01:20:44 2017

DevTools: speed up closure dependency checking

Compiling frontend runs in ~13 seconds (including dependency check) instead of 22 seconds.

Examples of the RegEx match:
http://regexr.com/3etk5

The following CL needs to land before this CL lands:
https://codereview.chromium.org/2623743002/
BUG= 673445 

Review-Url: https://codereview.chromium.org/2588843002
Cr-Commit-Position: refs/heads/master@{#442754}

[modify] https://crrev.com/2bc46a6dd144aa85e0aecd8f16631dc6bbdfa11e/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/2bc46a6dd144aa85e0aecd8f16631dc6bbdfa11e/third_party/WebKit/Source/devtools/front_end/Runtime.js
[modify] https://crrev.com/2bc46a6dd144aa85e0aecd8f16631dc6bbdfa11e/third_party/WebKit/Source/devtools/scripts/README.md
[modify] https://crrev.com/2bc46a6dd144aa85e0aecd8f16631dc6bbdfa11e/third_party/WebKit/Source/devtools/scripts/build/modular_build.py
[modify] https://crrev.com/2bc46a6dd144aa85e0aecd8f16631dc6bbdfa11e/third_party/WebKit/Source/devtools/scripts/compile_frontend.py
[add] https://crrev.com/2bc46a6dd144aa85e0aecd8f16631dc6bbdfa11e/third_party/WebKit/Source/devtools/scripts/dependency_preprocessor.py
[modify] https://crrev.com/2bc46a6dd144aa85e0aecd8f16631dc6bbdfa11e/third_party/WebKit/Source/devtools/scripts/special_case_namespaces.json

Status: Fixed (was: Started)

Sign in to add a comment