New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 673439 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Set up battor agent builder for power infra

Project Member Reported by martiniss@chromium.org, Dec 12 2016

Issue description

Power infra wants to set up a builder to compile the battor agent. It should compile on Windows, Mac, and Linux.

For now, it can go on chromium.perf.fyi. We might move it later.
 
Hey Stephen, any update on this?
Sorry for the late update. Looks like this shouldn't be too bad.

It looks like we can run arbitrary scripts for a chromium builder. See https://cs.chromium.org/chromium/src/testing/scripts/webkit_lint.py?q=testing/scripts/webkit_lint.py&sq=package:chromium&dr for an example script, and https://cs.chromium.org/chromium/src/testing/buildbot/chromium.webkit.json?l=68 for the usage. Not sure how google storage upload will fit into all of this.

I'm working on getting hardware we can use. 


Project Member

Comment 4 by bugdroid1@chromium.org, Jan 9 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/9f1b8056d53c15df6b7069b7347108c9ed7c2b70

commit 9f1b8056d53c15df6b7069b7347108c9ed7c2b70
Author: Stephen Martinis <martiniss@google.com>
Date: Mon Jan 09 22:50:28 2017

So, I know we have the builder, can we close this?

Stephen?
Stephen, do you know how I can go about accessing the battor_agent binaries built on the builder?
No, it's not done yet. Need to set up some more stuff.

Working on it now!
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/92b2eb22c9003412820d2ddb111e125cdec71c13

commit 92b2eb22c9003412820d2ddb111e125cdec71c13
Author: Stephen Martinis <martiniss@google.com>
Date: Tue Feb 14 19:04:56 2017

chromium.perf.fyi: Add battor builder to scheduler

BUG= 673439 

Change-Id: I467fc94ac4fa90d97076c109bf61f19b829596e9
Reviewed-on: https://chromium-review.googlesource.com/442076
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/92b2eb22c9003412820d2ddb111e125cdec71c13/masters/master.chromium.perf.fyi/master.cfg

Project Member

Comment 9 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/700e2f9d6aef20050c9c9af2ba581ab5197346ea

commit 700e2f9d6aef20050c9c9af2ba581ab5197346ea
Author: Stephen Martinis <martiniss@google.com>
Date: Tue Feb 14 19:11:53 2017

https://codereview.chromium.org/2694163005 should solve the linux bot.

Then, I'll need to set up a windows and mac bot.
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/473ab1978338023514f8c1ff147f505bdefb9324

commit 473ab1978338023514f8c1ff147f505bdefb9324
Author: martiniss <martiniss@chromium.org>
Date: Wed Feb 15 05:59:46 2017

mb_config.pyl: Add Battor Agent Linux

Using official_goma_minimal_symbols_clang for now.

BUG= 673439 

Review-Url: https://codereview.chromium.org/2694163005
Cr-Commit-Position: refs/heads/master@{#450577}

[modify] https://crrev.com/473ab1978338023514f8c1ff147f505bdefb9324/tools/mb/mb_config.pyl

The bot's not set up to do release builds. Will fix tomorrow.
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/047a8dc346ed02f64f206e0075dd5c37661b86f4

commit 047a8dc346ed02f64f206e0075dd5c37661b86f4
Author: Stephen Martinis <martiniss@google.com>
Date: Wed Feb 15 22:26:48 2017

chromium.perf.fyi: Use official builds on Battor Agent Linux

BUG= 673439 

Change-Id: Ib0f6504f5aea7df88a1719c262c21323deec4908
Reviewed-on: https://chromium-review.googlesource.com/443333
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/047a8dc346ed02f64f206e0075dd5c37661b86f4/scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py
[modify] https://crrev.com/047a8dc346ed02f64f206e0075dd5c37661b86f4/scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Battor_Agent_Linux.json

Project Member

Comment 14 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/d223b0f34d7a941848ec0b387819734658f5611c

commit d223b0f34d7a941848ec0b387819734658f5611c
Author: Stephen Martinis <martiniss@chromium.org>
Date: Thu Feb 16 17:10:52 2017

Revert "chromium.perf.fyi: Use official builds on Battor Agent Linux"

This reverts commit 047a8dc346ed02f64f206e0075dd5c37661b86f4.

Reason for revert: Using regular build, not official.

Original change's description:
> chromium.perf.fyi: Use official builds on Battor Agent Linux
> 
> BUG= 673439 
> 
> Change-Id: Ib0f6504f5aea7df88a1719c262c21323deec4908
> Reviewed-on: https://chromium-review.googlesource.com/443333
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> 

TBR=iannucci@chromium.org,dpranke@chromium.org,charliea@chromium.org,tandrii@chromium.org,martiniss@chromium.org,jbudorick@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 673439 

Change-Id: Ibcb7713e56f65397a949c4d84592e3d4c9027063
Reviewed-on: https://chromium-review.googlesource.com/444064
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/d223b0f34d7a941848ec0b387819734658f5611c/scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py
[modify] https://crrev.com/d223b0f34d7a941848ec0b387819734658f5611c/scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Battor_Agent_Linux.json

Project Member

Comment 15 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09994822726a5e65ebc53b048f17a50c50489e60

commit 09994822726a5e65ebc53b048f17a50c50489e60
Author: martiniss <martiniss@chromium.org>
Date: Thu Feb 16 20:15:05 2017

Move Battor Agent Linux to debug_bot

Don't really need a release build on the bot, I think.

BUG= 673439 

Review-Url: https://codereview.chromium.org/2698753003
Cr-Commit-Position: refs/heads/master@{#451076}

[modify] https://crrev.com/09994822726a5e65ebc53b048f17a50c50489e60/tools/mb/mb_config.pyl

Owner: charliea@chromium.org
Ok, we have a successful build! https://build.chromium.org/p/chromium.perf.fyi/builders/Battor%20Agent%20Linux/builds/490

Charlie, can you try clicking the "download" link on the archive build in that build? That's automatically done for you, so that'd be the way to download it.

If that link doesn't work for you, we can figure out how to make it work, but it'll be a bit more work.

I'll try to set up mac and windows builders for this.
Project Member

Comment 18 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/e99a7805ce3c1fef96b428fb542d23fe975e8c5c

commit e99a7805ce3c1fef96b428fb542d23fe975e8c5c
Author: Stephen Martinis <martiniss@chromium.org>
Date: Thu May 18 22:19:27 2017

Fix bot config for battor non linux builders

Bug:  673439 
Change-Id: I4ea1531e7a5f3bca9729b6effaeaaa5977964b50
Reviewed-on: https://chromium-review.googlesource.com/508890
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/e99a7805ce3c1fef96b428fb542d23fe975e8c5c/masters/master.chromium.perf.fyi/slaves.cfg

Project Member

Comment 19 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/4ce003dfb93bb29be00794308f43d477523a81c6

commit 4ce003dfb93bb29be00794308f43d477523a81c6
Author: Stephen Martinis <martiniss@google.com>
Date: Fri May 19 00:39:55 2017

Project Member

Comment 20 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/17ab5b1573bb20a873287fefe76dde819c32e0cb

commit 17ab5b1573bb20a873287fefe76dde819c32e0cb
Author: Stephen Martinis <martiniss@chromium.org>
Date: Mon May 22 21:17:19 2017

Add battor agents to main chromium scheduler

Bug:  673439 
Change-Id: I6f6be536d24200b01b612a9309447ab98e1d6ea5
Reviewed-on: https://chromium-review.googlesource.com/511282
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/17ab5b1573bb20a873287fefe76dde819c32e0cb/masters/master.chromium.perf.fyi/master.cfg

Project Member

Comment 21 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/92217f0ffb2fd52d869d729b3372dac7932fcd3b

commit 92217f0ffb2fd52d869d729b3372dac7932fcd3b
Author: Stephen Martinis <martiniss@google.com>
Date: Mon May 22 21:20:56 2017

Owner: martiniss@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment