New issue
Advanced search Search tips

Issue 673437 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove duplicated code in PresentationServiceDelegateImplTest

Project Member Reported by taku...@chromium.org, Dec 12 2016

Issue description

Lots of setup code in the PresentationServiceDelegateImplTest subclasses can be moved to the main class to avoid duplication.
 

Comment 1 by mfo...@chromium.org, Dec 13 2016

Components: Tests
Labels: Hotlist-CodeHealth
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db922919b12172876644b800ae0d6d1a0c0d2d23

commit db922919b12172876644b800ae0d6d1a0c0d2d23
Author: takumif <takumif@chromium.org>
Date: Wed Dec 14 00:31:02 2016

Remove duplicated code in PresentationServiceDelegateImplTest

This CL takes media sources, mock listeners, and render frame IDs that were
being declared repeatedly in individual test cases, and makes them properties of
the main PresentationServiceDelegateImplTest class.

BUG= 673437 

Review-Url: https://codereview.chromium.org/2569843002
Cr-Commit-Position: refs/heads/master@{#438360}

[modify] https://crrev.com/db922919b12172876644b800ae0d6d1a0c0d2d23/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment