Renderer should defer activation/draw until GPU proc. work completes in SMOOTHNESS_TAKES_PRIORITY |
|||
Issue descriptionCurrently, the renderer will activate or draw with a tile as soon as the renderer-side tasks to generate that tile have completed. This can end up backing up the GPU process, as the duration of the GPU side work may not correspond with the renderer-side work. We should allow the renderer to delay activation and drawing of tiles which have not yet completed their GPU-process work. This will remove dependencies between the renderer worker GL context and the compositor GL context, allowing the GPU scheduler to better prioritize these. To start out, these changes will only impact SMOOTHNESS_TAKES_PRIORITY mode.
,
Jan 23 2017
Should this stay Pri-1? Since this is Feature work, should this be lower to Pri-2?
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31c92fe8317757707c7c910c7d67bc04fb6938be commit 31c92fe8317757707c7c910c7d67bc04fb6938be Author: sunnyps <sunnyps@chromium.org> Date: Fri Feb 10 23:46:55 2017 cc: Use compositor context for signal sync token callback. The signal sync token callback is run from an IPC message from the GPU process. IPC messages are received on the thread a context is bound to; for the worker context this is the main thread. This causes a data race and a crash during compositor tear down. Using the compositor context is fine because it is bound to the impl thread, and it's safe to receive tile manager callbacks there. R=ericrk@chromium.org,vmpstr@chromium.org BUG= 673434 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2682023005 Cr-Commit-Position: refs/heads/master@{#449792} [modify] https://crrev.com/31c92fe8317757707c7c910c7d67bc04fb6938be/cc/raster/gpu_raster_buffer_provider.cc [modify] https://crrev.com/31c92fe8317757707c7c910c7d67bc04fb6938be/cc/raster/one_copy_raster_buffer_provider.cc
,
Feb 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5a9848cb8132fd80c83be857d4560a53ce11f21 commit c5a9848cb8132fd80c83be857d4560a53ce11f21 Author: sunnyps <sunnyps@chromium.org> Date: Sat Feb 11 00:58:13 2017 cc: Remove resource freed tiles from tile manager pending gpu work set. CheckPendingGpuWorkTiles crashes because of nullptr dereference from tiles whose resources have been freed. R=ericrk@chromium.org,vmpstr@chromium.org BUG= 673434 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2680313007 Cr-Commit-Position: refs/heads/master@{#449810} [modify] https://crrev.com/c5a9848cb8132fd80c83be857d4560a53ce11f21/cc/tiles/tile_manager.cc
,
Jun 26 2017
,
Jun 27 2017
I think the work here is completed. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Dec 13 2016