New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 673424 link

Starred by 1 user
Status: Fixed
Owner:
k...@chromium.org
Closed: Feb 2017
Cc:
█ groby@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Hunspell suggestions runs too slow

Project Member Reported by k...@chromium.org, Dec 12 2016 
Hunspell 1.5.4, circa 57.0.2946.0, makes components_unittests::SpellCheckTest::NoSuggest time out

What is the expected result?

In previous versions of Hunspell, the test would complete in time.

What happens instead?

The test runs for ~80 seconds which times out the CQ bots.

Comment 1 by groby@chromium.org, Dec 12 2016

Status: Assigned (was: Untriaged)
Do the tests complete locally?

Comment 2 by k...@chromium.org, Dec 12 2016 

Yes. They do take a while, and usually don't time-out, which is why I thought it was good.

I've run it through cachegrind and removed the low hanging fruit, but I wasn't sure if you wanted it in this CL, or even anywhere except upstream. I made this bug so we could track the externality if we wanted.

Comment 3 by groby@chromium.org, Dec 23 2016 

If this is observable (e.g. jank when opening the context menu), we need to prioritize it in Chromium. Otherwise, upstream is fine.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba36291731404cfa22b167b3b9b318e1f4bb148f

commit ba36291731404cfa22b167b3b9b318e1f4bb148f
Author: krb <krb@chromium.org>
Date: Thu Jan 12 15:31:16 2017

[spellcheck] Updated Hunspell to 1.6.0

To pick up our upstreamed optimization for suggestions, and fuzzing bug fixes.

The license requirements were approved, by having README.chromium
specify which license it was using.

BUG= 673424 

Review-Url: https://codereview.chromium.org/2587363003
Cr-Commit-Position: refs/heads/master@{#443234}

[modify] https://crrev.com/ba36291731404cfa22b167b3b9b318e1f4bb148f/third_party/hunspell/COPYING
[add] https://crrev.com/ba36291731404cfa22b167b3b9b318e1f4bb148f/third_party/hunspell/COPYING.LESSER
[delete] https://crrev.com/8733eb80974a809a19c16535bfd39c867845acab/third_party/hunspell/COPYING.LGPL
[modify] https://crrev.com/ba36291731404cfa22b167b3b9b318e1f4bb148f/third_party/hunspell/README
[modify] https://crrev.com/ba36291731404cfa22b167b3b9b318e1f4bb148f/third_party/hunspell/README.chromium
[modify] https://crrev.com/ba36291731404cfa22b167b3b9b318e1f4bb148f/third_party/hunspell/google.patch
[delete] https://crrev.com/8733eb80974a809a19c16535bfd39c867845acab/third_party/hunspell/src/hunspell/README
[modify] https://crrev.com/ba36291731404cfa22b167b3b9b318e1f4bb148f/third_party/hunspell/src/hunspell/affixmgr.cxx
[modify] https://crrev.com/ba36291731404cfa22b167b3b9b318e1f4bb148f/third_party/hunspell/src/hunspell/hunspell.hxx
[delete] https://crrev.com/8733eb80974a809a19c16535bfd39c867845acab/third_party/hunspell/src/hunspell/license.hunspell
[delete] https://crrev.com/8733eb80974a809a19c16535bfd39c867845acab/third_party/hunspell/src/hunspell/license.myspell
[modify] https://crrev.com/ba36291731404cfa22b167b3b9b318e1f4bb148f/third_party/hunspell/src/hunspell/suggestmgr.cxx
[modify] https://crrev.com/ba36291731404cfa22b167b3b9b318e1f4bb148f/third_party/hunspell/src/hunspell/suggestmgr.hxx

Comment 5 by k...@chromium.org, Feb 6 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment