New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment
link

Issue 673395: Implement RTCConfiguration.iceCandidatePoolSize

Reported by deadbeef@chromium.org, Dec 12 2016 Project Member

Issue description

Comment 1 by bugdroid1@chromium.org, Mar 15 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff92bdcc0bed8878b0989f14993b3aec98a4769b

commit ff92bdcc0bed8878b0989f14993b3aec98a4769b
Author: deadbeef <deadbeef@chromium.org>
Date: Wed Mar 15 05:06:18 2017

Add support for RTCConfiguration.iceCandidatePoolSize.

This is a performance optimization that will result in ICE candidates
being gathered before setLocalDescription has been called. Later, when
setLocalDescription *is* called, any pooled candidates will be fired
in an "icecandidate" event immediately.

Besides candidate gathering appearing to occur quicker, this optimization
doesn't have any effects visible to JavaScript.

Note that the pool size can only be changed before setLocalDescription,
as described by JSEP. This pool is only intended to be used for the
first offer/answer, after which an ICE restart must be used to gather
new candidates.

Intent to Implement and Ship thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/dWXRWoi5ueg/nFiVhj5LCAAJ

BUG= chromium:673395 

Review-Url: https://codereview.chromium.org/2721163002
Cr-Commit-Position: refs/heads/master@{#456998}

[modify] https://crrev.com/ff92bdcc0bed8878b0989f14993b3aec98a4769b/content/renderer/media/peer_connection_tracker.cc
[modify] https://crrev.com/ff92bdcc0bed8878b0989f14993b3aec98a4769b/content/renderer/media/rtc_peer_connection_handler.cc
[modify] https://crrev.com/ff92bdcc0bed8878b0989f14993b3aec98a4769b/content/test/data/media/peerconnection-setConfiguration.html
[modify] https://crrev.com/ff92bdcc0bed8878b0989f14993b3aec98a4769b/third_party/WebKit/LayoutTests/external/wpt/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt
[modify] https://crrev.com/ff92bdcc0bed8878b0989f14993b3aec98a4769b/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-expected.txt
[modify] https://crrev.com/ff92bdcc0bed8878b0989f14993b3aec98a4769b/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html
[modify] https://crrev.com/ff92bdcc0bed8878b0989f14993b3aec98a4769b/third_party/WebKit/Source/modules/peerconnection/RTCConfiguration.idl
[modify] https://crrev.com/ff92bdcc0bed8878b0989f14993b3aec98a4769b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify] https://crrev.com/ff92bdcc0bed8878b0989f14993b3aec98a4769b/third_party/WebKit/public/platform/WebRTCConfiguration.h

Comment 2 by deadbeef@chromium.org, Mar 15 2017

Status: Fixed (was: Started)

Comment 3 by anatolid@chromium.org, Mar 27 2017

Labels: M-59

Comment 4 by apoorva....@gmail.com, May 14 2018

Can you please let me know which version of webrtc contains this fix?
https://www.chromestatus.com/features/5743313768415232 doesn't specify which version this feature is available on.

Comment 5 by deadbeef@chromium.org, May 15 2018

M-59 assuming the label is correct. Updated https://www.chromestatus.com/feature/4973817285836800.

Sign in to add a comment