New issue
Advanced search Search tips

Issue 673385 link

Starred by 1 user
Status: WontFix
Owner:
jbudorick@chromium.org
Closed: Dec 2016
Cc:
pkotw...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.chrome.browser.webapps.WebApkUpdateManagerTest#testCanonicalUrlsDifferentShouldUpgrade" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Dec 12 2016 
"org.chromium.chrome.browser.webapps.WebApkUpdateManagerTest#testCanonicalUrlsDifferentShouldUpgrade" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNybgsSBUZsYWtlImNvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIud2ViYXBwcy5XZWJBcGtVcGRhdGVNYW5hZ2VyVGVzdCN0ZXN0Q2Fub25pY2FsVXJsc0RpZmZlcmVudFNob3VsZFVwZ3JhZGUM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by jbudorick@chromium.org, Dec 12 2016 

Device(060f057b13c86640) 12-12 16:33:34.949 18830 18830 W System.err: java.lang.AssertionError
Device(060f057b13c86640) 12-12 16:33:34.949 18830 18830 W System.err:   at org.chromium.chrome.browser.metrics.UmaUtils.getForegroundStartTime(UmaUtils.java:96)
Device(060f057b13c86640) 12-12 16:33:34.949 18830 18830 W System.err:   at org.chromium.chrome.browser.tab.TabWebContentsObserver.didCommitProvisionalLoadForFrame(TabWebContentsObserver.java:211)
Device(060f057b13c86640) 12-12 16:33:34.949 18830 18830 W System.err:   at org.chromium.content.browser.webcontents.WebContentsObserverProxy.didCommitProvisionalLoadForFrame(WebContentsObserverProxy.java:186)
Device(060f057b13c86640) 12-12 16:33:34.959 18830 18830 W System.err:   at org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method)
Device(060f057b13c86640) 12-12 16:33:34.959 18830 18830 W System.err:   at org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:41)
Device(060f057b13c86640) 12-12 16:33:34.959 18830 18830 W System.err:   at android.os.Handler.dispatchMessage(Handler.java:102)
Device(060f057b13c86640) 12-12 16:33:34.959 18830 18830 W System.err:   at android.os.Looper.loop(Looper.java:136)
Device(060f057b13c86640) 12-12 16:33:34.959 18830 18830 W System.err:   at android.app.ActivityThread.main(ActivityThread.java:5001)
Device(060f057b13c86640) 12-12 16:33:34.959 18830 18830 W System.err:   at java.lang.reflect.Method.invokeNative(Native Method)
Device(060f057b13c86640) 12-12 16:33:34.959 18830 18830 W System.err:   at java.lang.reflect.Method.invoke(Method.java:515)
Device(060f057b13c86640) 12-12 16:33:34.959 18830 18830 W System.err:   at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
Device(060f057b13c86640) 12-12 16:33:34.959 18830 18830 W System.err:   at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
Device(060f057b13c86640) 12-12 16:33:34.959 18830 18830 W System.err:   at dalvik.system.NativeStart.main(Native Method)
Device(060f057b13c86640) 12-12 16:33:35.039 18830 18830 F chromium: [FATAL:jni_android.cc(243)] Please include Java exception stack in crash report

Comment 2 by jbudorick@chromium.org, Dec 12 2016

Cc: pkotw...@chromium.org
+cc pkotwicz: could this be related to https://codereview.chromium.org/2548333006 ?

Comment 3 by jbudorick@chromium.org, Dec 12 2016 

Also seeing this in 673098, so maybe it's not related to the CL in #2.

Comment 4 by pkotw...@chromium.org, Dec 12 2016 

I'll look at this issue today in the early afternoon after my meetings

Comment 5 by grunell@chromium.org, Dec 13 2016

Cc: -pkotw...@chromium.org
Components: Tests>Disabled
Labels: -Sheriff-Chromium
Owner: pkotw...@chromium.org
Status: Assigned (was: Untriaged)
Disabling in https://codereview.chromium.org/2571773002/
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44ff0871ca857e221a227306f7c256bf5e66659a

commit 44ff0871ca857e221a227306f7c256bf5e66659a
Author: grunell <grunell@chromium.org>
Date: Tue Dec 13 10:51:27 2016

Disable flaky test org.chromium.chrome.browser.webapps.WebApkUpdateManagerTest#testCanonicalUrlsDifferentShouldUpgrade.

TBR=miguelg@chromium.org

BUG= 673385 

Review-Url: https://codereview.chromium.org/2571773002
Cr-Commit-Position: refs/heads/master@{#438120}

[modify] https://crrev.com/44ff0871ca857e221a227306f7c256bf5e66659a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java

Comment 7 by jbudorick@chromium.org, Dec 13 2016 

As with 673098, this may have been related to issue 673433. Will look later today.

Comment 8 by jbudorick@chromium.org, Dec 14 2016

Cc: pkotw...@chromium.org
Owner: jbudorick@chromium.org
Definitely appears to have been caused by 673433. Reenabling.
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e61618cfebb5e68002c8fda26edca3f41b425206

commit e61618cfebb5e68002c8fda26edca3f41b425206
Author: jbudorick <jbudorick@chromium.org>
Date: Wed Dec 14 19:25:30 2016

Revert of Disable flaky test org.chromium.chrome.browser.webapps.WebApkUpdateManagerTest#testCanonicalUrlsDif… (patchset #1 id:1 of https://codereview.chromium.org/2571773002/ )

Reason for revert:
reenabling, see bug

Original issue's description:
> Disable flaky test org.chromium.chrome.browser.webapps.WebApkUpdateManagerTest#testCanonicalUrlsDifferentShouldUpgrade.
>
> TBR=miguelg@chromium.org
>
> BUG= 673385 
>
> Committed: https://crrev.com/44ff0871ca857e221a227306f7c256bf5e66659a
> Cr-Commit-Position: refs/heads/master@{#438120}

TBR=miguelg@chromium.org,grunell@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 673385 

Review-Url: https://codereview.chromium.org/2574583004
Cr-Commit-Position: refs/heads/master@{#438586}

[modify] https://crrev.com/e61618cfebb5e68002c8fda26edca3f41b425206/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java

Comment 10 by jbudorick@chromium.org, Dec 19 2016

Status: WontFix (was: Assigned)
Hasn't flaked since last Monday.

Comment 11 by dpranke@chromium.org, Jan 24 2018

Components: Tests>Disabled
Labels: Test-Disabled
►

Sign in to add a comment