New issue
Advanced search Search tips

Issue 673378 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

Try fixing a flake in Chromium to see if it's stats are updated

Project Member Reported by serg...@chromium.org, Dec 12 2016

Issue description

We should pick a flaky test as reported by Flakiness Surface, fix it and check if stats are updated correctly after ~1 week.

Example flaky test: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests%20(with%20patch)&tests=http%2Ftests%2Finspector%2Fnetwork%2Fnetwork-filters.html.

It's currently 65.88% flaky: http://test-results.appspot.com/flakiness/dir/http/tests/inspector/network.
 
Components: -Infra Infra>Flakiness
Blockedon: 654500
Yutaka marked the test as flaky, but the flakiness did not drop. I've analyzed various scenarios in which the test has failed and it's unclear to me how to test launcher behaves. In particular, according the the results of this query (https://plx.corp.google.com/script/#a=qo%7Ci=google%253A%253Ascript_85._13f7e1_eaa0_4837_b9d0_a1a80e9124ee):

1) It's not clear what the test is expected to be doing when it's not specified in the TestExpectations file. Most of the time test launcher was expecting it to PASS, but sometimes it expected it to be SLOW or be SKIPped.
2) After the test was added to the TestExpectations, it was expected to either PASS or FAIL, but was also sometimes expected to be SLOW or SKIPped in addition to PASS or FAIL.
3) The launcher stopped retry-ing the test after it was marked as expected to PASS or FAIL even though the test has produced TEXT or TIMEOUT.

I'll try to figure out what is the logic used by the test launcher, because it seems it's more complicated than I expected. Removing additional test result types for layout tests as tracked in 654500, would make this much simpler.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 10 2017

Looks like last commit did not fix the test.
Trying to fix another test: DesktopWindowTreeHostX11HighDPITest. LocatedEventDispatchWithCapture. It currently has 65.15% flakiness.

CL: http://crrev.com/2633473002
Status: Fixed (was: Started)
After hours of unsuccessful attempts to understand code under test, I gave up and decide to find some test that was reported as flaky by chromium-try-flakes, then fixed and follow it's flakiness as reported by Flakiness Surface.

I've discovered  issue 680770  and wrote an experimental query [1] to check whether Flakiness Surface has correctly reported increasing and then decreasing flakiness over specific days: before it was flaky, when it became flake and after it was fixed. The query confirmed the hypothesis and showed that stats shown on Flakiness Surface do reflect flakiness of tests correctly.

However, one lesson that I have learned as part of this is that some very flaky tests may not actually affect developer productivity since they are only flaky when run after some other tests (share global state) and thus always pass on second retry when the other test is not run. To address this, we need to report the actual false rejections in CQ, but this is already tracked in  issue 674084 , therefore I am closing this issue as Fixed.

[1]: https://plx.corp.google.com/script/#a=cp%7Ci=google%253A%253Aconfigs_monitoring_chrome_infra_plx_chrome_infra_flaky_tests_with_layout_team_dir_info%7Cn=Copy+of+chrome_infra.flaky_tests_with_layout_team_dir_info%7Cv=draft
Blockedon: -654500

Sign in to add a comment