New issue
Advanced search Search tips

Issue 673375 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DCHECK failure in sequenced_worker_pool.cc

Project Member Reported by zmin@chromium.org, Dec 12 2016

Issue description

Chrome Version: 57.0.2946.0 (Developer Build) (64-bit) refs/heads/master@{#437330}
OS: Windows 10

What steps will reproduce the problem?
(1) Build the browser test: 
    ninja -C out\chrome browser_tests
(2) Run the JS test for the UserManager:
    out\chrome\browser_tests.exe --gtest_filter="UserManagerBrowserTest.*"

What is the expected result?
Test is ran successfully

What happens instead?
DCHECK failure in sequenced_worker_pool.cc

[67636:75576:1212/121421.516:FATAL:sequenced_worker_pool.cc(1358)] Check failed: AllPoolsState::USE_WORKER_POOL == g_all_pools_state (1 vs. 0)
Backtrace:
        base::trace_event::StackFrame::FromThreadName [0x00007FFD8E423DB1+172225]
        base::trace_event::StackFrame::FromThreadName [0x00007FFD8E45666A+379258]
        base::trace_event::StackFrame::FromThreadName [0x00007FFD8E502EF0+1085952]
        base::trace_event::StackFrame::FromThreadName [0x00007FFD8E5069DC+1101036]
        base::trace_event::StackFrame::FromThreadName [0x00007FFD8E411208+95512]
        base::trace_event::StackFrame::FromThreadName [0x00007FFD8E4E6927+969783]
        ui::devtools::protocol::DOM::HighlightConfig::toValue [0x00007FF74F32BE2C+31706534]
        ui::devtools::protocol::DOM::HighlightConfig::toValue [0x00007FF74F9EB662+38782428]
        ui::devtools::protocol::DOM::HighlightConfig::toValue [0x00007FF74F9EBE57+38784465]
        ui::devtools::protocol::DOM::HighlightConfig::toValue [0x00007FF74F9EB327+38781601]
        ui::devtools::protocol::DOM::HighlightConfig::toValue [0x00007FF74F9EB87F+38782969]
        ui::devtools::protocol::DOM::HighlightConfig::toValue [0x00007FF74F32B9C3+31705405]
        ui::devtools::protocol::DOM::HighlightConfig::toValue [0x00007FF74F32B18A+31703300]
        ui::devtools::protocol::DOM::HighlightConfig::toValue [0x00007FF750AAF11F+56361113]
        ui::devtools::protocol::DOM::HighlightConfig::toValue [0x00007FF74F2F191A+31467668]
        ui::devtools::protocol::DOM::HighlightConfig::toValue [0x00007FF74F2EF13F+31457465]
        ui::devtools::protocol::DOM::HighlightConfig::toValue [0x00007FF74F2EE252+31453644]
        ui::devtools::protocol::DOM::HighlightConfig::toValue [0x00007FF74F168DC3+29859133]
        content::RenderThreadImpl::IsGpuMemoryBufferCompositorResourcesEnabled [0x00007FFD74771A36+7596385]
        content::RenderThreadImpl::IsGpuMemoryBufferCompositorResourcesEnabled [0x00007FFD74CF3CC7+13372402]
        content::RenderThreadImpl::IsGpuMemoryBufferCompositorResourcesEnabled [0x00007FFD7476E9C9+7583988]
        content::RenderThreadImpl::IsGpuMemoryBufferCompositorResourcesEnabled [0x00007FFD74773DFB+7605542]
        content::RenderThreadImpl::IsGpuMemoryBufferCompositorResourcesEnabled [0x00007FFD7476B152+7569533]
        content::RenderThreadImpl::IsGpuMemoryBufferCompositorResourcesEnabled [0x00007FFD752F05B3+19649758]
        content::RenderThreadImpl::IsGpuMemoryBufferCompositorResourcesEnabled [0x00007FFD752F03D9+19649284]
        content::RenderThreadImpl::IsGpuMemoryBufferCompositorResourcesEnabled [0x00007FFD752EF20C+19644727]
        ui::devtools::protocol::DOM::HighlightConfig::toValue [0x00007FF74F6439CE+34949448]
        ui::devtools::protocol::DOM::HighlightConfig::toValue [0x00007FF74ED1E907+25360513]
        ui::devtools::protocol::DOM::HighlightConfig::toValue [0x00007FF74F72D45D+35906519]
        ui::devtools::protocol::DOM::HighlightConfig::toValue [0x00007FF74F73E03A+35975092]
        ui::devtools::protocol::DOM::HighlightConfig::toValue [0x00007FF74F73E2C9+35975747]
        ui::devtools::protocol::DOM::HighlightConfig::toValue [0x00007FF74F73E16D+35975399]
        ui::devtools::protocol::DOM::HighlightConfig::toValue [0x00007FF74F73E6F6+35976816]
        ui::devtools::protocol::DOM::HighlightConfig::toValue [0x00007FF74F72D57D+35906807]
        ui::devtools::protocol::DOM::HighlightConfig::toValue [0x00007FF74F73E44F+35976137]
        ui::devtools::protocol::DOM::HighlightConfig::toValue [0x00007FF74ED2DE43+25423293]
        ui::devtools::protocol::DOM::HighlightConfig::toValue [0x00007FF75102F8C5+62130239]
        ui::devtools::protocol::DOM::HighlightConfig::toValue [0x00007FF74F633073+34881517]
        ui::devtools::protocol::DOM::HighlightConfig::toValue [0x00007FF75102F821+62130075]
        ui::devtools::protocol::DOM::HighlightConfig::toValue [0x00007FF75102F2B0+62128682]
        ui::devtools::protocol::DOM::HighlightConfig::toValue [0x00007FF75102D821+62121883]
        BaseThreadInitThunk [0x00007FFDB0798102+34]
        RtlUserThreadStart [0x00007FFDB0ADC5B4+52]

[1/1] UserManagerBrowserTest.UserManagerTest (1064 ms)
1 test failed:
    UserManagerBrowserTest.UserManagerTest


I have tried to remove this DCHECK then some other DCHECK in sequenced_worker_pool.cc failed. So I ends up with remove all DCHECK in the pool to make the browser test success.

Also, this is the code I have pulled last Thu but the all the trybots work fine at the same time.


 

Comment 1 by fdoray@chromium.org, Feb 14 2017

Cc: fdoray@chromium.org
 Issue 664071  has been merged into this issue.

Comment 2 by fdoray@chromium.org, Feb 14 2017

Call stack from merged bug:

[6472:3396:1110/110048:FATAL:sequenced_worker_pool.cc(1447)] Check failed: AllPoolsState::NONE_ACTIVE == subtle::NoBarrier_Load(&g_all_pools_state) (0 vs. 1)
Backtrace:
	base::debug::StackTrace::StackTrace [0x1007C287+23] (c:\src\chromium\src\base\debug\stack_trace_win.cc:214)
	logging::LogMessage::~LogMessage [0x100CDEDB+59] (c:\src\chromium\src\base\logging.cc:533)
	base::SequencedWorkerPool::RedirectToTaskSchedulerForProcess [0x1022F307+311] (c:\src\chromium\src\base\threading\sequenced_worker_pool.cc:1448)
	`anonymous namespace'::MaybeInitializeTaskScheduler [0x03FBAA88+520] (c:\src\chromium\src\chrome\browser\chrome_browser_main.cc:340)
	ChromeBrowserMainParts::PreCreateThreadsImpl [0x03FBCB25+4053] (c:\src\chromium\src\chrome\browser\chrome_browser_main.cc:1246)
	ChromeBrowserMainParts::PreCreateThreads [0x03FBB8A2+178] (c:\src\chromium\src\chrome\browser\chrome_browser_main.cc:955)
	ChromeBrowserMainPartsWin::PreCreateThreads [0x03C6E97B+27] (c:\src\chromium\src\chrome\browser\chrome_browser_main_win.cc:292)
	content::BrowserMainLoop::PreCreateThreads [0x116A9ADA+234] (c:\src\chromium\src\content\browser\browser_main_loop.cc:742)
	base::internal::FunctorTraits<int (__thiscall content::BrowserMainLoop::*)(void),void>::Invoke<content::BrowserMainLoop *> [0x1169F772+18] (c:\src\chromium\src\base\bind_internal.h:215)
	base::internal::InvokeHelper<0,int>::MakeItSo<int (__thiscall content::BrowserMainLoop::*const &)(void),content::BrowserMainLoop *> [0x1169FC14+36] (c:\src\chromium\src\base\bind_internal.h:285)
	base::internal::Invoker<base::internal::BindState<int (__thiscall content::BrowserMainLoop::*)(void),base::internal::UnretainedWrapper<content::BrowserMainLoop> >,int __cdecl(void)>::RunImpl<int (__thiscall content::BrowserMainLoop::*const &)(void),std::t [0x116A001B+59] (c:\src\chromium\src\base\bind_internal.h:361)
	base::internal::Invoker<base::internal::BindState<int (__thiscall content::BrowserMainLoop::*)(void),base::internal::UnretainedWrapper<content::BrowserMainLoop> >,int __cdecl(void)>::Run [0x116AA2F4+36] (c:\src\chromium\src\base\bind_internal.h:339)
	base::internal::RunMixin<base::Callback<int __cdecl(void),1,1> >::Run [0x11E1169F+63] (c:\src\chromium\src\base\callback.h:64)
	content::StartupTaskRunner::RunAllTasksNow [0x1234376E+110] (c:\src\chromium\src\content\browser\startup_task_runner.cc:45)
	content::BrowserMainLoop::CreateStartupTasks [0x116A6449+569] (c:\src\chromium\src\content\browser\browser_main_loop.cc:852)
	content::BrowserMainRunnerImpl::Initialize [0x116AFD3E+958] (c:\src\chromium\src\content\browser\browser_main_runner.cc:141)
	content::BrowserMain [0x1169C86F+95] (c:\src\chromium\src\content\browser\browser_main.cc:42)
	content::RunNamedProcessTypeMain [0x1300BB37+135] (c:\src\chromium\src\content\app\content_main_runner.cc:408)
	content::ContentMainRunnerImpl::Run [0x1300B9F8+488] (c:\src\chromium\src\content\app\content_main_runner.cc:776)
	content::ContentMain [0x13009914+100] (c:\src\chromium\src\content\app\content_main.cc:20)
	ChromeMain [0x02B572D8+264] (c:\src\chromium\src\chrome\app\chrome_main.cc:108)
	MainDllLoader::Launch [0x0042E476+918] (c:\src\chromium\src\chrome\app\main_dll_loader_win.cc:174)
	wWinMain [0x0042918E+558] (c:\src\chromium\src\chrome\app\chrome_exe_main_win.cc:249)
	invoke_main [0x004DBF3E+30] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:118)
	__scrt_common_main_seh [0x004DBDA0+336] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253)
	__scrt_common_main [0x004DBC3D+13] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:296)
	wWinMainCRTStartup [0x004DBF58+8] (f:\dd\vctools\crt\vcstartup\src\startup\exe_wwinmain.cpp:17)
	BaseThreadInitThunk [0x76A162C4+36]
	RtlSubscribeWnfStateChangeNotification [0x77670719+1081]
	RtlSubscribeWnfStateChangeNotification [0x776706E4+1028]

Comment 3 by fdoray@chromium.org, Feb 14 2017

Status: WontFix (was: Untriaged)
Failing DCHECKs were commented https://cs.chromium.org/chromium/src/base/threading/sequenced_worker_pool.cc?sq=package:chromium&dr=CSs&l=700.

We plan to migrate all SWP call sites to TaskScheduler and to queue tasks posted to TaskScheduler before it is started. Therefore, this specific issue won't be fixed.

Sign in to add a comment