New issue
Advanced search Search tips

Issue 673371 link

Starred by 2 users
Status: Fixed
Owner:
ma...@chromium.org
Closed: Dec 2016
Cc:
rouslan@chromium.org
ma...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 673282



Sign in to add a comment

browser.payments.PaymentRequest* timing out on waitForCallback

Project Member Reported by perezju@chromium.org, Dec 12 2016 
These tests have been flaking and failing on Android Tests (dbg) with the exception:

java.util.concurrent.TimeoutException: waitForCallback timed out!
	at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:183)
	at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:219)
	at org.chromium.chrome.browser.payments.PaymentRequestTestBase.clickInEditorAndWait(PaymentRequestTestBase.java:279)
	at org.chromium.chrome.browser.payments.PaymentRequestIncompletePhoneTest.testEditIncompletePhoneAndCancel(PaymentRequestIncompletePhoneTest.java:53)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:726)
	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FAndroid_Tests__dbg_%2F38061%2F%2B%2Frecipes%2Fsteps%2Fchrome_public_test_apk_on_Android%2F0%2Flogs%2Forg.chromium.chrome.browser.payments.PaymentRequestIncompletePhoneTest_testEditIncompletePhoneAndCancel%2F0

List of tests that have failed with this message in the latest 10 builds:

PaymentRequestIncompletePhoneTest_testEditIncompletePhoneAndCancel                        -F--F---F-
PaymentRequestPhoneTest_testAddInvalidPhoneAndCancel                                      -F--------
PaymentRequestContactDetailsTest_testAddInvalidContactAndCancel                           -F--------
PaymentRequestDynamicShippingSingleAddressTest_testQuickAddAddressAndCloseShouldNotCrash  ----F-----
PaymentRequestEmailTest_testAddInvalidEmailAndCancel                                      -----F--F-
PaymentRequestDynamicShippingSingleAddressTest_testQuickAddAddressAndCancelShouldNotCrash -----F----
PaymentRequestNameTest_testAddInvalidNameAndCancel                                        -----F----
PaymentRequestIncompleteContactDetailsTest_testEditIncompleteContactAndCancel             -----F----
PaymentRequestDynamicShippingSingleAddressTest_testAddInvalidAddressAndCancel             -------FF-
PaymentRequestIncompleteEmailTest_testEditIncompleteEmailAndCancel                        --------F-

+rouslan as owner of the payments Java code.

Comment 2 by rouslan@chromium.org, Dec 12 2016

Cc: ma...@chromium.org
Components: UI>Browser>Autofill>Payments
Status: Available (was: Untriaged)

Comment 3 by ma...@chromium.org, Dec 12 2016

Status: Started (was: Available)

Comment 4 by ma...@chromium.org, Dec 12 2016

Owner: ma...@chromium.org

Comment 5 by ma...@chromium.org, Dec 12 2016 

 Issue 673299  has been merged into this issue.

Comment 6 by ma...@chromium.org, Dec 12 2016 

 Issue 673136  has been merged into this issue.

Comment 7 by ma...@chromium.org, Dec 12 2016 

 Issue 673133  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/089ce14fd6cb33763968cb55adefdd3f6390c264

commit 089ce14fd6cb33763968cb55adefdd3f6390c264
Author: mathp <mathp@chromium.org>
Date: Tue Dec 13 16:04:07 2016

[Payment Request] Mark some tests as flaky, and attempt fixes

Since crrev.com/2561373002 was submitted, cancelling out of the editor
will now go back to the "ready to pay" state with an item still
selected (given there was one selected prior to entering the editor).

This made a bunch of tests flaky, so this change
- marks known flaky tests as FlakyTest
- Attempts to fix some tests with mReadyToPay, although this is just
  speculative at this point; a more comprehensive fix is in order.

BUG= 673371 
TEST=PaymentRequest* (java)

Review-Url: https://codereview.chromium.org/2571493002
Cr-Commit-Position: refs/heads/master@{#438182}

[modify] https://crrev.com/089ce14fd6cb33763968cb55adefdd3f6390c264/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java
[modify] https://crrev.com/089ce14fd6cb33763968cb55adefdd3f6390c264/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingSingleAddressTest.java
[modify] https://crrev.com/089ce14fd6cb33763968cb55adefdd3f6390c264/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailTest.java
[modify] https://crrev.com/089ce14fd6cb33763968cb55adefdd3f6390c264/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java
[modify] https://crrev.com/089ce14fd6cb33763968cb55adefdd3f6390c264/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsTest.java
[modify] https://crrev.com/089ce14fd6cb33763968cb55adefdd3f6390c264/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteEmailTest.java
[modify] https://crrev.com/089ce14fd6cb33763968cb55adefdd3f6390c264/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompletePhoneTest.java
[modify] https://crrev.com/089ce14fd6cb33763968cb55adefdd3f6390c264/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNameTest.java
[modify] https://crrev.com/089ce14fd6cb33763968cb55adefdd3f6390c264/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java
[modify] https://crrev.com/089ce14fd6cb33763968cb55adefdd3f6390c264/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppAndCardsTest.java
[modify] https://crrev.com/089ce14fd6cb33763968cb55adefdd3f6390c264/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneTest.java
[modify] https://crrev.com/089ce14fd6cb33763968cb55adefdd3f6390c264/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShippingAddressTest.java
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8824e3d6fcef98df0702cf0c0dd6c3845d067ff6

commit 8824e3d6fcef98df0702cf0c0dd6c3845d067ff6
Author: mathp <mathp@chromium.org>
Date: Fri Dec 16 05:41:41 2016

[Payment Request] Update the logic when obtaining results from editors

There were bugs in the handling of the result coming back from an editor. We now have improved logic around:
* Receiving |null| from the editor (cancelling out of an Add flow)
* Receiving an incomplete result (cancelling out of an Edit for an incomplete item)
* Receiving a complete item.

Also updated the tests and added a few new ones.

BUG= 673371 
TEST=PaymentRequest* (java)

Review-Url: https://codereview.chromium.org/2571513004
Cr-Commit-Position: refs/heads/master@{#439038}

[modify] https://crrev.com/8824e3d6fcef98df0702cf0c0dd6c3845d067ff6/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillContact.java
[modify] https://crrev.com/8824e3d6fcef98df0702cf0c0dd6c3845d067ff6/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/8824e3d6fcef98df0702cf0c0dd6c3845d067ff6/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
[modify] https://crrev.com/8824e3d6fcef98df0702cf0c0dd6c3845d067ff6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java
[modify] https://crrev.com/8824e3d6fcef98df0702cf0c0dd6c3845d067ff6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingSingleAddressTest.java
[modify] https://crrev.com/8824e3d6fcef98df0702cf0c0dd6c3845d067ff6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailTest.java
[modify] https://crrev.com/8824e3d6fcef98df0702cf0c0dd6c3845d067ff6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteContactDetailsTest.java
[modify] https://crrev.com/8824e3d6fcef98df0702cf0c0dd6c3845d067ff6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompleteEmailTest.java
[modify] https://crrev.com/8824e3d6fcef98df0702cf0c0dd6c3845d067ff6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestIncompletePhoneTest.java
[modify] https://crrev.com/8824e3d6fcef98df0702cf0c0dd6c3845d067ff6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMultipleContactDetailsTest.java
[modify] https://crrev.com/8824e3d6fcef98df0702cf0c0dd6c3845d067ff6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNameTest.java
[modify] https://crrev.com/8824e3d6fcef98df0702cf0c0dd6c3845d067ff6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java
[modify] https://crrev.com/8824e3d6fcef98df0702cf0c0dd6c3845d067ff6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneTest.java
[modify] https://crrev.com/8824e3d6fcef98df0702cf0c0dd6c3845d067ff6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
[modify] https://crrev.com/8824e3d6fcef98df0702cf0c0dd6c3845d067ff6/chrome/android/junit/src/org/chromium/chrome/browser/payments/AutofillContactTest.java
[modify] https://crrev.com/8824e3d6fcef98df0702cf0c0dd6c3845d067ff6/chrome/test/data/android/payments/contact_details.js
[modify] https://crrev.com/8824e3d6fcef98df0702cf0c0dd6c3845d067ff6/chrome/test/data/android/payments/email.js
[modify] https://crrev.com/8824e3d6fcef98df0702cf0c0dd6c3845d067ff6/chrome/test/data/android/payments/phone.js

Comment 10 by ma...@chromium.org, Dec 16 2016

Status: Fixed (was: Started)

Comment 11 by lafo...@chromium.org, Jun 27 2017

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
►

Sign in to add a comment