This is a catch-all tracking bug for work related to Cocoa browser RTL.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0390c3aa26a58e473d0b18c3a8df6a28ccbe68ff commit 0390c3aa26a58e473d0b18c3a8df6a28ccbe68ff Author: lgrey <lgrey@chromium.org> Date: Tue Dec 13 16:18:32 2016 Add ScopedForceRTLMac class for Cocoa browser RTL testing BUG= 673362 Review-Url: https://codereview.chromium.org/2555033003 Cr-Commit-Position: refs/heads/master@{#438185} [modify] https://crrev.com/0390c3aa26a58e473d0b18c3a8df6a28ccbe68ff/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/0390c3aa26a58e473d0b18c3a8df6a28ccbe68ff/chrome/browser/ui/cocoa/tabs/tab_controller_unittest.mm [add] https://crrev.com/0390c3aa26a58e473d0b18c3a8df6a28ccbe68ff/chrome/browser/ui/cocoa/test/scoped_force_rtl_mac.h [add] https://crrev.com/0390c3aa26a58e473d0b18c3a8df6a28ccbe68ff/chrome/browser/ui/cocoa/test/scoped_force_rtl_mac.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f56da4755ccc370cd682cce472d4ba1c0781207 commit 4f56da4755ccc370cd682cce472d4ba1c0781207 Author: lgrey <lgrey@chromium.org> Date: Wed Dec 14 16:38:58 2016 There's a bunch of weird glitches right now that cause the text to flip to the left. AFAICT, these two changes fix all of them: 1) Set the alignment of the text field directly. 2) RFC 3987 requires us to set the writing direction of URLs to LTR so that we get שלום.com instead of moc.שלום. This appears to change the alignment of the string if it's not set explicitly. So: set it explicitly. BUG= 648554 , 673362 Review-Url: https://codereview.chromium.org/2555783002 Cr-Commit-Position: refs/heads/master@{#438529} [modify] https://crrev.com/4f56da4755ccc370cd682cce472d4ba1c0781207/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm [modify] https://crrev.com/4f56da4755ccc370cd682cce472d4ba1c0781207/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h [modify] https://crrev.com/4f56da4755ccc370cd682cce472d4ba1c0781207/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm [modify] https://crrev.com/4f56da4755ccc370cd682cce472d4ba1c0781207/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e35b7bb1d2f0ea5bce687a07872277b495428d3 commit 1e35b7bb1d2f0ea5bce687a07872277b495428d3 Author: lgrey <lgrey@chromium.org> Date: Fri Dec 16 20:56:57 2016 [Mac] Reverse back/forward toolbar buttons in RTL BUG= 647206 , 673362 Review-Url: https://codereview.chromium.org/2582593003 Cr-Commit-Position: refs/heads/master@{#439186} [modify] https://crrev.com/1e35b7bb1d2f0ea5bce687a07872277b495428d3/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/753efdea7319cbdca59df1e1d7b458c4eaa3c479 commit 753efdea7319cbdca59df1e1d7b458c4eaa3c479 Author: lgrey <lgrey@chromium.org> Date: Wed Dec 28 20:59:20 2016 [Mac] Reverse the omnibox in RTL BUG= 648554 , 648557 , 673362 Review-Url: https://codereview.chromium.org/2576563002 Cr-Commit-Position: refs/heads/master@{#440891} [modify] https://crrev.com/753efdea7319cbdca59df1e1d7b458c4eaa3c479/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.h [modify] https://crrev.com/753efdea7319cbdca59df1e1d7b458c4eaa3c479/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm [modify] https://crrev.com/753efdea7319cbdca59df1e1d7b458c4eaa3c479/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm [modify] https://crrev.com/753efdea7319cbdca59df1e1d7b458c4eaa3c479/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm [modify] https://crrev.com/753efdea7319cbdca59df1e1d7b458c4eaa3c479/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm [modify] https://crrev.com/753efdea7319cbdca59df1e1d7b458c4eaa3c479/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b0fd02afc2107ba123774e0a464a43407a108cf commit 8b0fd02afc2107ba123774e0a464a43407a108cf Author: lgrey <lgrey@chromium.org> Date: Fri Jan 06 12:24:01 2017 [Mac] Flip toolbar in RTL Browser actions will be reordered in a future change. BUG= 648558 , 648563 , 673362 Review-Url: https://codereview.chromium.org/2607533004 Cr-Commit-Position: refs/heads/master@{#441925} [modify] https://crrev.com/8b0fd02afc2107ba123774e0a464a43407a108cf/chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm [modify] https://crrev.com/8b0fd02afc2107ba123774e0a464a43407a108cf/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm [modify] https://crrev.com/8b0fd02afc2107ba123774e0a464a43407a108cf/chrome/browser/ui/cocoa/toolbar/toolbar_controller.h [modify] https://crrev.com/8b0fd02afc2107ba123774e0a464a43407a108cf/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm [modify] https://crrev.com/8b0fd02afc2107ba123774e0a464a43407a108cf/chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0eda8fc58bd6357bb5a18e4d977b98de988857a commit d0eda8fc58bd6357bb5a18e4d977b98de988857a Author: lgrey <lgrey@chromium.org> Date: Mon Jan 09 16:10:28 2017 Revert of [Mac] Flip toolbar in RTL (patchset #5 id:80001 of https://codereview.chromium.org/2607533004/ ) Reason for revert: Caused crbug.com/679249 Original issue's description: > [Mac] Flip toolbar in RTL > > Browser actions will be reordered in a future change. > > BUG= 648558 , 648563 , 673362 > > Review-Url: https://codereview.chromium.org/2607533004 > Cr-Commit-Position: refs/heads/master@{#441925} > Committed: https://chromium.googlesource.com/chromium/src/+/8b0fd02afc2107ba123774e0a464a43407a108cf TBR=tapted@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 648558 , 648563 , 673362 Review-Url: https://codereview.chromium.org/2622613002 Cr-Commit-Position: refs/heads/master@{#442257} [modify] https://crrev.com/d0eda8fc58bd6357bb5a18e4d977b98de988857a/chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm [modify] https://crrev.com/d0eda8fc58bd6357bb5a18e4d977b98de988857a/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm [modify] https://crrev.com/d0eda8fc58bd6357bb5a18e4d977b98de988857a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.h [modify] https://crrev.com/d0eda8fc58bd6357bb5a18e4d977b98de988857a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm [modify] https://crrev.com/d0eda8fc58bd6357bb5a18e4d977b98de988857a/chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/882ccc67f27351913c6ae4384c1a79441e1becea commit 882ccc67f27351913c6ae4384c1a79441e1becea Author: lgrey <lgrey@chromium.org> Date: Thu Jan 12 20:32:21 2017 [Mac] Flip toolbar in RTL (reland) This was reverted due to crbug.com/679174 which is fixed by using the browser action container view's |animationEndFrame| instead of its frame when calculating the size of the location bar. Browser actions will be reordered in a future change. BUG= 648558 , 648563 , 673362 Review-Url: https://codereview.chromium.org/2607533004 Cr-Commit-Position: refs/heads/master@{#441925} Committed: https://chromium.googlesource.com/chromium/src/+/8b0fd02afc2107ba123774e0a464a43407a108cf patch from issue 2607533004 at patchset 80001 (http://crrev.com/2607533004#ps80001) Review-Url: https://codereview.chromium.org/2631463004 Cr-Commit-Position: refs/heads/master@{#443345} [modify] https://crrev.com/882ccc67f27351913c6ae4384c1a79441e1becea/chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm [modify] https://crrev.com/882ccc67f27351913c6ae4384c1a79441e1becea/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm [modify] https://crrev.com/882ccc67f27351913c6ae4384c1a79441e1becea/chrome/browser/ui/cocoa/toolbar/toolbar_controller.h [modify] https://crrev.com/882ccc67f27351913c6ae4384c1a79441e1becea/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm [modify] https://crrev.com/882ccc67f27351913c6ae4384c1a79441e1becea/chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/591540b12bcfe11d368bf9341c7f160ead3e36dd commit 591540b12bcfe11d368bf9341c7f160ead3e36dd Author: lgrey <lgrey@chromium.org> Date: Wed May 10 15:52:07 2017 Rename and move ExperimentalMacRTL flag In anticipation of adding it to chrome://flags BUG= 673362 Review-Url: https://codereview.chromium.org/2873763003 Cr-Commit-Position: refs/heads/master@{#470586} [modify] https://crrev.com/591540b12bcfe11d368bf9341c7f160ead3e36dd/chrome/browser/ui/cocoa/l10n_util.h [modify] https://crrev.com/591540b12bcfe11d368bf9341c7f160ead3e36dd/chrome/browser/ui/cocoa/l10n_util.mm [modify] https://crrev.com/591540b12bcfe11d368bf9341c7f160ead3e36dd/chrome/browser/ui/cocoa/test/scoped_force_rtl_mac.mm [modify] https://crrev.com/591540b12bcfe11d368bf9341c7f160ead3e36dd/chrome/common/chrome_features.cc [modify] https://crrev.com/591540b12bcfe11d368bf9341c7f160ead3e36dd/chrome/common/chrome_features.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0b638e52812ff1e84b14919a608408d7bb98933 commit c0b638e52812ff1e84b14919a608408d7bb98933 Author: lgrey <lgrey@chromium.org> Date: Thu May 11 19:10:17 2017 Add MacRTL feature to flags BUG= 673362 Review-Url: https://codereview.chromium.org/2878563002 Cr-Commit-Position: refs/heads/master@{#471031} [modify] https://crrev.com/c0b638e52812ff1e84b14919a608408d7bb98933/chrome/browser/about_flags.cc [modify] https://crrev.com/c0b638e52812ff1e84b14919a608408d7bb98933/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/c0b638e52812ff1e84b14919a608408d7bb98933/chrome/browser/flag_descriptions.h [modify] https://crrev.com/c0b638e52812ff1e84b14919a608408d7bb98933/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c13382bd9685a3f8e0a3577a4ba6c0beb3e5ee77 commit c13382bd9685a3f8e0a3577a4ba6c0beb3e5ee77 Author: Leonard Grey <lgrey@chromium.org> Date: Wed Apr 25 15:15:26 2018 [MacRTL] Enable by default Bug: 673362 Change-Id: Id318b8c8b7e6c3def6f38c51961032b3f3270a65 Reviewed-on: https://chromium-review.googlesource.com/1026476 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#553554} [modify] https://crrev.com/c13382bd9685a3f8e0a3577a4ba6c0beb3e5ee77/chrome/common/chrome_features.cc
*** UI Mass Triage*** Seems like WIP and bug is valid, hence tagging with appropriate label.
This is both fixed and obsolete :p
Comment 1 by bugdroid1@chromium.org
, Dec 13 2016