New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 673358 link

Starred by 1 user
Status: Fixed
Owner:
█ moshayedi@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Cc:
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 672587



Sign in to add a comment

IME for Mus: Revisit "session_ids" in IMEDriver::StartSession()/CancelSession().

Project Member Reported by moshayedi@chromium.org, Dec 12 2016 
Each ui::mojom::IMEDriver session corresponds to lifetime of a ui::mojom::InputMethod, so we can move ui::mojom::IMEDriver::CancelSession() to ui::mojom::InputMethod and get rid of session_ids.

We might also want to rename InputMethod to InputMethodSession or similar to make this more clear.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ab7311328652527bb7d8b1b5e64eb1bf0c05872

commit 3ab7311328652527bb7d8b1b5e64eb1bf0c05872
Author: moshayedi <moshayedi@chromium.org>
Date: Wed Jun 21 21:40:41 2017

Unify IMEDriver and IMEServer.

Each ui.mojom.InputMethod corresponds to one session. We don't need session_ids
to identify them.

Also removing the IMEDriver::CancelSession(). We can add it to
ui.mojom.InputMethod later if needed.

After these changes IMEDriver and IMEServer have the same interface, so unifying
them.

BUG= 673358 

Review-Url: https://codereview.chromium.org/2945283002
Cr-Commit-Position: refs/heads/master@{#481312}

[modify] https://crrev.com/3ab7311328652527bb7d8b1b5e64eb1bf0c05872/chrome/browser/ui/views/ime_driver/ime_driver_mus.cc
[modify] https://crrev.com/3ab7311328652527bb7d8b1b5e64eb1bf0c05872/chrome/browser/ui/views/ime_driver/ime_driver_mus.h
[modify] https://crrev.com/3ab7311328652527bb7d8b1b5e64eb1bf0c05872/services/ui/ime/BUILD.gn
[rename] https://crrev.com/3ab7311328652527bb7d8b1b5e64eb1bf0c05872/services/ui/ime/ime_driver_bridge.cc
[add] https://crrev.com/3ab7311328652527bb7d8b1b5e64eb1bf0c05872/services/ui/ime/ime_driver_bridge.h
[modify] https://crrev.com/3ab7311328652527bb7d8b1b5e64eb1bf0c05872/services/ui/ime/ime_registrar_impl.cc
[modify] https://crrev.com/3ab7311328652527bb7d8b1b5e64eb1bf0c05872/services/ui/ime/ime_registrar_impl.h
[delete] https://crrev.com/2acd66ad843d8602e4f761f5be87f921df640482/services/ui/ime/ime_server_impl.h
[modify] https://crrev.com/3ab7311328652527bb7d8b1b5e64eb1bf0c05872/services/ui/ime/ime_unittest.cc
[modify] https://crrev.com/3ab7311328652527bb7d8b1b5e64eb1bf0c05872/services/ui/ime/test_ime_driver/test_ime_driver.cc
[modify] https://crrev.com/3ab7311328652527bb7d8b1b5e64eb1bf0c05872/services/ui/ime/test_ime_driver/test_ime_driver.h
[modify] https://crrev.com/3ab7311328652527bb7d8b1b5e64eb1bf0c05872/services/ui/manifest.json
[modify] https://crrev.com/3ab7311328652527bb7d8b1b5e64eb1bf0c05872/services/ui/public/interfaces/ime/ime.mojom
[modify] https://crrev.com/3ab7311328652527bb7d8b1b5e64eb1bf0c05872/services/ui/service.cc
[modify] https://crrev.com/3ab7311328652527bb7d8b1b5e64eb1bf0c05872/services/ui/service.h
[modify] https://crrev.com/3ab7311328652527bb7d8b1b5e64eb1bf0c05872/ui/aura/mus/input_method_mus.cc
[modify] https://crrev.com/3ab7311328652527bb7d8b1b5e64eb1bf0c05872/ui/aura/mus/input_method_mus.h
[modify] https://crrev.com/3ab7311328652527bb7d8b1b5e64eb1bf0c05872/ui/aura/test/mus/input_method_mus_test_api.h

Comment 2 by moshayedi@chromium.org, Jun 22 2017

Status: Fixed (was: Assigned)

Comment 3 by lafo...@chromium.org, Feb 26 2018

Components: -Internals>MUS Internals>Services>WindowService

Comment 4 by lafo...@chromium.org, Feb 26 2018

Components: -MUS
►

Sign in to add a comment