New issue
Advanced search Search tips

Issue 673352 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Flakiness Dashboard fails for a number of reasons

Project Member Reported by serg...@chromium.org, Dec 12 2016

Issue description

Here are some strings that I had to filter out to check that new version does not produce any new errors:

- "builder name conflict"
- "build number conflict"
  - these 2 can probable be made a warning

- "into Go value of type int64"
 - this was client-side error, we should return 400 for these and make them a warning

- "Call error 11: Deadline exceeded"
- "Exceeded soft private memory limit"
- "context deadline exceeded"
- "PubSub publish error"
- "memcache: server error"
- "Request was aborted after waiting too long to attempt to service your request."
- "API error 9 (memcache: )"
- "API error 5 (datastore_v3: TIMEOUT): Timed out contacting datastore."
- not sure what to do with these: some of them seem to be unavoidable, so probably fine to keep them
 

Comment 1 by estaab@chromium.org, Dec 13 2016

Labels: -Pri-3 Pri-2
Status: Available (was: Untriaged)
Great audit, thanks for filing this.
CL: https://chromium-review.googlesource.com/c/418719/

This should address "builder name conflict", "build number conflict" and "into Go value of type int64".
Owner: serg...@chromium.org
Status: Assigned (was: Available)
I've also reviewed the remaining error messages and I don't think we can do much about them - they are AppEngine errors, so I'll mark this bug as Fixed after my CL lands and is deployed.
Sorry, CL in #1 was an existing CL from a different bug and I have uploaded changes as a new patchset to it rather than creating a new CL. Reuploaded as https://chromium-review.googlesource.com/c/418818/.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/ab8c335cd1629e6d97d8b5785b7b32298c20a83e

commit ab8c335cd1629e6d97d8b5785b7b32298c20a83e
Author: Sergiy Byelozyorov <sergiyb@chromium.org>
Date: Tue Dec 13 09:29:12 2016

Report error 400 for client-side errors and log a warning

BUG= 673352 

Change-Id: If7d3d5d4856d0fcc9d8b8db3135ca604538d63e1
Reviewed-on: https://chromium-review.googlesource.com/418818
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/ab8c335cd1629e6d97d8b5785b7b32298c20a83e/go/src/infra/appengine/test-results/frontend/upload.go

Status: Fixed (was: Assigned)
Status: Started (was: Fixed)
Actually there are still errors for "builder name conflict" and "build number conflict". CL: http://crosreview.com/418798
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/ffa0f2e059e2b332510a34b3366537dad95668ae

commit ffa0f2e059e2b332510a34b3366537dad95668ae
Author: Sergiy Byelozyorov <sergiyb@chromium.org>
Date: Tue Dec 13 11:14:23 2016

Log a warning for client errors

BUG= 673352 

Change-Id: I5a97f9834c4e661048e1d05b33638254e1e6eeee
Reviewed-on: https://chromium-review.googlesource.com/418798
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>

[modify] https://crrev.com/ffa0f2e059e2b332510a34b3366537dad95668ae/go/src/infra/appengine/test-results/frontend/upload.go

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/4ef40b05191ed42596f23c8b3eb90c62c23911b2

commit 4ef40b05191ed42596f23c8b3eb90c62c23911b2
Author: Sergiy Byelozyorov <sergiyb@chromium.org>
Date: Tue Dec 13 15:52:08 2016

More conversions from error to warning on client errors

BUG= 673352 

Change-Id: I561e8a6f1487da911334055229d0c2d5afd90a9e
Reviewed-on: https://chromium-review.googlesource.com/419495
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/4ef40b05191ed42596f23c8b3eb90c62c23911b2/go/src/infra/appengine/test-results/frontend/upload.go

Status: Fixed (was: Started)

Sign in to add a comment