New issue
Advanced search Search tips

Issue 673310 link

Starred by 3 users

Issue metadata

Status: Duplicate
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Detaching from the debugger API crashes chromium if launched with --disable-infobars

Reported by lanzk...@gmail.com, Dec 12 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36

Steps to reproduce the problem:
1. Install an extension that connects to the debugger API (e.g. https://github.com/lanzkron/DebuggerAPI)
2. Launch chromium with --disable-infobars
3. Attach to the debugger API (with the linked extension this is with Alt-Shift-D)
4. Detach from the debugger API (with the linked extension this is with Alt-Shift-D again)

What is the expected behavior?
Detaching should succeed

What went wrong?
Chromium crashes

Did this work before? N/A 

Chrome version: 55.0.2883.87  Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 23.0 r0
 

Comment 1 by ajha@chromium.org, Dec 12 2016

Labels: M-55
Components: -Platform>DevTools Platform>DevTools>JavaScript
Owner: kozyatinskiy@chromium.org
Status: Assigned (was: Unconfirmed)
kozyatinskiy@ any idea on why --disable-infobars would affect debugging?

Comment 3 by lanzk...@gmail.com, Dec 13 2016

I forgot to mention another flow, repeat steps 1-4 and then open developer tools => Chromium crashes. 

I suppose this is the same thing (opening dev-tools causes the debugger to be detached) but any fix should verify this flow too.

Regarding the cause, I had a look at the code and I see that AddInfoBar returns nullptr when the info bars are disabled. Perhaps there's a missing check and nullptr is dereferenced (just a guess, I didn't follow the flow the whole way through).
Owner: kozy@chromium.org

Comment 5 by kozy@chromium.org, Oct 16 2017

Mergedinto: 717933
Status: Duplicate (was: Assigned)
This one fixed at least in latest Canary and Dev.

Sign in to add a comment