New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 673309 link

Starred by 1 user
Status: Fixed
Owner:
sullivan@chromium.org
Closed: Dec 2016
Cc:
█ nednguyen@chromium.org
█ eakuefner@chromium.org
u...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

v8.browsing_desktop{_ignition} should alert per-page.

Project Member Reported by u...@chromium.org, Dec 12 2016 
Looks like v8.browsing_desktop{_ignition} is alerting on aggregated results.

Here is an example of regression of the aggregate result
ChromiumPerf/linux-release/v8.browsing_desktop_ignition / v8-gc-full-mark-compactor_count / browse_media

https://chromeperf.appspot.com/report?sid=1e689c4dcbac0e4d92aa4a5086221d83dbc9b731ed45dd9d1c31fdec6b0d30e1&rev=436028

But there is no regression on individual pages, only pinterest stopped doing GCs which lead to increased total average.

Related fixed bug for mobile: https://bugs.chromium.org/p/chromium/issues/detail?id=664948

Comment 1 by u...@chromium.org, Dec 12 2016

Cc: nednguyen@chromium.org
Actually my explanation about pinterest was incorrect, it seems to have full GCs.

Annie, Ned, any ideas why the aggregate browse_media regresses between 435959 and 436330 but none of the stories regress? Is it a bug in reporting?

https://chromeperf.appspot.com/report?sid=300d99085649f455b5fcbc2474872f2a2b4c0b388a4e60ac3f0851f66090a9b8&rev=436028

Comment 2 by nedngu...@google.com, Dec 12 2016

Cc: eakuefner@chromium.org

Comment 3 by u...@chromium.org, Dec 12 2016 

I confused myself: pinterest does not have full GCs in the regression range. So my first explanation was correct.

It is easy to see in this graph:

https://chromeperf.appspot.com/report?sid=1da64d44e062145ee2beb1256f549dd015769100c5ac2d8b65405c5c3bdab6e8&rev=436028

Comment 4 by sullivan@chromium.org, Dec 12 2016 

There is still a problem here: It appears only the {_ignition} versions of v8.browsing_{desktop|mobile} are monitored. Which sheriffing rotation should the non-ignition ones be monitored by? (The ignition ones do monitor individual stories.

Comment 5 by u...@chromium.org, Dec 12 2016 

All v8.browsing should be in v8 memory sheriff rotation.

There are alerts for v8.browsing_desktop (non-ignition):
https://chromeperf.appspot.com/report?sid=a8ab6eacbb5743221770bcaa89d9a55d6dabf1f67de5c74061379bcc2f2697f9&rev=436038

They seems to be on the summary level.

Comment 6 by sullivan@chromium.org, Dec 12 2016 

Oh, I see! I was confused because there are two levels of summary, the overall average and the average for browse_media, etc. I only checked the latter. I will clean up the alerts.

Comment 7 by u...@chromium.org, Dec 12 2016 

Thank you :)

Comment 8 by sullivan@chromium.org, Dec 12 2016

Status: Fixed (was: Assigned)
Monitoring updated.
►

Sign in to add a comment