New issue
Advanced search Search tips

Issue 673300 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Dec 2016
Cc:
torne@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.content.browser.JavaBridgeChildFrameTest#testRemovingTransientObjectHolders" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Dec 12 2016 
"org.chromium.content.browser.JavaBridgeChildFrameTest#testRemovingTransientObjectHolders" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyYwsSBUZsYWtlIlhvcmcuY2hyb21pdW0uY29udGVudC5icm93c2VyLkphdmFCcmlkZ2VDaGlsZEZyYW1lVGVzdCN0ZXN0UmVtb3ZpbmdUcmFuc2llbnRPYmplY3RIb2xkZXJzDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by vasi...@chromium.org, Dec 12 2016 

I  145.631s run_tests_on_device(076022db0069b8e1)    Error in testRemovingTransientObjectHolders:
I  145.631s run_tests_on_device(076022db0069b8e1)    java.util.concurrent.TimeoutException
I  145.631s run_tests_on_device(076022db0069b8e1)    	at org.chromium.content.browser.JavaBridgeChildFrameTest$1Test.waitForInjection(JavaBridgeChildFrameTest.java:134)
I  145.631s run_tests_on_device(076022db0069b8e1)    	at org.chromium.content.browser.JavaBridgeChildFrameTest.testRemovingTransientObjectHolders(JavaBridgeChildFrameTest.java:154)
I  145.631s run_tests_on_device(076022db0069b8e1)    	at java.lang.reflect.Method.invokeNative(Native Method)
I  145.632s run_tests_on_device(076022db0069b8e1)    	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
I  145.632s run_tests_on_device(076022db0069b8e1)    	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
I  145.632s run_tests_on_device(076022db0069b8e1)    	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
I  145.632s run_tests_on_device(076022db0069b8e1)    	at org.chromium.content_shell_apk.ContentShellTestBase.runTest(ContentShellTestBase.java:256)
I  145.632s run_tests_on_device(076022db0069b8e1)    	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
I  145.632s run_tests_on_device(076022db0069b8e1)    	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
I  145.632s run_tests_on_device(076022db0069b8e1)    	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
I  145.632s run_tests_on_device(076022db0069b8e1)    	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
I  145.632s run_tests_on_device(076022db0069b8e1)    	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
I  145.632s run_tests_on_device(076022db0069b8e1)    	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

Comment 2 by grunell@chromium.org, Dec 13 2016

Cc: mnaga...@chromium.org
Components: Tests>Disabled
Labels: -Sheriff-Chromium OS-Android
Owner: torne@chromium.org
Status: Assigned (was: Untriaged)
Disabling in https://codereview.chromium.org/2576433002/

torne@: can you please find a suitable owner?
mnaganov@: are you still working on Chromium?

Comment 3 by jbudorick@chromium.org, Dec 13 2016 

This may have been related to issue 673433. Will look later today.

Comment 4 by torne@chromium.org, Dec 13 2016

Cc: -mnaga...@chromium.org torne@chromium.org
Components: Mobile>WebView
Owner: ----
Status: Available (was: Assigned)
No, mikhail no longer works on chromium. Adding webview label so it gets triaged by our bug cop.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d6006b896c5e307ff3fb0a49b343fbadfe788f3

commit 5d6006b896c5e307ff3fb0a49b343fbadfe788f3
Author: grunell <grunell@chromium.org>
Date: Tue Dec 13 18:15:05 2016

Disable flaky test org.chromium.content.browser.JavaBridgeChildFrameTest#testRemovingTransientObjectHolders.

TBR=torne@chromium.org

BUG= 673300 

Review-Url: https://codereview.chromium.org/2576433002
Cr-Commit-Position: refs/heads/master@{#438225}

[modify] https://crrev.com/5d6006b896c5e307ff3fb0a49b343fbadfe788f3/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeChildFrameTest.java

Comment 6 by jbudorick@chromium.org, Dec 14 2016 

Given that this didn't flake at all in the > 1 day between the last reported flake and the disabling -- i.e., the period during which 673433 was fixed -- I'm inclined to reenable this.

Comment 7 by boliu@chromium.org, Dec 22 2016 

50 iterations passed locally for me, gonna enable
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9199b2b8a8520dcb0625e46d95cf02221bba69b9

commit 9199b2b8a8520dcb0625e46d95cf02221bba69b9
Author: boliu <boliu@chromium.org>
Date: Thu Dec 22 22:17:29 2016

Enable testRemovingTransientObjectHolders

Theory is test was disabled due to infra problems, not test itself. See
bug for more details.

BUG= 673300 
TBR=jbudorick

Review-Url: https://codereview.chromium.org/2600453004
Cr-Commit-Position: refs/heads/master@{#440520}

[modify] https://crrev.com/9199b2b8a8520dcb0625e46d95cf02221bba69b9/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeChildFrameTest.java

Comment 9 by boliu@chromium.org, Dec 22 2016

Status: Fixed (was: Available)

Comment 10 by dpranke@chromium.org, Jan 24 2018

Components: Tests>Disabled
Labels: Test-Disabled
►

Sign in to add a comment