New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 673294 link

Starred by 1 user
Status: Fixed
Owner:
tedc...@chromium.org
Closed: Dec 2016
Cc:
█ mariakho...@chromium.org
█ dskiba@chromium.org
asvitk...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 673282



Sign in to add a comment

hardware_acceleration.ToastHWATest#testOpenedInBackgroundToast failing on Lollipop Tablet

Project Member Reported by perezju@chromium.org, Dec 12 2016 
This is a pretty consistent failure since build
https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/6109

Example error message:

junit.framework.AssertionFailedError: '2131690247' is not visible
	at org.chromium.chrome.test.util.browser.contextmenu.ContextMenuUtils.selectOpenContextMenuItem(ContextMenuUtils.java:154)
	at org.chromium.chrome.test.util.browser.contextmenu.ContextMenuUtils.selectContextMenuItemByJs(ContextMenuUtils.java:118)
	at org.chromium.chrome.test.util.browser.contextmenu.ContextMenuUtils.selectContextMenuItem(ContextMenuUtils.java:99)
	at org.chromium.chrome.browser.hardware_acceleration.ToastHWATest.testOpenedInBackgroundToast(ToastHWATest.java:103)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:726)
	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853)


Revision range:
http://test-results.appspot.com/revision_range?start=437627&end=437673

Maybe related to issue 668217?

Comment 1 by perezju@chromium.org, Dec 12 2016

Labels: OS-Android
Same test failing on M, first failure there at:
https://build.chromium.org/p/chromium.android/builders/Marshmallow%20Tablet%20Tester/builds/6692

Same revision range.

Comment 2 by asvitk...@chromium.org, Dec 12 2016

Owner: tedc...@chromium.org
Status: Assigned (was: Untriaged)
Ted, can you take a look if it's related to your CL that changes visibility of context menu items:

https://codereview.chromium.org/2559573002

Comment 3 by perezju@chromium.org, Dec 13 2016 

This appears to have been fixed by something in the range:

http://test-results.appspot.com/revision_range?start=437838&end=437849

First build in M without the failure on this test:
https://luci-milo.appspot.com/buildbot/chromium.android/Marshmallow%20Tablet%20Tester/6718

Comment 4 by mariakho...@chromium.org, Dec 14 2016 

The "fix" in this range is that Ted's CL got reverted. So definitely https://codereview.chromium.org/2559573002 is the culprit.

Comment 5 by tedc...@chromium.org, Dec 14 2016 

Indeed.  My change made the context menu needed in the test rely on going through FRE before becoming available.  Tests disable FRE but do not mark it completed, so I had to work around that.

I updated my patch with a fix for the failing test.

Comment 6 by tedc...@chromium.org, Dec 16 2016

Status: Fixed (was: Assigned)
Relanded that patch (with fixes for this test) and haven't seen any failures.
►

Sign in to add a comment