gpu_angle_fuzzer breaks "Libfuzzer Upload Mac ASan" build |
|||
Issue descriptionThe new version of gpu fuzzer (https://codereview.chromium.org/2541843004/) added recently breaks Mac build (https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Mac%20ASan): [675/5399] LINK ./gpu_fuzzer_angle FAILED: gpu_fuzzer_angle gpu_fuzzer_angle.dSYM gpu_fuzzer_angle.dSYM/Contents/Info.plist gpu_fuzzer_angle.dSYM/Contents/Resources/DWARF/gpu_fuzzer_angle export DEVELOPER_DIR=/b/build/slave/Libfuzzer_Upload_Mac_ASan/build/src/build/mac_files/Xcode.app; TOOL_VERSION=1477669400 ../../build/toolchain/mac/linker_driver.py ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wcrl,dsym,. -stdlib=libc++ -arch x86_64 -Werror -Wl,-dead_strip -isysroot /b/build/slave/Libfuzzer_Upload_Mac_ASan/build/src/build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -mmacosx-version-min=10.9 -fsanitize=address -fsanitize-coverage=edge,indirect-calls,8bit-counters -Wl,-ObjC -Wl,-pie -Wl,-U,_LLVMFuzzerCustomMutator -Wl,-U,_LLVMFuzzerInitialize -Wl,-U,_sanitizer_options_link_helper -fsanitize=address -fsanitize-coverage=edge,indirect-calls,8bit-counters -stdlib=libc++ -L. -L../../build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/lib -o "./gpu_fuzzer_angle" -Wl,-filelist,"./gpu_fuzzer_angle.rsp" ./libc++.dylib -framework ApplicationServices -framework AppKit -lbsm -framework CoreFoundation -framework IOKit -framework Security -framework IOSurface -framework OpenGL -framework Quartz -framework CoreGraphics -framework CoreText -framework Foundation -framework Accelerate -framework AudioUnit -framework Carbon -framework CoreVideo -framework CFNetwork -framework CoreServices -framework SystemConfiguration -lresolv -framework QuartzCore -framework AVFoundation -framework CoreMedia Undefined symbols for architecture x86_64: "gl::PbufferGLSurfaceEGL::PbufferGLSurfaceEGL(gfx::Size const&)", referenced from: gpu::(anonymous namespace)::CommandBufferSetup::CommandBufferSetup() in fuzzer_main.o "gl::GLContextEGL::GLContextEGL(gl::GLShareGroup*)", referenced from: gpu::(anonymous namespace)::CommandBufferSetup::CommandBufferSetup() in fuzzer_main.o ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) Traceback (most recent call last): File "../../build/toolchain/mac/linker_driver.py", line 229, in <module> Main(sys.argv) File "../../build/toolchain/mac/linker_driver.py", line 79, in Main subprocess.check_call(compiler_driver_args) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 540, in check_call raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['../../third_party/llvm-build/Release+Asserts/bin/clang++', '-stdlib=libc++', '-arch', 'x86_64', '-Werror', '-Wl,-dead_strip', '-isysroot', '/b/build/slave/Libfuzzer_Upload_Mac_ASan/build/src/build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk', '-mmacosx-version-min=10.9', '-fsanitize=address', '-fsanitize-coverage=edge,indirect-calls,8bit-counters', '-Wl,-ObjC', '-Wl,-pie', '-Wl,-U,_LLVMFuzzerCustomMutator', '-Wl,-U,_LLVMFuzzerInitialize', '-Wl,-U,_sanitizer_options_link_helper', '-fsanitize=address', '-fsanitize-coverage=edge,indirect-calls,8bit-counters', '-stdlib=libc++', '-L.', '-L../../build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/lib', '-o', './gpu_fuzzer_angle', '-Wl,-filelist,./gpu_fuzzer_angle.rsp', './libc++.dylib', '-framework', 'ApplicationServices', '-framework', 'AppKit', '-lbsm', '-framework', 'CoreFoundation', '-framework', 'IOKit', '-framework', 'Security', '-framework', 'IOSurface', '-framework', 'OpenGL', '-framework', 'Quartz', '-framework', 'CoreGraphics', '-framework', 'CoreText', '-framework', 'Foundation', '-framework', 'Accelerate', '-framework', 'AudioUnit', '-framework', 'Carbon', '-framework', 'CoreVideo', '-framework', 'CFNetwork', '-framework', 'CoreServices', '-framework', 'SystemConfiguration', '-lresolv', '-framework', 'QuartzCore', '-framework', 'AVFoundation', '-framework', 'CoreMedia']' returned non-zero exit status 1
,
Dec 12 2016
One of the possible solutions is to use it for Linux only, if you would like: https://codereview.chromium.org/2564393002
,
Dec 12 2016
Jumping to Corentin, our fuzzing expert. Geoff feel free to snag back.
,
Dec 12 2016
Put up https://codereview.chromium.org/2572473002/ which I just realized is the same CL you had mmoroz@, sorry for the duplicate work :/
,
Dec 12 2016
Thank you guys for quick response!
,
Dec 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/689d5629cf7d5d23897fb99b847eaa0999289867 commit 689d5629cf7d5d23897fb99b847eaa0999289867 Author: cwallez <cwallez@chromium.org> Date: Tue Dec 13 17:54:19 2016 gpu_fuzzer_angle: only run on Linux gl_context_egl isn't being compiled on Mac so we can't run the ANGLE GPU fuzzer on that platform. Ideally we would like to gate it on use_egl but this variable is only defined in ui/gl/BUILD.gn and not gpu/BUILD.gn. Gating the fuzzer on is_linux will not lose coverage as the code run is completely platform-independent. BUG= chromium:673276 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2572473002 Cr-Commit-Position: refs/heads/master@{#438220} [modify] https://crrev.com/689d5629cf7d5d23897fb99b847eaa0999289867/gpu/BUILD.gn
,
Dec 13 2016
https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Mac%20ASan/builds/13043 is green, closing as fixed. |
|||
►
Sign in to add a comment |
|||
Comment 1 by mmoroz@chromium.org
, Dec 12 2016Owner: geoffl...@chromium.org