New issue
Advanced search Search tips

Issue 673246 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 687963

Blocking:
issue 650214



Sign in to add a comment

V8 Foozzie: Implementation

Project Member Reported by machenb...@chromium.org, Dec 12 2016

Issue description

Implementation tracker bug.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/e669816e1fcb4767771d482c58f5e1d51c01e4bc

commit e669816e1fcb4767771d482c58f5e1d51c01e4bc
Author: machenbach <machenbach@chromium.org>
Date: Mon Dec 19 10:13:48 2016

[foozzie] Initial correctness fuzzer harness.

Initial version of the correctness fuzzer harness for manual testing
and experiments.

For automated usage, some outstanding TODOs are left in the code. E.g.
- Hash source file names in error case
- Bundle script in out directory with executables
- Some suppressions are tied to already fixed bugs. We'll keep it like that for now to test
removing those suppressions in production later.

BUG= chromium:673246 
NOTRY=true

Review-Url: https://codereview.chromium.org/2578503003
Cr-Commit-Position: refs/heads/master@{#41789}

[add] https://crrev.com/e669816e1fcb4767771d482c58f5e1d51c01e4bc/tools/foozzie/v8_commands.py
[add] https://crrev.com/e669816e1fcb4767771d482c58f5e1d51c01e4bc/tools/foozzie/v8_foozzie.py
[add] https://crrev.com/e669816e1fcb4767771d482c58f5e1d51c01e4bc/tools/foozzie/v8_foozzie_test.py
[add] https://crrev.com/e669816e1fcb4767771d482c58f5e1d51c01e4bc/tools/foozzie/v8_mock.js
[add] https://crrev.com/e669816e1fcb4767771d482c58f5e1d51c01e4bc/tools/foozzie/v8_suppressions.js
[add] https://crrev.com/e669816e1fcb4767771d482c58f5e1d51c01e4bc/tools/foozzie/v8_suppressions.py

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/905d72befec43f374a1e475f4c5e034946a8a1af

commit 905d72befec43f374a1e475f4c5e034946a8a1af
Author: machenbach <machenbach@chromium.org>
Date: Mon Dec 26 16:55:24 2016

[foozzie] Fix paths and resources

BUG= chromium:673246 
NOTRY=true
TBR=tandrii@chromium.org

Review-Url: https://codereview.chromium.org/2598323002
Cr-Commit-Position: refs/heads/master@{#41954}

[modify] https://crrev.com/905d72befec43f374a1e475f4c5e034946a8a1af/tools/foozzie/v8_foozzie.py

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0bdb4690078a67d91f30454c1b438185a93d9aa6

commit 0bdb4690078a67d91f30454c1b438185a93d9aa6
Author: machenbach <machenbach@chromium.org>
Date: Tue Jan 10 10:19:21 2017

[foozzie] Add correctness fuzzer resources to build output

This adds the correctness fuzzer harness files to the output
directory guarded by a gn arg.

The switch will be turned on on the builder uploading builds to
clusterfuzz.

BUG= chromium:673246 
NOTRY=true
TBR=tandrii@chromium.org,jochen@chromium.org

Review-Url: https://codereview.chromium.org/2623843002
Cr-Commit-Position: refs/heads/master@{#42166}

[modify] https://crrev.com/0bdb4690078a67d91f30454c1b438185a93d9aa6/BUILD.gn
[modify] https://crrev.com/0bdb4690078a67d91f30454c1b438185a93d9aa6/gni/v8.gni
[add] https://crrev.com/0bdb4690078a67d91f30454c1b438185a93d9aa6/tools/foozzie/BUILD.gn

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/4dfe6194ec513c765441046a96ce1733613d5ee2

commit 4dfe6194ec513c765441046a96ce1733613d5ee2
Author: Michael Achenbach <machenbach@chromium.org>
Date: Tue Jan 10 10:34:17 2017

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d1f347fa54ad962c1d109be0e194ff85784137da

commit d1f347fa54ad962c1d109be0e194ff85784137da
Author: machenbach <machenbach@chromium.org>
Date: Tue Jan 10 10:54:04 2017

[foozzie] Add correctness-fuzzer-archive builder's mb config

Related to:
https://chromium-review.googlesource.com/c/426618

BUG= chromium:673246 
NOTRY=true
NOTREECHECKS=true
TBR=tandrii@chromium.org,jochen@chromium.org

Review-Url: https://codereview.chromium.org/2628483003
Cr-Commit-Position: refs/heads/master@{#42167}

[modify] https://crrev.com/d1f347fa54ad962c1d109be0e194ff85784137da/infra/mb/mb_config.pyl

Project Member

Comment 11 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/ede2fc1ff04ff97a466029b0ad52d3ec94780407

commit ede2fc1ff04ff97a466029b0ad52d3ec94780407
Author: machenbach <machenbach@chromium.org>
Date: Tue Jan 10 15:34:58 2017

[foozzie] Pass startup test

This makes sure the harness passes when called without test case.

BUG= chromium:673246 
NOTRY=true
TBR=tandrii@chromium.org,mbarbella@chromium.org

Review-Url: https://codereview.chromium.org/2623743004
Cr-Commit-Position: refs/heads/master@{#42183}

[modify] https://crrev.com/ede2fc1ff04ff97a466029b0ad52d3ec94780407/tools/foozzie/v8_foozzie.py

Project Member

Comment 12 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/e88e668e8130725247ce56fe40739d7ee1d308df

commit e88e668e8130725247ce56fe40739d7ee1d308df
Author: machenbach <machenbach@chromium.org>
Date: Tue Jan 10 17:18:59 2017

Revert of [foozzie] Pass startup test (patchset #1 id:1 of https://codereview.chromium.org/2623743004/ )

Reason for revert:
Setting the BAD_BUILDS_CHECK env variable should
be enough. Lets revert this as the code doesn't
look particularly good. There must be another
problem still that needs investigation.

Original issue's description:
> [foozzie] Pass startup test
>
> This makes sure the harness passes when called without test case.
>
> BUG= chromium:673246 
> NOTRY=true
> TBR=tandrii@chromium.org,mbarbella@chromium.org
>
> Review-Url: https://codereview.chromium.org/2623743004
> Cr-Commit-Position: refs/heads/master@{#42183}
> Committed: https://chromium.googlesource.com/v8/v8/+/ede2fc1ff04ff97a466029b0ad52d3ec94780407

TBR=tandrii@chromium.org,mbarbella@chromium.org,mmoroz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:673246 

Review-Url: https://codereview.chromium.org/2628493003
Cr-Commit-Position: refs/heads/master@{#42189}

[modify] https://crrev.com/e88e668e8130725247ce56fe40739d7ee1d308df/tools/foozzie/v8_foozzie.py

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/00e98a39e3a3006e3c2ad593a3713a058fc40475

commit 00e98a39e3a3006e3c2ad593a3713a058fc40475
Author: machenbach <machenbach@chromium.org>
Date: Fri Jan 13 06:31:54 2017

[foozzie] Improve failure state deduplication

The fuzz test cases now print the original test paths during execution.
This exploits this extra information and reports a hash of only one
original source file from the section that caused a difference.

The hash size is now limited to 3 to avoid possible duplicate
explosion, in case this doesn't work out as expected.

This prepares for patch 3 of:
https://chromereviews.googleplex.com/550337016/

BUG= chromium:673246 
NOTRY=true
TBR=tandrii@chromium.org,mbarbella@chromium.org

Review-Url: https://codereview.chromium.org/2620343005
Cr-Commit-Position: refs/heads/master@{#42305}

[modify] https://crrev.com/00e98a39e3a3006e3c2ad593a3713a058fc40475/tools/foozzie/testdata/failure_output.txt
[modify] https://crrev.com/00e98a39e3a3006e3c2ad593a3713a058fc40475/tools/foozzie/testdata/meta-123.js
[modify] https://crrev.com/00e98a39e3a3006e3c2ad593a3713a058fc40475/tools/foozzie/testdata/test_d8_1.py
[modify] https://crrev.com/00e98a39e3a3006e3c2ad593a3713a058fc40475/tools/foozzie/testdata/test_d8_2.py
[modify] https://crrev.com/00e98a39e3a3006e3c2ad593a3713a058fc40475/tools/foozzie/testdata/test_d8_3.py
[modify] https://crrev.com/00e98a39e3a3006e3c2ad593a3713a058fc40475/tools/foozzie/v8_foozzie.py
[modify] https://crrev.com/00e98a39e3a3006e3c2ad593a3713a058fc40475/tools/foozzie/v8_foozzie_test.py
[modify] https://crrev.com/00e98a39e3a3006e3c2ad593a3713a058fc40475/tools/foozzie/v8_suppressions.py

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 13 2017

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/936f79d9242c7450efa5a34edbb77404700ac5f3

commit 936f79d9242c7450efa5a34edbb77404700ac5f3
Author: machenbach <machenbach@chromium.org>
Date: Fri Jan 13 15:04:24 2017

[foozzie] Fix comparison baseline after asm switch

Now that validate asm is on by default, the comparison fullcode with
ignition_staging does nothing in regards to validate_asm.

BUG= chromium:673246 
NOTRY=true
TBR=bradnelson@chromium.org, titzer@chromium.org

Review-Url: https://codereview.chromium.org/2634573002
Cr-Commit-Position: refs/heads/master@{#42335}

[modify] https://crrev.com/936f79d9242c7450efa5a34edbb77404700ac5f3/tools/foozzie/testdata/failure_output.txt
[modify] https://crrev.com/936f79d9242c7450efa5a34edbb77404700ac5f3/tools/foozzie/v8_foozzie.py

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/69465f73f88b0f9dd5b89ae9910881e5d20b5f86

commit 69465f73f88b0f9dd5b89ae9910881e5d20b5f86
Author: machenbach <machenbach@chromium.org>
Date: Mon Jan 16 13:00:50 2017

[foozzie] Stop using extra metadata files.

Continuation of:
https://codereview.chromium.org/2620343005/

This removes usage of metadata files entirely. Instead we extract
the instrumentation about source files from the test cases.

This also adds extra output of the original source file in the
detailed failure text for easier debugging. The hashes alone
made it hard to reason.

BUG= chromium:673246 
NOTRY=true
TBR=tandrii@chromium.org,mbarbella@chromium.org

Review-Url: https://codereview.chromium.org/2634743004
Cr-Commit-Position: refs/heads/master@{#42371}

[modify] https://crrev.com/69465f73f88b0f9dd5b89ae9910881e5d20b5f86/tools/foozzie/testdata/failure_output.txt
[delete] https://crrev.com/22abb8b1235d22afd8cac87682188d1321160b53/tools/foozzie/testdata/meta-123.js
[delete] https://crrev.com/22abb8b1235d22afd8cac87682188d1321160b53/tools/foozzie/testdata/resources-123.js
[modify] https://crrev.com/69465f73f88b0f9dd5b89ae9910881e5d20b5f86/tools/foozzie/v8_foozzie.py
[modify] https://crrev.com/69465f73f88b0f9dd5b89ae9910881e5d20b5f86/tools/foozzie/v8_foozzie_test.py
[modify] https://crrev.com/69465f73f88b0f9dd5b89ae9910881e5d20b5f86/tools/foozzie/v8_suppressions.py

Project Member

Comment 18 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c69a40fc57e07a36782dc8f7e64dc96eee5c7679

commit c69a40fc57e07a36782dc8f7e64dc96eee5c7679
Author: machenbach <machenbach@chromium.org>
Date: Wed Jan 18 15:23:53 2017

[foozzie] Add ignition as baseline comparison

The new ignition config will be used as baseline comparison in new
jobs, e.g. against ignition_turbo. We'll keep --validate-asm off
in ignition_turbo for now as it is very chatty.

BUG= chromium:673246 
NOTRY=true

Review-Url: https://codereview.chromium.org/2640043002
Cr-Commit-Position: refs/heads/master@{#42464}

[modify] https://crrev.com/c69a40fc57e07a36782dc8f7e64dc96eee5c7679/tools/foozzie/testdata/failure_output.txt
[modify] https://crrev.com/c69a40fc57e07a36782dc8f7e64dc96eee5c7679/tools/foozzie/v8_foozzie.py
[modify] https://crrev.com/c69a40fc57e07a36782dc8f7e64dc96eee5c7679/tools/foozzie/v8_foozzie_test.py

Project Member

Comment 19 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/24b9fc3a9a42977f58c872d4d99cce92e232650c

commit 24b9fc3a9a42977f58c872d4d99cce92e232650c
Author: machenbach <machenbach@chromium.org>
Date: Fri Jan 20 15:35:07 2017

[foozzie] Use correct ignition baseline

Also switch on validate asm in all configuration to zero out any
comparisons.

BUG= chromium:673246 
NOTRY=true
TBR=mstarzinger@chromium.org, rmcilroy@chromium.org

Review-Url: https://codereview.chromium.org/2647493004
Cr-Commit-Position: refs/heads/master@{#42569}

[modify] https://crrev.com/24b9fc3a9a42977f58c872d4d99cce92e232650c/tools/foozzie/v8_foozzie.py

Project Member

Comment 20 by bugdroid1@chromium.org, Feb 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/13de00c0be07c772245361e62023792f5a8ec715

commit 13de00c0be07c772245361e62023792f5a8ec715
Author: machenbach <machenbach@chromium.org>
Date: Thu Feb 02 11:32:52 2017

[foozzie] Support multi-architecture builds

This adds optional multi-architecture builds, allowing to compile
x86 and x64 in one build. The correctness fuzzer can be configured to
compare the two executables, e.g. to compare x86 to x64 run the
launcher with: --second-d8=clang_x86/d8 in an x64 build.

Configuring the executable's architecture is now simplified and
inferred from the gn build configuration.

Building for clusterfuzz has now a new canonical target that can be
used by the infrastructure (defaults to d8).

The clusterfuzz release builder is now defined to compile
multi-arch builds, which will have an effect as soon as the
infrastructure refers to the new clusterfuzz target.

BUG= chromium:673246 
NOTRY=true
TBR=mstarzinger,jarin

Review-Url: https://codereview.chromium.org/2649133010
Cr-Commit-Position: refs/heads/master@{#42884}

[modify] https://crrev.com/13de00c0be07c772245361e62023792f5a8ec715/BUILD.gn
[modify] https://crrev.com/13de00c0be07c772245361e62023792f5a8ec715/gni/v8.gni
[modify] https://crrev.com/13de00c0be07c772245361e62023792f5a8ec715/infra/mb/mb_config.pyl
[modify] https://crrev.com/13de00c0be07c772245361e62023792f5a8ec715/tools/foozzie/v8_foozzie.py

Project Member

Comment 21 by bugdroid1@chromium.org, Feb 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/c34e1fd412b20e7d93926430d9e6e9dddf3ceac5

commit c34e1fd412b20e7d93926430d9e6e9dddf3ceac5
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu Feb 02 11:38:58 2017

V8: Use canonical target on clusterfuzz builders.

This allows changing the underlying targets on the v8-side.

Follow up to v8-side:
https://codereview.chromium.org/2649133010/

BUG= chromium:673246 

Change-Id: Ie71b1599f112f8522b0e750b77fd385363ab38a5
Reviewed-on: https://chromium-review.googlesource.com/435304
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/c34e1fd412b20e7d93926430d9e6e9dddf3ceac5/scripts/slave/recipe_modules/v8/builders.py
[modify] https://crrev.com/c34e1fd412b20e7d93926430d9e6e9dddf3ceac5/scripts/slave/recipe_modules/v8/chromium_config.py
[modify] https://crrev.com/c34e1fd412b20e7d93926430d9e6e9dddf3ceac5/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN___debug_builder.json
[modify] https://crrev.com/c34e1fd412b20e7d93926430d9e6e9dddf3ceac5/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN_arm64___debug_builder.json
[modify] https://crrev.com/c34e1fd412b20e7d93926430d9e6e9dddf3ceac5/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN_no_inline___release_builder.json
[modify] https://crrev.com/c34e1fd412b20e7d93926430d9e6e9dddf3ceac5/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___release_builder.json
[modify] https://crrev.com/c34e1fd412b20e7d93926430d9e6e9dddf3ceac5/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux_ASAN_arm___debug_builder.json
[modify] https://crrev.com/c34e1fd412b20e7d93926430d9e6e9dddf3ceac5/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux_ASAN_mipsel___debug_builder.json

Project Member

Comment 22 by bugdroid1@chromium.org, Feb 2 2017

Project Member

Comment 23 by bugdroid1@chromium.org, Feb 2 2017

Blockedon: 687963
Project Member

Comment 25 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f1f7050173195918e5e2177676ab0bd40166947d

commit f1f7050173195918e5e2177676ab0bd40166947d
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Feb 03 15:32:20 2017

[foozzie] Don't use utf-8 encoding for console output.

BUG= chromium:673246 , chromium:688307 
NOTRY=true
R=tandrii@chromium.org
TBR=mstarzinger@chromium.org

Change-Id: I269032497cf574cf5180762e37b0fee1002a6c76
Reviewed-on: https://chromium-review.googlesource.com/437244
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#42931}
[modify] https://crrev.com/f1f7050173195918e5e2177676ab0bd40166947d/tools/foozzie/v8_foozzie.py

Project Member

Comment 26 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/325b87ba062f3a15f646f5bebbb4acc248177331

commit 325b87ba062f3a15f646f5bebbb4acc248177331
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Feb 03 15:42:38 2017

[foozzie] Only apply output-bail-out on differences

With the old logic, a suppression shows up in the statistics independent if the test cases caused a difference or not. This doesn't give a signal if a suppression is useful. The new logic will help cleaning up suppressions that never apply.

BUG= chromium:673246 
NOTRY=true
R=tandrii@chromium.org
TBR=mstarzinger@chromium.org,jarin@chromium.org

Change-Id: Iaebdac475f408f7d2649a34ccaa580c8d91e34a5
Reviewed-on: https://chromium-review.googlesource.com/437264
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#42932}
[modify] https://crrev.com/325b87ba062f3a15f646f5bebbb4acc248177331/tools/foozzie/v8_foozzie.py

Project Member

Comment 27 by bugdroid1@chromium.org, Feb 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c495421cc229738bc4dd0fdf8bb65fd45f1244b9

commit c495421cc229738bc4dd0fdf8bb65fd45f1244b9
Author: Michael Achenbach <machenbach@chromium.org>
Date: Mon Feb 13 09:55:14 2017

[foozzie] Add configuration for comparing lazy/non-lazy parsing

BUG= chromium:673246 
NOTRY=true
TBR=marja@chromium.org

Change-Id: If1fe4e886f03b3d6df57fb55df4db7efe7c625fa
Reviewed-on: https://chromium-review.googlesource.com/441764
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#43145}
[modify] https://crrev.com/c495421cc229738bc4dd0fdf8bb65fd45f1244b9/tools/foozzie/v8_foozzie.py

Project Member

Comment 28 by bugdroid1@chromium.org, Feb 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f3b5f70cd2c161124a1622b3bcdcde1efa859262

commit f3b5f70cd2c161124a1622b3bcdcde1efa859262
Author: Michael Achenbach <machenbach@chromium.org>
Date: Mon Feb 13 10:49:25 2017

[foozzie] Add more architectures for correctness comparisons

BUG= chromium:673246 
NOTRY=true
TBR=jarin@chromium.org,ahaas@chromium.org

Change-Id: Ie2000f543e017dbef27c3faa49565fe838eddcee
Reviewed-on: https://chromium-review.googlesource.com/441345
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#43153}
[modify] https://crrev.com/f3b5f70cd2c161124a1622b3bcdcde1efa859262/BUILD.gn

Project Member

Comment 29 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/ced664372649f091204aa51416654256648ac2e2

commit ced664372649f091204aa51416654256648ac2e2
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu Mar 02 12:38:39 2017

[foozzie] Remove obsolete stack-trace suppressions

BUG= chromium:673246 
NOTRY=true
TBR=yangguo@chromium.org

Change-Id: I413c23006f0f5e7879eaaece5f82f6c0fb4f7109
Reviewed-on: https://chromium-review.googlesource.com/447979
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#43537}
[modify] https://crrev.com/ced664372649f091204aa51416654256648ac2e2/tools/foozzie/v8_suppressions.py

Project Member

Comment 30 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/70965025ca1d7d4234d7645c48bee1988d2c6067

commit 70965025ca1d7d4234d7645c48bee1988d2c6067
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Mar 03 15:08:44 2017

[foozzie] Add config to run turbo_opt and no-lazy

BUG= chromium:673246 
NOTRY=true
TBR=marja@chromium.org

Change-Id: I87faa32ae602a10b68a22fce46ee3bb39a7aa171
Reviewed-on: https://chromium-review.googlesource.com/449754
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#43592}
[modify] https://crrev.com/70965025ca1d7d4234d7645c48bee1988d2c6067/tools/foozzie/v8_foozzie.py

Project Member

Comment 31 by bugdroid1@chromium.org, Mar 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/146c9e5406efee3c67e1abf170d6c866b7f74bc8

commit 146c9e5406efee3c67e1abf170d6c866b7f74bc8
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Mar 10 11:03:08 2017

[foozzie] Consistently drop validate-asm flag

Also format flags in single lines to make configs easier to read and modify.

BUG= chromium:673246 
NOTRY=true
R=mstarzinger@chromium.org,titzer@chromium.org,rmcilroy@chromium.org

Change-Id: If37486c98af161467b639271b035207c3ae1077a
Reviewed-on: https://chromium-review.googlesource.com/452579
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#43719}
[modify] https://crrev.com/146c9e5406efee3c67e1abf170d6c866b7f74bc8/tools/foozzie/testdata/failure_output.txt
[modify] https://crrev.com/146c9e5406efee3c67e1abf170d6c866b7f74bc8/tools/foozzie/v8_foozzie.py

Status: Verified (was: Started)

Sign in to add a comment