New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 673244 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Crash in v8::internal::Simulator::DecodeType2

Project Member Reported by ClusterFuzz, Dec 12 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5916664546983936

Fuzzer: decoder_langfuzz
Job Type: linux_asan_d8_ignition_v8_arm_dbg
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0xffffffff
Crash State:
  v8::internal::Simulator::DecodeType2
  v8::internal::Simulator::InstructionDecode
  v8::internal::Simulator::CallInternal
  
Recommended Security Severity: Medium

Regressed: V8: r41057:41058

Minimized Testcase (7.56 Kb): https://cluster-fuzz.appspot.com/download/AMIfv948WJpUb9kKH9TmQs8nvK8kZOTD5ZJKOAyA0BmnaR0yjOo4vXUjYZhHOvsUm9KJY336Bsymu3uyWVJZTWvUfuNf9OV3EwNsuFt5NpgtOAl-fpS6pnLyCpDAi3qKb0ElPfqGSBJW1HGcY8QW2NB-pCst9PasXQ?testcase_id=5916664546983936

Issue manually filed by: ishell

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 

Comment 1 by ishell@chromium.org, Dec 12 2016

Cc: jarin@chromium.org mstarzinger@chromium.org
Owner: bmeu...@chromium.org
Status: Assigned (was: Untriaged)
CF points to b8c2035f261f904c3424a46894d4a76036363df2
Cc: -jarin@chromium.org bmeu...@chromium.org mvstan...@chromium.org
Components: -Blink>JavaScript Blink>JavaScript>Compiler
Owner: jarin@chromium.org
Jaro, can you take a look? Seems like loop peeling triggered some bug. You can ask Rodolph if they can help with this one once you have a repro and it looks like it's an ARM bug.

Comment 3 by jarin@chromium.org, Dec 12 2016

I am on it. It is a bug in representation changer when we introduced the split between the tagged pointer and smi.

Comment 4 by jarin@chromium.org, Dec 12 2016

Apparently, conversion from bit to tagged pointer is a no-op :-)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 12 2016

Project Member

Comment 6 by sheriffbot@chromium.org, Dec 12 2016

Labels: Pri-1
Project Member

Comment 7 by ClusterFuzz, Dec 13 2016

ClusterFuzz has detected this issue as fixed in range 41633:41634.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5916664546983936

Fuzzer: decoder_langfuzz
Job Type: linux_asan_d8_ignition_v8_arm_dbg
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0xffffffff
Crash State:
  v8::internal::Simulator::DecodeType2
  v8::internal::Simulator::InstructionDecode
  v8::internal::Simulator::CallInternal
  
Recommended Security Severity: Medium

Regressed: V8: r41057:41058
Fixed: V8: r41633:41634

Minimized Testcase (7.56 Kb): https://cluster-fuzz.appspot.com/download/AMIfv948WJpUb9kKH9TmQs8nvK8kZOTD5ZJKOAyA0BmnaR0yjOo4vXUjYZhHOvsUm9KJY336Bsymu3uyWVJZTWvUfuNf9OV3EwNsuFt5NpgtOAl-fpS6pnLyCpDAi3qKb0ElPfqGSBJW1HGcY8QW2NB-pCst9PasXQ?testcase_id=5916664546983936

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Dec 13 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5916664546983936 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 9 by sheriffbot@chromium.org, Dec 13 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: M-57 M-56 Security_Impact-Beta
Project Member

Comment 11 by sheriffbot@chromium.org, Dec 15 2016

Labels: Merge-Request-56

Comment 12 by dimu@chromium.org, Dec 15 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 13 by sheriffbot@chromium.org, Dec 19 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by sheriffbot@chromium.org, Dec 23 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -reward-topanel reward-unpaid reward-3000
Labels: reward_to-decoder.oh_at_googlemail.com
$3,000 for this find :-)
Labels: -reward-unpaid reward-inprocess
Project Member

Comment 18 by bugdroid1@chromium.org, Feb 9 2017

Labels: merge-merged-5.6
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/bd54aa2c9039a141b09d2456f8d7297ae3f5baf8

commit bd54aa2c9039a141b09d2456f8d7297ae3f5baf8
Author: Jaroslav Sevcik <jarin@chromium.org>
Date: Thu Feb 09 12:16:50 2017

Merged: [turbofan] Fix representation change from bit to tagged pointer.

Revision: d024df4d22eb69904bfd29c7716ff0f2c16f5d18

BUG= chromium:673244 
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=bmeurer@chromium.org
TBR=bmeurer@chromium.org

Review-Url: https://codereview.chromium.org/2684593007 .
Cr-Commit-Position: refs/branch-heads/5.6@{#112}
Cr-Branched-From: bdd3886218dfe76e8560eb8a18401942452ae859-refs/heads/5.6.326@{#1}
Cr-Branched-From: 879f6599eee6e1dfcbe9a24bf688b261c03e9558-refs/heads/master@{#41014}

[modify] https://crrev.com/bd54aa2c9039a141b09d2456f8d7297ae3f5baf8/src/compiler/representation-change.cc
[add] https://crrev.com/bd54aa2c9039a141b09d2456f8d7297ae3f5baf8/test/mjsunit/compiler/regress-673244.js

Labels: -Merge-Approved-56
Project Member

Comment 20 by sheriffbot@chromium.org, Mar 21 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment