New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 673234 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression:[Md-settings]'Learn more' link of credit card is in disable form evenif it's clickable.

Reported by dmascare...@etouch.net, Dec 12 2016

Issue description

Chrome Version:57.0.2949.0 Revision 26b2f7b619d9a83b2151b47ad175ed9e1ecf3ccf-refs/heads/master@{#437811}
OS: Mac(10.11.6, 10.12.1, 10.12), Windows(7,8,8.1,10), Linux (14.04 LTS) 

What steps will reproduce the problem?
1. Launch chrome and 'Sign in' browser with valid credential.
2. Navigate to chrome://md-settings/syncSetup for 'Syn everything' option,observe 'Learn more' link beside credit card option.

Actual: 'Learn more' link is not in active state colour,eventhough it's clickable.
Expected: 'Learn more' link should be in active state colour for clickable link.

This is regression issue, broken in 'M 57' and below is manual bisect:
Good build:57.0.2946.0
Bad build:57.0.2947.0
 
Actual.mp4
1.1 MB View Download
Labels: Needs-Bisect
Status: Untriaged (was: Unconfirmed)
Cc: sureshkumari@chromium.org
Labels: -Needs-Bisect hasbisect-per-revision
Owner: scottchen@chromium.org
Status: Assigned (was: Untriaged)
Narrow Bisect::
===============
Good :57.0.2946.0 --   (build revision 437422)
Bad:: 57.0.2947.0 --   (build revision 437705)

ChangeLog: 
================
https://chromium.googlesource.com/chromium/src/+log/55c13aa9610ea5e5dc91f3d3b21c5cc42d05ff5c..d93ce395d082047e5b0d5d4ef038eeb3106beb22

possible suspect
==================
d93ce395d082047e5b0d5d4ef038eeb3106beb22
	
Review URL: https://codereview.chromium.org/2563443005

scottchen@ could you please look into this issue if it is related to your change,else please help us in finding the appropriate owner for this issue.

Thanks.
It's only somewhat related, but my change isn't the cause of this bug. 
To explain what is happening - the link is inside the label of the paper-checkbox, so when the paper-checkbox is disabled, the link gets affected as well due to how paper-checkbox was implemented. The previous bug was that the link wasn't even clickable when the button's disabled, so my previous change to this button was to make the link clickable regardless of the button state. 

That said, I'll look into a solution that makes the link look clickable regardless of the button state.
Cc: dbeam@chromium.org
Status: Fixed (was: Assigned)
fixed by https://codereview.chromium.org/2617533003/ as a side effect. dbeam@ FYI

Sign in to add a comment