Issue metadata
Sign in to add a comment
|
"Flakiness dashboard" links no longer displayed |
||||||||||||||||||||
Issue descriptionIn the past, there was always a link displayed in the waterfall view next to the failing tests, with the test executable and name pre-populated as URL arguments. This link was very convenient for the sheriffs to use when figuring out if the test was flaky or not. Now the sheriff needs to fill in all these values manually, which if fine once but really inefficient if you're an active sheriff. Can we bring this functionality back? It seems the code is still there but something changed in the parsing: https://cs.chromium.org/chromium/build/scripts/slave/annotation_utils.py?rcl=0&l=67 Example: The build at https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/55499 should have displayed a link next to StoragePartitionShaderClearTest.ClearShaderCache pointing at http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_unittests&tests=StoragePartitionShaderClearTest.ClearShaderCache I think this is essential for the usefulness of the flakiness dashboard as a product. I discovered this as WebRTC finally onboarded to the flakiness dashboard as well, and I was instantly missing this feature. It's quite likely that this has been broken for a while, I think I remember it was at least at my last sheriff shift, but I never got to file a bug at the time. Maybe it's possible to query archived build logs to see exactly when it broke?
,
Jan 2 2017
Ping?
,
Jan 9 2017
,
Jan 9 2017
,
Jan 9 2017
Dan, since you've added [logdog] links, would you happen to know where in the source code we would need to add these links?
,
Feb 7 2017
Hmm, interesting. We probably don't want to do it at the service level since it ends up hardcoding a lot of rules (test-results server, what tests look like) but rather somewhere in recipes. I'm not sure how this should be done beyond that.
,
Feb 8 2017
RE #5, while aliasing can be employed here, it seems to me like what's missing are simple STEP_LINK annotations, which are the responsibility of the recipe in question to emit. Looking at the annotations for that build: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin7_Tests__dbg__1_%2F55499%2F%2B%2Frecipes%2Fstdout It seems that no such STEP_LINK was emitted. I think that this is not a Platform issue; the recipe needs to be fixed to emit these links where appropriate.
,
Feb 16 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 16 2018
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by kjellander@chromium.org
, Dec 20 2016