New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 673223 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: 'Add new class' ghost text is not seen after clicking on ".cls" under 'Element' section of dev tools.

Reported by rk...@etouch.net, Dec 12 2016

Issue description

Chrome Version: 57.0.2949.0 Revision 26b2f7b619d9a83b2151b47ad175ed9e1ecf3ccf-refs/heads/master@{#437811}
OS: Mac(10.11.6, 10.12.1, 10.12), Windows(7,8,8.1,10), Linux (14.04 LTS) 

What steps will reproduce the problem?
(1) Launch chrome, open dev tools window
(2) Click on ".cls" (Element classes)in Element section and observe.

Actual: 'Add new class' ghost text is not seen after clicking on ".cls".

Expected: 'Add new class' ghost text is not seen after clicking on ".cls".

This is a regression issue, broken in 'M-57', will soon update the other info:

Good Build: 57.0.2945.0
Bad Build: 57.0.2946.0

 
Actual_Text.mp4
429 KB View Download
Expected_GhostText.mp4
190 KB View Download
Labels: Needs-Bisect
Status: Untriaged (was: Unconfirmed)
Components: -Platform>DevTools Platform>DevTools>Authoring
Owner: phulce@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by phulce@chromium.org, Dec 12 2016

Status: Started (was: Assigned)
Introduced by https://codereview.chromium.org/2545983002 textPrompt.css contained a different CSS rule with higher specificity.

Comment 4 by ajha@chromium.org, Dec 13 2016

Labels: -Needs-Bisect
phulce@: I am removing the needs-bisect label as the suspect is already identified in #3. Please add the needs-bisect label back if you still need bisect for this.

Thank you!
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8d3e064a6010ee79aca71eb8dea18096fc7822c

commit e8d3e064a6010ee79aca71eb8dea18096fc7822c
Author: phulce <phulce@chromium.org>
Date: Tue Dec 13 21:35:24 2016

DevTools: Fix 'Add new class' placeholder text

Fixes bug where placeholder text disappeared
on the Element tab's 'Add new class' input element.

BUG= 673223 

Review-Url: https://codereview.chromium.org/2568013003
Cr-Commit-Position: refs/heads/master@{#438282}

[modify] https://crrev.com/e8d3e064a6010ee79aca71eb8dea18096fc7822c/third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js
[modify] https://crrev.com/e8d3e064a6010ee79aca71eb8dea18096fc7822c/third_party/WebKit/Source/devtools/front_end/elements/elementsPanel.css

Comment 6 by phulce@chromium.org, Dec 14 2016

Labels: Hotlist-Polish
Status: Fixed (was: Started)

Sign in to add a comment