New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 673220 link

Starred by 1 user
Status: WontFix
Owner:
jdoerrie@chromium.org
Closed: Dec 2016
Cc:
nyerramilli@chromium.org
█ brajkumar@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression:Focus ring is not displayed properly after pressing tab key in chrome://md-settings/managePasswords.

Reported by vku...@etouch.net, Dec 12 2016 
Chrome Version: 57.0.2948.0 (Official Build)Revision 314c528dc177ac458d2449a8c4d937378d3b8c5e-refs/heads/master@{#437764} (32/64-bit)
OS: Windows (7,8,10), Mac (10.10.5, 10.11.4), Linux (14.04 LTS). 

What steps will reproduce the problem?
(1)Launch chrome,navigate to https://twitter.com/ login with valid credentials
(2)Click on save password button from password bubble and navigate to chrome://md-settings/managePasswords
(3)Press tab key till focus reaches website url,observe 

Actual: Focus ring is not displayed properly after pressing tab key.

Expected: Focus ring should be properly displayed after pressing tab key.

This is a regression issue broken in 'M57' and below is the manual regression range:
Good Build: 57.0.2941.0
Bad Build:  57.0.2939.0
Actual.png
59.4 KB View Download
Expected.png
61.4 KB View Download

Comment 1 by brajkumar@chromium.org, Dec 12 2016

Cc: brajkumar@chromium.org
Labels: hasbisect-per-revision
Owner: jdoerrie@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,

You are probably looking for a change made after 435903 (known bad), but no later than 435904 (first known good).

CHANGE-LOG URL:
---------------------------------------
https://chromium.googlesource.com/chromium/src/+log/0aa34793db987eec0518583d2a03f72ce9be8f4a..42a5543b03b6b099cc52f6d672250c16b8ace86f

From the CL above, assigning the issue to the concern owner
Review-Url: https://codereview.chromium.org/2442333003

jdoerrie@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!

Comment 2 by jdoerrie@chromium.org, Dec 13 2016

Status: WontFix (was: Assigned)
The changelist in question added the following CSS properties to the website column in order to elide long origin URLs from the left:

direction: rtl;
overflow: hidden;
text-align: left;
text-overflow: ellipsis;
white-space: nowrap;

This is beneficial for security reasons and is recommended here: 

https://www.chromium.org/Home/chromium-security/enamel#TOC-Eliding-Origin-Names-And-Hostnames

It is possible that one of the added properties results in the slight change of the focus ring, however all of them are critical to get left eliding to work. 

In case the new appearance of the focus ring is not appropriate, I recommend you file this bug against the rendering engine, which lives in another part of the codebase. Therefore I will mark this as WontFix.
►

Sign in to add a comment