remove macviews_interactive_ui_tests from views.gyp and run all the tests in the regular interactive_ui_tests target. |
||||
Issue descriptionChrome Version : 56.0.2914.3 widget/native_widget_mac_interactive_uitest.mm should be run in the same place as widget/widget_interactive_uitest.cc Should just be a matter of changing .gn files, but there may be some broken stuff, or platform-specific failures to sort out :/
,
Sep 1 2017
https://chromium-review.googlesource.com/c/chromium/src/+/648108
,
Sep 1 2017
,
Sep 4 2017
Trying all the OSes with $ tools/swarming_client/swarming.py trigger -S https://chromium-swarm.appspot.com -I https://isolateserver.appspot.com -d os Mac-10.11 -d pool Chrome -s 2831630da0583b26a41cf685ea792c4eb28eba2e Triggered task: tapted@google.com/os=Mac-10.11_pool=Chrome/2831630da0583b26a41cf685ea792c4eb28eba2e To collect results, use: swarming.py collect -S https://chromium-swarm.appspot.com 386473434c33bc10 Or visit: https://chromium-swarm.appspot.com/user/task/386473434c33bc10 $ tools/swarming_client/swarming.py trigger -S https://chromium-swarm.appspot.com -I https://isolateserver.appspot.com -d os Mac-10.10 -d pool Chrome -s 2831630da0583b26a41cf685ea792c4eb28eba2e Triggered task: tapted@google.com/os=Mac-10.10_pool=Chrome/2831630da0583b26a41cf685ea792c4eb28eba2e To collect results, use: swarming.py collect -S https://chromium-swarm.appspot.com 38647389374a0110 Or visit: https://chromium-swarm.appspot.com/user/task/38647389374a0110 $ tools/swarming_client/swarming.py trigger -S https://chromium-swarm.appspot.com -I https://isolateserver.appspot.com -d os Mac-10.9 -d pool Chrome -s 2831630da0583b26a41cf685ea792c4eb28eba2e Triggered task: tapted@google.com/os=Mac-10.9_pool=Chrome/2831630da0583b26a41cf685ea792c4eb28eba2e To collect results, use: swarming.py collect -S https://chromium-swarm.appspot.com 386473a5d9056710 Or visit: https://chromium-swarm.appspot.com/user/task/386473a5d9056710 $ tools/swarming_client/swarming.py trigger -S https://chromium-swarm.appspot.com -I https://isolateserver.appspot.com -d os Mac-10.12 -d pool Chrome -s 2831630da0583b26a41cf685ea792c4eb28eba2e Triggered task: tapted@google.com/os=Mac-10.12_pool=Chrome/2831630da0583b26a41cf685ea792c4eb28eba2e To collect results, use: swarming.py collect -S https://chromium-swarm.appspot.com 386473c007b8f810 Or visit: https://chromium-swarm.appspot.com/user/task/386473c007b8f810 $ tools/swarming_client/swarming.py trigger -S https://chromium-swarm.appspot.com -I https://isolateserver.appspot.com -d os Mac-10.13 -d pool Chrome -s 2831630da0583b26a41cf685ea792c4eb28eba2e Triggered task: tapted@google.com/os=Mac-10.13_pool=Chrome/2831630da0583b26a41cf685ea792c4eb28eba2e To collect results, use: swarming.py collect -S https://chromium-swarm.appspot.com 386473ded76f2310 Or visit: https://chromium-swarm.appspot.com/user/task/386473ded76f2310
,
Sep 7 2017
All the macviews_interactive_ui_tests ran OK. Summary 10.9 https://chromium-swarm.appspot.com/task?id=386473a5d9056710&refresh=10&show_raw=1 [428/428] WebViewInteractiveTests/WebViewPointerLockInteractiveTest.PointerLock_PointerLockLostWithFocus/0 (TIMED OUT) 1 test timed out: WebViewInteractiveTests/WebViewPointerLockInteractiveTest.PointerLock_PointerLockLostWithFocus/0 (../../chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc:655) 10.10 got a bad bot first time. retry - https://chromium-swarm.appspot.com/task?id=3873c09101a6f010&refresh=10&show_raw=1 all pass, one retry: WebViewInteractiveTests/WebViewPointerLockInteractiveTest.PointerLock_PointerLockLostWithFocus/0 10.11 https://chromium-swarm.appspot.com/task?id=386473434c33bc10&refresh=10&show_raw=1 all pass, no retries. 10.12 https://chromium-swarm.appspot.com/task?id=386473c007b8f810&refresh=10&show_raw=1 1 test timed out: WebViewInteractiveTests/WebViewPointerLockInteractiveTest.PointerLock_PointerLockLostWithFocus/0 (../../chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc:655) There's a bug for that test already - Issue 761783 (also Issue 293445 and Issue 640996)
,
Sep 7 2017
Except BridgedNativeWidgetUITest.HitTest definitely failed in the try run at on 10.12 - https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_10.12_rel_ng/builds/79 So that either needs a deflake or a disable.
,
Sep 7 2017
weirdly? it only fails for the browser_side_navigation_interactive_ui_tests run -- regular interactive_ui_tests passed.
Error like
[ RUN ] BridgedNativeWidgetUITest.HitTest
[93141:775:0904/001409.292397:31751532471829:ERROR:native_widget_mac.mm(281)] Not implemented reached in virtual void views::NativeWidgetMac::SetWindowIcons(const gfx::ImageSkia &, const gfx::ImageSkia &)
[93141:775:0904/001409.308589:31751548655926:ERROR:native_widget_mac.mm(281)] Not implemented reached in virtual void views::NativeWidgetMac::SetWindowIcons(const gfx::ImageSkia &, const gfx::ImageSkia &)
../../ui/views/cocoa/bridged_native_widget_interactive_uitest.mm:425: Failure
Value of: [did_move_observer wait]
Actual: false
Expected: true
../../ui/views/cocoa/bridged_native_widget_interactive_uitest.mm:426: Failure
Expected: 120
To be equal to: [window frame].origin.x
Which is: 110
../../ui/views/cocoa/bridged_native_widget_interactive_uitest.mm:432: Failure
Expected: 120
To be equal to: [window frame].origin.x
Which is: 110
../../ui/views/cocoa/bridged_native_widget_interactive_uitest.mm:484: Failure
Expected: 120
To be equal to: [window frame].origin.x
Which is: 110
../../ui/views/cocoa/bridged_native_widget_interactive_uitest.mm:508: Failure
Expected: 120
To be equal to: [window frame].origin.x
Which is: 110
../../ui/views/cocoa/bridged_native_widget_interactive_uitest.mm:514: Failure
Expected: 120
To be equal to: [window frame].origin.x
Which is: 110
../../ui/views/cocoa/bridged_native_widget_interactive_uitest.mm:529: Failure
Expected: 120
To be equal to: [window frame].origin.x
Which is: 110
../../ui/views/cocoa/bridged_native_widget_interactive_uitest.mm:535: Failure
Expected: 120
To be equal to: [window frame].origin.x
Which is: 110
[ FAILED ] BridgedNativeWidgetUITest.HitTest (11521 ms)
,
Sep 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c063999aba8a5f057044e0e97771c43858afba42 commit c063999aba8a5f057044e0e97771c43858afba42 Author: Trent Apted <tapted@chromium.org> Date: Thu Sep 21 00:53:26 2017 Run MacViews interactive_ui_tests on the waterall. Use the approach in use for other interactive tests under ui/views. This is to include them in the browser's interactive_ui_tests target. But pull all the tests together: With gn, we can do it neater by using source_set dep, rather than referencing the source files directly under a different path under chrome/browser/ui. Deflake NativeWidgetMacInteractiveUITest.ShowAttainsKeyStatus. It wasn't properly accounting for asynchronous interactions with the WindowServer process. Bug: 673219 Change-Id: Ib7c52273a7f621a3d1f3a3b3701491939cfa840d Reviewed-on: https://chromium-review.googlesource.com/648108 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#503301} [modify] https://crrev.com/c063999aba8a5f057044e0e97771c43858afba42/chrome/test/BUILD.gn [modify] https://crrev.com/c063999aba8a5f057044e0e97771c43858afba42/ui/views/BUILD.gn [modify] https://crrev.com/c063999aba8a5f057044e0e97771c43858afba42/ui/views/cocoa/bridged_native_widget_interactive_uitest.mm [modify] https://crrev.com/c063999aba8a5f057044e0e97771c43858afba42/ui/views/test/views_interactive_ui_test_base.cc [modify] https://crrev.com/c063999aba8a5f057044e0e97771c43858afba42/ui/views/test/views_interactive_ui_test_base.h [modify] https://crrev.com/c063999aba8a5f057044e0e97771c43858afba42/ui/views/widget/native_widget_mac_interactive_uitest.mm
,
Sep 21 2017
BridgedNativeWidgetUITest.HitTest still fails, but only on some bots. Following up in Issue 767299. I suspect a bot misconfiguration, or stray window that's intercepting mouse events. |
||||
►
Sign in to add a comment |
||||
Comment 1 by ellyjo...@chromium.org
, Apr 12 2017