New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 673218 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: ----

Blocked on:
issue 673433



Sign in to add a comment

chrome_public_test_apk and content_shell_test_apk on Android failing on chromium.linux/Android Tests (dbg)

Project Member Reported by gab@chromium.org, Dec 12 2016

Issue description

chrome_public_test_apk and content_shell_test_apk on Android failing on chromium.linux/Android Tests (dbg)

Type: build-failure

Builders failed on: 
- Android Tests (dbg): 
  https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29


Reverting suspect in progress: https://codereview.chromium.org/2565313002/
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b559a0948b325b01789c01e44ee89719df93feb4

commit b559a0948b325b01789c01e44ee89719df93feb4
Author: gab <gab@chromium.org>
Date: Mon Dec 12 16:34:54 2016

Revert of Delay Input.dispatchKeyEvent response until after key event ack. (patchset #16 id:300001 of https://codereview.chromium.org/2387353004/ )

Reason for revert:
Tentative revert for:

Failed steps failed chrome_public_test_apk on android failed content_browsertests on android

https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29?numbuilds=200

as of this CL (and 2 others which are mere renames + don't touch content so suspecting this one from the 3: https://chromium.googlesource.com/chromium/src/+log/b671a5234f41f1784bd261a7c1eb6010434cd2c2..92aad3c0c15d18263af3e5ce0dad525c0b063297?pretty=fuller&n=10000)

No logs from failures on Android bot unfortunately :-(... Don't understand why it would have passed CQ and not waterfall but still can't see what else in range could be at fault, sorry..

Original issue's description:
> Delay Input.dispatchKeyEvent response until after key event ack.
>
> BUG= chromedriver:1506 
>
> Review-Url: https://codereview.chromium.org/2387353004

TBR=tdresser@chromium.org,dtapuska@chromium.org,dgozman@chromium.org,pfeldman@chromium.org,samuong@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 673218 ,  chromedriver:1506 

Review-Url: https://codereview.chromium.org/2565313002
Cr-Commit-Position: refs/heads/master@{#437888}

[modify] https://crrev.com/b559a0948b325b01789c01e44ee89719df93feb4/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/b559a0948b325b01789c01e44ee89719df93feb4/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
[modify] https://crrev.com/b559a0948b325b01789c01e44ee89719df93feb4/content/browser/devtools/protocol/input_handler.cc
[modify] https://crrev.com/b559a0948b325b01789c01e44ee89719df93feb4/content/browser/devtools/protocol/input_handler.h
[modify] https://crrev.com/b559a0948b325b01789c01e44ee89719df93feb4/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/b559a0948b325b01789c01e44ee89719df93feb4/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/b559a0948b325b01789c01e44ee89719df93feb4/content/public/browser/render_widget_host.h
[modify] https://crrev.com/b559a0948b325b01789c01e44ee89719df93feb4/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/b559a0948b325b01789c01e44ee89719df93feb4/content/public/test/browser_test_utils.h

Cc: jbudorick@chromium.org
It's still failing, even after the revert of my CL landed: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/38068

A lot of tests fail with:

"junit.framework.AssertionFailedError: ChromeActivity did not start"

+jbudorick, do you know if there are any bot/infra changes that could've caused this?
There's been a lot of turmoil on the swarming side of things lately associated with  issue 672382 . I wouldn't be surprised if this is related to that.
Blockedon: 673433

Comment 5 by yutak@chromium.org, Dec 13 2016

The bot has recovered itself for some reason?
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29
Issue 673338 has been merged into this issue.
Yup, looking quite green now!
Labels: -Sheriff-Chromium
Removing from sheriff queue since it has an owner and it's green now. Leaving to gab@ to confirm it's fine to close.
#5: see the bug that this is blocked on.

Comment 10 by gab@chromium.org, Dec 14 2016

Status: Fixed (was: Started)
Sorry, didn't get to see this land with all the flakes in CQ for revert... bot is green now. Fixed

Sign in to add a comment