New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 673215 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Update payment method url for editing credit card synced via google payments

Project Member Reported by hwi@chromium.org, Dec 12 2016

Issue description

Chrome Version: current
OS: All

What steps will reproduce the problem?
(1) Settings > Autofill  (chrome://settings/autofill)
(2) Select Edit on a 'card' synced via Google Payments

What is the expected result?
Should land on Payment methods (payments.google.com/#paymentMethods)

What happens instead?
Lands on Subscriptions and services



 

Comment 1 by rogerm@chromium.org, Dec 12 2016

Cc: rouslan@chromium.org
Owner: rogerm@chromium.org
Status: Started (was: Untriaged)
+rouslan

What is the "official" formulation of the payment methods URL.

The one currently in use is

  https://wallet.google.com/manage/w/0/paymentMethods

(where the 0 is the multi-login user index).

Which no longer works.

Changing it to either of 

  https://wallet.google.com/manage/w/0#paymentMethods
  https://payments.google.com/#paymentMethods

Both of which redirect to

   https://payments.google.com/payments/u/0/home#paymentMethods

Is there a doc somewhere with the current canonical URL formulation?

That said, doing this fix client-side will take a while to wend its way through the channels to stable, so the more timely step to take is to fix the server-side redirect, which appears to be incorrect.

Who owns that?

Owner: waltercacau@chromium.org
Status: Assigned (was: Started)
Walter, please provide answers to Roger's questions in #c1.
Cc: jsaul@google.com
Adding jsaul@. Jared, could you please confirm the URLs?

Comment 4 by jsaul@google.com, Dec 15 2016

Cc: jstuppy@google.com chak@google.com
Adding jstuppy@ (on original project) and chak@ (most recently fixed the server-side redirect).

1) There's not a doc that I'm aware of.

2) I believe chak@ most recently fixed the redirect server-side; he may be able to make any additional needed tweaks.

Comment 6 by jsaul@google.com, Dec 15 2016

BTW, while doing a code search, I found a similar Android string as well:
https://cs.chromium.org/chromium/src/chrome/android/java/strings/android_chrome_strings.grd?sq=package:chromium&dr=C&l=316

Is this used anywhere + should it be changed as well?  I noticed it doesn't take the /0/ user number into account.

Comment 7 by jsaul@google.com, Dec 15 2016

Owner: rogerm@chromium.org
Assigning back to rogerm@; please see comments 5-6 for the preferred fix.  Thank you!

Comment 8 by jsaul@google.com, Dec 15 2016

Cc: mikeying@google.com

Comment 9 by ma...@chromium.org, Jan 5 2017

I think changing the link sounds good, should we go ahead and do it?

Comment 10 by jsaul@google.com, Jan 5 2017

SGTM, the sooner the better.  rogerm@, are you able to take this, or would you like us to do it?
I also need the sandbox URL.

See:

https://cs.chromium.org/chromium/src/components/autofill/core/browser/payments/payments_service_url.cc?rcl=0&l=27

There's also the question of what to do with the address edit URL, which I think is (intentionally) no longer functional.

See https://cs.chromium.org/chromium/src/components/autofill/core/browser/payments/payments_service_url.cc?rcl=0&l=53

Comment 12 by jsaul@google.com, Jan 5 2017

Thanks Roger!

The sandbox URL should be https://payments.sandbox.google.com/.

As for the address edit URL, you're right in that it no longer functions as it used to.  The paymentMethods is probably the best place to go for now as well, as the addresses synced from Google Payments are the credit card billing addresses.

Comment 14 by jsaul@google.com, Jun 6 2017

Cc: jstuppy@chromium.org
 Issue 616470  has been merged into this issue.
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
Status: Fixed (was: Assigned)

Sign in to add a comment