Update payment method url for editing credit card synced via google payments |
||||||||
Issue descriptionChrome Version: current OS: All What steps will reproduce the problem? (1) Settings > Autofill (chrome://settings/autofill) (2) Select Edit on a 'card' synced via Google Payments What is the expected result? Should land on Payment methods (payments.google.com/#paymentMethods) What happens instead? Lands on Subscriptions and services
,
Dec 12 2016
Walter, please provide answers to Roger's questions in #c1.
,
Dec 15 2016
Adding jsaul@. Jared, could you please confirm the URLs?
,
Dec 15 2016
Adding jstuppy@ (on original project) and chak@ (most recently fixed the server-side redirect). 1) There's not a doc that I'm aware of. 2) I believe chak@ most recently fixed the redirect server-side; he may be able to make any additional needed tweaks.
,
Dec 15 2016
I believe our preferred solution is going to be to update the link in Chrome, from https://wallet.google.com/manage/w/0/paymentMethods to https://payments.google.com/u/0#paymentMethods I believe this takes place in https://cs.chromium.org/chromium/src/components/autofill/core/browser/payments/payments_service_url.cc with unit test in https://cs.chromium.org/chromium/src/components/autofill/core/browser/payments/payments_service_url_unittest.cc
,
Dec 15 2016
BTW, while doing a code search, I found a similar Android string as well: https://cs.chromium.org/chromium/src/chrome/android/java/strings/android_chrome_strings.grd?sq=package:chromium&dr=C&l=316 Is this used anywhere + should it be changed as well? I noticed it doesn't take the /0/ user number into account.
,
Dec 15 2016
Assigning back to rogerm@; please see comments 5-6 for the preferred fix. Thank you!
,
Dec 15 2016
,
Jan 5 2017
I think changing the link sounds good, should we go ahead and do it?
,
Jan 5 2017
SGTM, the sooner the better. rogerm@, are you able to take this, or would you like us to do it?
,
Jan 5 2017
I also need the sandbox URL. See: https://cs.chromium.org/chromium/src/components/autofill/core/browser/payments/payments_service_url.cc?rcl=0&l=27 There's also the question of what to do with the address edit URL, which I think is (intentionally) no longer functional. See https://cs.chromium.org/chromium/src/components/autofill/core/browser/payments/payments_service_url.cc?rcl=0&l=53
,
Jan 5 2017
Thanks Roger! The sandbox URL should be https://payments.sandbox.google.com/. As for the address edit URL, you're right in that it no longer functions as it used to. The paymentMethods is probably the best place to go for now as well, as the addresses synced from Google Payments are the credit card billing addresses.
,
Feb 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd0974677de6c22205d67b301780ac4af863528f commit fd0974677de6c22205d67b301780ac4af863528f Author: rogerm <rogerm@chromium.org> Date: Wed Feb 08 17:27:17 2017 [autofill] Update URL to edit synced Google Payments cards. The URL to edit Google Payments cards has moved from wallet.google.com to payments.google.com. BUG= 673215 R=bauerb@chromium.org, mathp@chromium.org, jsaul@chromium.org Review-Url: https://codereview.chromium.org/2675883005 Cr-Commit-Position: refs/heads/master@{#449022} [modify] https://crrev.com/fd0974677de6c22205d67b301780ac4af863528f/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/fd0974677de6c22205d67b301780ac4af863528f/components/autofill/core/browser/payments/payments_service_url.cc [modify] https://crrev.com/fd0974677de6c22205d67b301780ac4af863528f/components/autofill/core/browser/payments/payments_service_url_unittest.cc
,
Jun 6 2017
,
Jun 27 2017
,
Jul 11
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by rogerm@chromium.org
, Dec 12 2016Owner: rogerm@chromium.org
Status: Started (was: Untriaged)