New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 673211 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

XMLHttpRequest.response should return null on OOM in allocating an ArrayBuffer

Project Member Reported by tyoshino@chromium.org, Dec 12 2016

Issue description

Issue 698142 has been merged into this issue.
Project Member

Comment 2 by sheriffbot@chromium.org, Mar 3 2017

Labels: FoundIn-M-58 Fracas
Users experienced this crash on the following builds:

Win Canary 58.0.3028.0 -  0.42 CPM, 9 reports, 9 clients (signature blink::DOMArrayBuffer::createUninitialized)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 4 2017

Labels: FoundIn-M-59
Users experienced this crash on the following builds:

Win Canary 59.0.3030.0 -  0.40 CPM, 2 reports, 2 clients (signature blink::DOMArrayBuffer::createUninitialized)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Owner: sigbjo...@opera.com
Status: Fixed (was: Available)
bugdroid is either a bit slow or unwilling to update this issue... but addressed via https://codereview.chromium.org/2730943002/

Comment 5 by ajha@chromium.org, Mar 10 2017

Cc: ajha@chromium.org
Labels: -Type-Bug -Pri-3 M-58 Pri-1 Type-Bug-Regression
Status: Assigned (was: Fixed)
Duped Issue 698142 in C#1 has crash instances seen on M-58 branch as well. Fix CL(https://codereview.chromium.org/2730943002/) landed after branch point so the CL needs to be merged to M-58 as well.

sigbjornf@: Could you please get this merged to M-58 as well.

Note: There have been no crashes seen on the last 2 canary(59.0.3036.0 & 59.0.3037.0) as per Issue 698142.


Comment 6 by sigbjo...@opera.com, Mar 10 2017

Labels: -Type-Bug-Regression Type-Bug
This is not addressing a regression in any way, just implementing what the spec now allows us to.

Comment 7 by sigbjo...@opera.com, Mar 13 2017

Labels: Merge-Request-58
Project Member

Comment 8 by sheriffbot@chromium.org, Mar 14 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 14 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bca295bdd893a0217dd4ac32e61eccc08c83ab2

commit 0bca295bdd893a0217dd4ac32e61eccc08c83ab2
Author: Sigbjorn Finne <sigbjornf@opera.com>
Date: Tue Mar 14 12:14:15 2017

XMLHttpRequest: return null upon failing responseArrayBuffer allocation.

The allocation of a response ArrayBuffer may fail, a large enough
contiguous chunk of memory simply not being available from the
underlying allocator. The spec [1] now admits allocation failure as a
possibility, allowing the return of a null buffer if so.

Update our implementation accordingly, returning null rather than
failing hard with an OOM.

1 - https://xhr.spec.whatwg.org/#arraybuffer-response

R=haraken,yhirano
BUG= 673211 

Review-Url: https://codereview.chromium.org/2730943002
Cr-Commit-Position: refs/heads/master@{#455398}
(cherry picked from commit 7c838d986a3d95e81971ef40050fecce0ea2be2c)

Review-Url: https://codereview.chromium.org/2748933003 .
Cr-Commit-Position: refs/branch-heads/3029@{#185}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/0bca295bdd893a0217dd4ac32e61eccc08c83ab2/third_party/WebKit/Source/core/dom/DOMArrayBuffer.cpp
[modify] https://crrev.com/0bca295bdd893a0217dd4ac32e61eccc08c83ab2/third_party/WebKit/Source/core/dom/DOMArrayBuffer.h
[modify] https://crrev.com/0bca295bdd893a0217dd4ac32e61eccc08c83ab2/third_party/WebKit/Source/core/mojo/MojoHandle.cpp
[modify] https://crrev.com/0bca295bdd893a0217dd4ac32e61eccc08c83ab2/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/0bca295bdd893a0217dd4ac32e61eccc08c83ab2/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp
[modify] https://crrev.com/0bca295bdd893a0217dd4ac32e61eccc08c83ab2/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h
[modify] https://crrev.com/0bca295bdd893a0217dd4ac32e61eccc08c83ab2/third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.h

Status: Fixed (was: Assigned)

Sign in to add a comment