camera_characteristics.conf: allow vid/pid to be uppercase |
||||
Issue descriptionIf USB VID/PID are lowercase, they won't be recognized. Let's remove this constraint so it's more convenient for the people who add camera_characteristics.conf. https://codereview.chromium.org/2558483003/
,
Dec 12 2016
Or we can convert it to integers.
,
Jan 10 2017
This one should be quick. Can you fix it soon?
,
Jan 10 2017
,
Jan 10 2017
udevadm only allows lower case. So we need to use lower case to generate 50-camera.rules.
,
Jan 10 2017
,
Jan 10 2017
chromium: https://codereview.chromium.org/2621693003 arc-camera-service: https://chrome-internal-review.googlesource.com/#/c/315915/ eclass: https://chromium-review.googlesource.com/#/c/426559/
,
Jan 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f8e11ba4fa17aa707f9a8a4a70807745faa3f4f commit 1f8e11ba4fa17aa707f9a8a4a70807745faa3f4f Author: henryhsu <henryhsu@chromium.org> Date: Wed Jan 11 06:19:46 2017 Convert camera vid and pid to lower case BUG= 673210 TEST=open camera app and see the vid/pid is converted to lower case in log Review-Url: https://codereview.chromium.org/2621693003 Cr-Commit-Position: refs/heads/master@{#442823} [modify] https://crrev.com/1f8e11ba4fa17aa707f9a8a4a70807745faa3f4f/media/capture/video/linux/camera_facing_chromeos.cc
,
Jan 11 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/project-cheets-private/+/c4b2699c525c61c7c50afa0577e441afb0a56cc6 commit c4b2699c525c61c7c50afa0577e441afb0a56cc6 Author: Heng-Ruey Hsu <henryhsu@chromium.org> Date: Tue Jan 10 09:20:37 2017
,
Jan 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/bca40df4d5f0e23faf42cbdb59b1c41f710af88b commit bca40df4d5f0e23faf42cbdb59b1c41f710af88b Author: Heng-Ruey Hsu <henryhsu@chromium.org> Date: Tue Jan 10 09:27:56 2017 arc-camera: Convert upper case vid and pid to lower case udevadm only allows lower case vid and pid. Use ${var,,} to convert to lower case in Bash 4.0. BUG= chromium:673210 TEST=emerge-${BOARD} chromeos-bsp-${BOARD}-private Change-Id: I1bdea6e91d3837301e426205efcde233308ac6c1 Reviewed-on: https://chromium-review.googlesource.com/426559 Commit-Ready: Heng-ruey Hsu <henryhsu@chromium.org> Tested-by: Heng-ruey Hsu <henryhsu@chromium.org> Reviewed-by: Wu-cheng Li <wuchengli@chromium.org> [modify] https://crrev.com/bca40df4d5f0e23faf42cbdb59b1c41f710af88b/eclass/arc-camera.eclass
,
Jan 12 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by wuchengli@chromium.org
, Dec 12 2016