Paste dialog from long press disappears if finger moves afterwards
Reported by
fancla...@gmail.com,
Dec 12 2016
|
||||
Issue descriptionSteps to reproduce the problem: 1. Launch Chrome app 2. Long press empty area to paste string (Make sure exist string in clipboard) 3. When dialog is showing after user long press, don't release finger and move the finger cause the dialog missing. (You can check the attached video for repo steps.) What is the expected behavior? Paste dialog is keep showing util user touch screen again to cancel dialog. Hope paste dialog behavior in webview is same as EditText behavior. After comparing the difference, the paste dialog from EditText is showing when receiving Action_UP not long press moment from webview. What went wrong? Paste dialog from long press is missing when user long press and move finger in the same time. Did this work before? No Chrome version: 54.0.2840.85 Channel: n/a OS Version: Android N 7.0 Flash Version: Shockwave Flash 23.0 r0 Please check the video for the behavior difference in paste dialog from Webview and EditText. The time to show dialog is different. Show dialog when getting Action_UP from user is the behavior we expected.
,
Dec 14 2016
,
Dec 14 2016
I can repro. I'm guessing this might be code for selection-drag activating in this Paste case where it doesn't make sense.
,
Dec 14 2016
The menu is being cleared because |ContentViewCore.onScrollBeginEventAck()| is being called which clears the menu. Maybe the fix is to have the Paste menu act like the Copy/Cut/Paste floating menu and move according to the scroll.
,
Dec 14 2016
The menu is cleared even when the page is not scrollable. Perhaps we could clear it on scroll update instead of scroll begin at least?
,
Dec 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99f54b1704faa5413d106b23a64a434368ea9628 commit 99f54b1704faa5413d106b23a64a434368ea9628 Author: amaralp <amaralp@chromium.org> Date: Thu Dec 15 01:35:04 2016 Moving hiding of paste menu from scroll start to scroll update Previously we were hiding the paste menu even when the page didn't scroll at all. Moving the hiding to update ensures that the menu is only cleared if we actually scrolled. BUG= 673209 Review-Url: https://codereview.chromium.org/2580583002 Cr-Commit-Position: refs/heads/master@{#438708} [modify] https://crrev.com/99f54b1704faa5413d106b23a64a434368ea9628/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
,
Dec 15 2016
,
Dec 15 2016
Thanks for quickly reply and solution.
,
Jan 3 2017
Hi Owner, Can you share the release plan of Chrome which include this fix? Thanks.
,
Jan 3 2017
The fix is in M57 which is scheduled for release on Stable on March 14th. |
||||
►
Sign in to add a comment |
||||
Comment 1 by rsgav...@chromium.org
, Dec 14 2016Status: Assigned (was: Unconfirmed)