Issue metadata
Sign in to add a comment
|
Reduce the amount of logging we're doing in webkit_tests and archive_webkit_tests. |
||||||||||||||||||||||
Issue descriptionThis is split off from bug 669297. It looks like the logs we generate when we run the layout tests are now a very significant percentage of the total logs of a build. The steps have always been quite verbose, but it's possible that things are even worse now due to the greater number of tests that we're running and perhaps due to an unmonitored increase in the amount of stderr messages. We should make the logs much less verbose and see if that helps reduce the total load on the master.
,
Dec 12 2016
@qyearsley - can you land changes ASAP to add the `-q` to gsutil and comment out the "started" message ?
,
Dec 12 2016
,
Dec 12 2016
Sounds, good, will do now.
,
Dec 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/38f69a78a8cfdd45460ebbaa3c97f4f6d3c13296 commit 38f69a78a8cfdd45460ebbaa3c97f4f6d3c13296 Author: Quinten Yearsley <qyearsley@google.com> Date: Mon Dec 12 18:54:55 2016 When archiving layout test results, invoke gsutil with quiet flag. BUG= 673207 Change-Id: I7c12aff507c8df0cca2d098b51af1375df2b2c0f Reviewed-on: https://chromium-review.googlesource.com/419058 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> [modify] https://crrev.com/38f69a78a8cfdd45460ebbaa3c97f4f6d3c13296/scripts/slave/chromium/archive_layout_test_results.py [modify] https://crrev.com/38f69a78a8cfdd45460ebbaa3c97f4f6d3c13296/scripts/slave/slave_utils.py [modify] https://crrev.com/38f69a78a8cfdd45460ebbaa3c97f4f6d3c13296/scripts/slave/unittests/slave_utils_test.py
,
Dec 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67aaccae4c80bb66c0a623a6e3e56b8151d6e3eb commit 67aaccae4c80bb66c0a623a6e3e56b8151d6e3eb Author: qyearsley <qyearsley@chromium.org> Date: Mon Dec 12 21:51:11 2016 Stop logging the start of a run for individual layout tests. NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true BUG= 673207 Review-Url: https://codereview.chromium.org/2564343003 Cr-Commit-Position: refs/heads/master@{#437924} [modify] https://crrev.com/67aaccae4c80bb66c0a623a6e3e56b8151d6e3eb/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py
,
Dec 20 2016
Is log size still an issue? (Is there a target log size?) If so, one possible next thing to try would be to truncate or silence most error messages when running layout tests by default.
,
Dec 20 2016
I think we can at least downgrade this, but there's still probably room for improvement. In particular, I'd like to know how there are 14k lines that aren't starting with "worker/N" ... something seems badly wrong there.
,
Dec 27 2016
The volume of stderr messages has probably been slowly increasing over time; see bug 375415 . [Unassigning for now since I don't have any immediate plans to resolve this.]
,
Jan 16 2017
Closing this; the main issues that I cared about were addressed. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by qyears...@chromium.org
, Dec 12 2016