New issue
Advanced search Search tips

Issue 673207 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2016-12-20
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 669297



Sign in to add a comment

Reduce the amount of logging we're doing in webkit_tests and archive_webkit_tests.

Project Member Reported by dpranke@chromium.org, Dec 12 2016

Issue description

This is split off from bug 669297.

It looks like the logs we generate when we run the layout tests are now a very significant percentage of the total logs of a build. The steps have always been quite verbose, but it's possible that things are even worse now due to the greater number of tests that we're running and perhaps due to an unmonitored increase in the amount of stderr messages.

We should make the logs much less verbose and see if that helps reduce the total load on the master.
 
Quickly taking a look at one example log (https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/27658/steps/webkit_tests/logs/stdio):

Total line count: 112143, total size: 11M.

It seems like there are two categories of things that can be reduced: stderr messages and regular logging during normal operation. Most regular lines start with "worker/n ..."; for each test there's a "started" message and end message (passed, failed...).

Lines starting with worker/n: 98499, total size: 8.6M.

There are a lot of error messages that could be cut down, but the easiest single thing that could be cut may be the " started" messages (which take 47725 lines, 4.2M). How useful are those lines?


The archive_webkit_test_results log is about 21768 lines, 2.3M, most of it consisting of listing individual files that are being uploaded. There is a "-q" (quiet) flag for gsutil, so adding that would be the quickest easiest change. Although, of course, we have the separate problem that archiving is slow because we archive too much;  bug 310382 .
Owner: qyears...@chromium.org
@qyearsley - can you land changes ASAP to add the `-q` to gsutil and comment out the "started" message ?
Labels: -Pri-1 Pri-0
Labels: -OS-All
Status: Started (was: Assigned)
Sounds, good, will do now.
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67aaccae4c80bb66c0a623a6e3e56b8151d6e3eb

commit 67aaccae4c80bb66c0a623a6e3e56b8151d6e3eb
Author: qyearsley <qyearsley@chromium.org>
Date: Mon Dec 12 21:51:11 2016

Stop logging the start of a run for individual layout tests.

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
BUG= 673207 

Review-Url: https://codereview.chromium.org/2564343003
Cr-Commit-Position: refs/heads/master@{#437924}

[modify] https://crrev.com/67aaccae4c80bb66c0a623a6e3e56b8151d6e3eb/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py

Labels: -Pri-0 Pri-1
NextAction: 2016-12-20
Is log size still an issue? (Is there a target log size?) If so, one possible next thing to try would be to truncate or silence most error messages when running layout tests by default.
Labels: -Pri-1 Pri-3
I think we can at least downgrade this, but there's still probably room for improvement. In particular, I'd like to know how there are 14k lines that aren't starting with "worker/N" ... something seems badly wrong there.
Cc: -qyears...@chromium.org
Owner: ----
Status: Available (was: Started)
Summary: Reduce the amount of logging we're doing in webkit_tests and archive_webkit_tests. (was: reduce the amount of logging we're doing in webkit_tests and archive_webkit_tests)
The volume of stderr messages has probably been slowly increasing over time; see  bug 375415 .

[Unassigning for now since I don't have any immediate plans to resolve this.]
Status: Fixed (was: Available)
Closing this; the main issues that I cared about were addressed.

Sign in to add a comment