Issue metadata
Sign in to add a comment
|
Screen magnifier moves focus to the caret when an irrelevant window has moved. |
||||||||||||||||||||||||
Issue descriptionChrome Version: 57.0.2949.0 OS: ChromeOS 9049.0 What steps will reproduce the problem? (1) Enable "Screen Magnifier" in the accessibility settings. (2) Focus the ombibox of a Chrome browser window. (3) Move the mouse cursor, click the task tray (the clock ~ profile icon) to show the menu. What is the expected result? The menu opens and shows up. What happens instead? The menu opens and shows up, and the magnified screen moves back to the omnibox, putting the opened menu out of display. The bug is more visible when ARC apps are in use (b/33491318), where the mouse cursor surface generated inside Android is represented as an aura window, so all mouse movement over an ARC window triggers magnifer refocusing.
,
Dec 12 2016
,
Dec 13 2016
,
Dec 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0105686d120fe7978122cf399061c738de15134 commit c0105686d120fe7978122cf399061c738de15134 Author: kinaba <kinaba@chromium.org> Date: Wed Dec 14 00:04:52 2016 Ash magnifier: Check whether the caret bounds were actually moved or not. If the caret bounds were not actually moved, do not move the magnification window. Otherwise it causes unnecessary move of focuses. BUG= 673200 TEST=MagnificationControllerTest Review-Url: https://codereview.chromium.org/2562273002 Cr-Commit-Position: refs/heads/master@{#438347} [modify] https://crrev.com/c0105686d120fe7978122cf399061c738de15134/ash/magnifier/magnification_controller.cc
,
Dec 14 2016
Fixed on trunk. After waiting for the canary image, I'll start request merging.
,
Dec 15 2016
,
Dec 15 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8221d1bf74e1b1951322795f93b1fc93a62044e commit c8221d1bf74e1b1951322795f93b1fc93a62044e Author: Kazuhiro Inaba <kinaba@chromium.org> Date: Thu Dec 15 04:02:10 2016 Ash magnifier: Check whether the caret bounds were actually moved or not. If the caret bounds were not actually moved, do not move the magnification window. Otherwise it causes unnecessary move of focuses. BUG= 673200 TEST=MagnificationControllerTest Review-Url: https://codereview.chromium.org/2562273002 Cr-Commit-Position: refs/heads/master@{#438347} (cherry picked from commit c0105686d120fe7978122cf399061c738de15134) Review-Url: https://codereview.chromium.org/2572413002 . Cr-Commit-Position: refs/branch-heads/2924@{#507} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/c8221d1bf74e1b1951322795f93b1fc93a62044e/ash/magnifier/magnification_controller.cc
,
Dec 15 2016
Requesting M55 merge too. The bug makes the accessibility feature (screen magnifier) almost unusable for ARC apps and is leading to a very bad UX for people relying on the feature, while the fix https://codereview.chromium.org/2562273002 is simple and safe.
,
Dec 15 2016
,
Dec 15 2016
,
Dec 16 2016
[Automated comment] Request affecting a post-stable build (M55), manual review required.
,
Jan 10 2017
ping: TPM.
,
Jan 10 2017
Sorry for not seeing this earlier, we can land this, however we don't plan on any further 55 pushes, 56 goes stable at the end of the month though.
,
Jan 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de251a2ef1fefabae9a14ec520a5ca2c1aafe6d8 commit de251a2ef1fefabae9a14ec520a5ca2c1aafe6d8 Author: Kazuhiro Inaba <kinaba@chromium.org> Date: Tue Jan 10 01:51:41 2017 Ash magnifier: Check whether the caret bounds were actually moved or not. If the caret bounds were not actually moved, do not move the magnification window. Otherwise it causes unnecessary move of focuses. BUG= 673200 TEST=MagnificationControllerTest Review-Url: https://codereview.chromium.org/2562273002 Cr-Commit-Position: refs/heads/master@{#438347} (cherry picked from commit c0105686d120fe7978122cf399061c738de15134) Review-Url: https://codereview.chromium.org/2623773002 . Cr-Commit-Position: refs/branch-heads/2883@{#755} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/de251a2ef1fefabae9a14ec520a5ca2c1aafe6d8/ash/magnifier/magnification_controller.cc
,
Jan 10 2017
Thanks. Did the merge only just in case, then.
,
Mar 31 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by kinaba@chromium.org
, Dec 12 2016