MacViews: browser crashes when drag and drop a bookmark item to a folder in bookmark bar
Reported by
cona...@gmail.com,
Dec 12 2016
|
||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2947.0 Safari/537.36 Steps to reproduce the problem: 1. build a chromium with mac_views_browser=true option 2. make a bookmark item, a bookmark folder in bookmark bar 3. drag a bookmark item and drop it in a bookmark folder What is the expected behavior? The bookmark item should be moved to the bookmark folder without crash What went wrong? The browser crashed Crashed report ID: c41c1303-60cb-4d1b-b394-aa3bac36b166 How much crashed? Whole browser Is it a problem with a plugin? No Did this work before? N/A Chrome version: 57.0.2947.0 Channel: n/a OS Version: OS X 10.11.6 Flash Version: It can be reproduced on every try.
,
Dec 12 2016
Thanks for the crash report!
,
Dec 12 2016
mac_views_browser=true is not ready for prime-time yet. Could you attach a stack trace? Crash reports from local builds are meaningless since we don't have symbols.
,
Dec 12 2016
I think this is the fix: https://codereview.chromium.org/2572473004 It needs a test though. And it has some other weird behaviour: it "copies" the bookmark rather than moving it.
,
Dec 13 2016
I can look into this
,
Feb 13 2017
,
Apr 12 2017
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67304cbdc43b4913e000fb59e7d18749457483f7 commit 67304cbdc43b4913e000fb59e7d18749457483f7 Author: jongkwon.lee <jongkwon.lee@navercorp.com> Date: Wed Sep 13 07:45:11 2017 Fix crash on bookmark drag and drop When the menu Widget closed on drop of bookmark, the attempt to reset |data_source_| in DragDropClientMac::Drop() caused crash because the DragDropClientMac is deleted along with the Widget in the |drop_helper_.OnDrop()|. So, clear |data_source_| before calling |drop_helper_.OnDrop()|. Beside the crash issue, there was another issue that custom types of ui::OSExchangeData items are not copyed into NSPasteboardItem used in the dragging session. This is because the types set for NSPasteboardItem does not contain the custom types such as bookmark. So, instead of using SupportedPasteboardTypes() for NSPasteboardItem, use OSExchangeDataProviderMac::GetAvailableTypes() to include any custom types contained in the ui::OSExchangeData items. Bug: 673192 Change-Id: Ib98cca2058c4898a17db7bfced97264fbc653e14 Reviewed-on: https://chromium-review.googlesource.com/648886 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#501565} [modify] https://crrev.com/67304cbdc43b4913e000fb59e7d18749457483f7/ui/base/dragdrop/os_exchange_data_provider_mac.h [modify] https://crrev.com/67304cbdc43b4913e000fb59e7d18749457483f7/ui/base/dragdrop/os_exchange_data_provider_mac.mm [modify] https://crrev.com/67304cbdc43b4913e000fb59e7d18749457483f7/ui/views/cocoa/bridged_content_view.mm [modify] https://crrev.com/67304cbdc43b4913e000fb59e7d18749457483f7/ui/views/cocoa/drag_drop_client_mac.h [modify] https://crrev.com/67304cbdc43b4913e000fb59e7d18749457483f7/ui/views/cocoa/drag_drop_client_mac.mm [modify] https://crrev.com/67304cbdc43b4913e000fb59e7d18749457483f7/ui/views/cocoa/drag_drop_client_mac_unittest.mm
,
Sep 13 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by nyerramilli@chromium.org
, Dec 12 2016Labels: M-57