New issue
Advanced search Search tips

Issue 673189 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
japhet@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove quadratic behavior from ProgressTracker::maybeSendProgress

Project Member Reported by csharrison@chromium.org, Dec 12 2016 
incrementProgress and completeProgress end up iterating through all the progress items. This can result in O(n^2) behavior with n progress items, which has been showing up in per-resource profiles.

We should avoid this iteration and cache the total bytes / estimated bytes.

http://cr.kungfoo.net/loading/1000spacers/ is a good workload for seeing this behavior. According to a Linux perf profile, maybeSendProgress accounts for ~10% of the CPU load of per-request time for that site.

Comment 1 by csharrison@chromium.org, Dec 12 2016 

Oh, I'll note that this 10% behavior occurs when reloading the page, so the images come loaded from memory cache.

Comment 2 by yhirano@chromium.org, Feb 14 2017

Status: Available (was: Untriaged)
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 16 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by csharrison@chromium.org, Mar 29 2018

Status: Available (was: Untriaged)
►

Sign in to add a comment