New issue
Advanced search Search tips

Issue 673171 link

Starred by 1 user
Status: Fixed
Owner:
thakis@chromium.org
Closed: Sep 2017
Cc:
dcheng@chromium.org
thakis@chromium.org
sdefresne@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocked on:
issue 84424
issue 760615


Sign in to add a comment

Make Wdelete-non-virtual-dtor work with unique_ptr

Project Member Reported by sdefresne@chromium.org, Dec 11 2016 
See https://bugs.chromium.org/p/chromium/issues/detail?id=673169.

We should get a warning when we try to delete an instance from a class with virtual methods that does not have a virtual destructor (-Wdelete-non-virtual-dtor) or if it is not possible with std::unique_ptr, maybe we should warn about classes with virtual methods and no virtual destructor (-Wnon-virtual-dtor). This is stricter but will avoid the same class of errors.

Reference https://llvm.org/bugs/show_bug.cgi?id=28460

Comment 1 by sdefresne@chromium.org, Dec 11 2016

Cc: sdefresne@chromium.org

Comment 2 by thakis@chromium.org, Dec 11 2016

Summary: Make Wdelete-non-virtual-dtor work with unique_ptr (was: Warn about deleting instance from class with virtual methods but no virtual destructor)
Retitled. The second behavior you describe is how the existing warning works in gcc, and it's way too noisy in practice. The llvm bug describes what we should do. (Guess it doesn't hurt to have a bug over here as well.)

Comment 3 by thakis@chromium.org, Aug 29 2017

Blockedon: 84424
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/564d3506079c2005fd646959ad61e5b65e01173e

commit 564d3506079c2005fd646959ad61e5b65e01173e
Author: Nico Weber <thakis@chromium.org>
Date: Wed Aug 30 20:14:15 2017

Fix some -Wdelete-non-virtual-dtor warnings.

The warning was kind-of-disabled but https://reviews.llvm.org/D37235
is bringing it back, so we need to clean up our code again.

This fixes several (likely benign) bugs where we used to not call the dtors
of subclasses because we deleted them through a pointer to their superclass
without the superclass having a virtual dtor.

The warning fires on `delete var` if the type of var has virtual methods
(suggesting it can be subclasses, and var can in theory point to a subclass)
but it has no virtual destructor (meaning the subclass's destructor won't be
called).

There are several possible fixes:
* If the type only has virtual methods because it itself overrides a few
  methods (due to it implementing some interface) but it's not supposed to
  be subclassed, just mark the class final. That fixes the warning without
  a behavior change.
* If the type really has subclasses, give it a virtual dtor, so that subclass
  dtors are called correctly.

Bug:  673171 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I80a8c19bd85fe814d9905f0b7c94f02027a5372b
Reviewed-on: https://chromium-review.googlesource.com/639732
Reviewed-by: Jian Li <jianli@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498586}
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/base/run_loop_unittest.cc
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/base/task_scheduler/task_tracker.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/base/task_scheduler/task_tracker_posix.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/chrome/browser/extensions/api/tab_capture/offscreen_tab.cc
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/chrome/browser/extensions/api/tab_capture/offscreen_tab.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/chrome/browser/predictors/glowplug_key_value_table.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/chrome/browser/push_messaging/push_messaging_service_observer.cc
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/chrome/browser/push_messaging/push_messaging_service_observer.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/chrome/browser/resource_coordinator/tab_manager.cc
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/chrome/browser/resource_coordinator/tab_manager_stats_collector.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/chrome/browser/ui/sync/one_click_signin_sync_starter.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/chrome/browser/ui/sync/profile_signin_confirmation_helper.cc
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/chrome/browser/ui/sync/profile_signin_confirmation_helper.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views_browsertest.cc
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/components/autofill/core/browser/payments/full_card_request.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/components/cryptauth/ble/bluetooth_low_energy_weave_client_connection.cc
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/components/cryptauth/ble/bluetooth_low_energy_weave_client_connection.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/components/cryptauth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/components/cryptauth/ble/bluetooth_low_energy_weave_packet_receiver.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/components/cryptauth/remote_device_provider_unittest.cc
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/components/cryptauth/secure_channel_unittest.cc
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/components/metrics/data_use_tracker.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/components/ntp_snippets/fake_content_suggestions_provider_observer.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/components/ntp_snippets/remote/remote_suggestions_scheduler_impl.cc
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/components/offline_pages/core/renovations/page_renovation.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/components/safe_browsing/triggers/trigger_manager.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/components/viz/service/hit_test/hit_test_aggregator_unittest.cc
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/components/viz/service/surfaces/surface.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/content/browser/dom_storage/local_storage_context_mojo.cc
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/content/browser/loader/upload_progress_tracker.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/content/renderer/BUILD.gn
[add] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/content/renderer/layout_test_dependencies.cc
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/content/renderer/layout_test_dependencies.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/content/renderer/mojo/blink_interface_provider_impl.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/content/renderer/mojo/blink_interface_registry_impl.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/media/remoting/courier_renderer_unittest.cc
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/media/renderers/renderer_impl.cc
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/media/video/half_float_maker.cc
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/media/video/half_float_maker.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/services/device/public/cpp/generic_sensor/platform_sensor_configuration.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerInstalledScriptsManager.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/third_party/WebKit/Source/platform/audio/PushPullFIFOMultithreadTest.cpp
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/third_party/WebKit/Source/platform/blob/BlobDataTest.cpp
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/third_party/WebKit/Source/platform/exported/WebSurfaceLayerBridge.cpp
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/third_party/WebKit/Source/platform/graphics/SurfaceLayerBridge.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl_unittest.cc
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/third_party/WebKit/Source/platform/wtf/FunctionalTest.cpp
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/third_party/WebKit/public/platform/WebSurfaceLayerBridge.h
[modify] https://crrev.com/564d3506079c2005fd646959ad61e5b65e01173e/ui/base/class_property_unittest.cc

Comment 5 by thakis@chromium.org, Aug 30 2017

Blockedon: 760615
Status: Started (was: Untriaged)
Needs clang roll for http://llvm.org/viewvc/llvm-project?view=revision&revision=312167
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7105d53008b8eaa2c43fe766f72707532974c1cd

commit 7105d53008b8eaa2c43fe766f72707532974c1cd
Author: Nico Weber <thakis@chromium.org>
Date: Thu Aug 31 20:04:33 2017

Fix one -Wdelete-non-virtual-dtor warning on Mac.

Bug:  673171 
Change-Id: I20d9537190bb05a182e9ca55be96956336a5a782
Reviewed-on: https://chromium-review.googlesource.com/646596
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498963}
[modify] https://crrev.com/7105d53008b8eaa2c43fe766f72707532974c1cd/chrome/browser/ui/cocoa/fullscreen_low_power_coordinator.h
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76fdda166f1878ad1b8442a79945f17c288feb81

commit 76fdda166f1878ad1b8442a79945f17c288feb81
Author: Nico Weber <thakis@chromium.org>
Date: Thu Aug 31 20:13:26 2017

Fix some -Wdelete-non-virtual-dtor warnings on Windows.

Like https://chromium-review.googlesource.com/c/chromium/src/+/639732
but in a Windows build instead of in a Linux build.

TBR=siggi

Bug:  673171 
Change-Id: I0966683235d7dcf1fc0ff8119a4f1b5b07be31e7
Reviewed-on: https://chromium-review.googlesource.com/646648
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498970}
[modify] https://crrev.com/76fdda166f1878ad1b8442a79945f17c288feb81/components/browser_watcher/postmortem_report_collector_unittest.cc
[modify] https://crrev.com/76fdda166f1878ad1b8442a79945f17c288feb81/ui/display/win/screen_win_unittest.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5b502393c4931e2cb0242f58ff7ec85fb999296

commit f5b502393c4931e2cb0242f58ff7ec85fb999296
Author: Nico Weber <thakis@chromium.org>
Date: Thu Aug 31 21:37:11 2017

Fix some -Wdelete-non-virtual-dtor warnings on Android.

Like https://chromium-review.googlesource.com/c/chromium/src/+/639732
but in an Android build instead of in a Linux build.

In media/, the missing virtual on a mock meant that the mock expectations
weren't checked, so update them.

Bug:  673171 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I21a53d718ba3b5df0904c8a3601e1fb116d08b03
Reviewed-on: https://chromium-review.googlesource.com/644886
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Anton Vayvod <avayvod@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499010}
[modify] https://crrev.com/f5b502393c4931e2cb0242f58ff7ec85fb999296/android_webview/browser/aw_permission_manager_unittest.cc
[modify] https://crrev.com/f5b502393c4931e2cb0242f58ff7ec85fb999296/chrome/browser/android/contextualsearch/contextual_search_field_trial.h
[modify] https://crrev.com/f5b502393c4931e2cb0242f58ff7ec85fb999296/chrome/browser/android/history_report/delta_file_service.h
[modify] https://crrev.com/f5b502393c4931e2cb0242f58ff7ec85fb999296/chrome/browser/android/history_report/usage_reports_buffer_service.h
[modify] https://crrev.com/f5b502393c4931e2cb0242f58ff7ec85fb999296/chrome/browser/android/search_geolocation/search_geolocation_service.h
[modify] https://crrev.com/f5b502393c4931e2cb0242f58ff7ec85fb999296/chrome/browser/media/android/router/media_router_android_bridge.h
[modify] https://crrev.com/f5b502393c4931e2cb0242f58ff7ec85fb999296/chrome/browser/media/android/router/media_router_android_unittest.cc
[modify] https://crrev.com/f5b502393c4931e2cb0242f58ff7ec85fb999296/components/variations/service/variations_field_trial_creator.h
[modify] https://crrev.com/f5b502393c4931e2cb0242f58ff7ec85fb999296/components/variations/service/variations_field_trial_creator_unittest.cc
[modify] https://crrev.com/f5b502393c4931e2cb0242f58ff7ec85fb999296/content/browser/media/android/browser_surface_view_manager.h
[modify] https://crrev.com/f5b502393c4931e2cb0242f58ff7ec85fb999296/media/gpu/android/mock_device_info.h
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5d3d21434575bd221f007057e0ecd5d964cc776

commit a5d3d21434575bd221f007057e0ecd5d964cc776
Author: Nico Weber <thakis@chromium.org>
Date: Fri Sep 01 05:43:43 2017

android: Fix a straggler -Wdelete-non-virtual-dtor warning.

Follow-up to https://chromium-review.googlesource.com/644886
The new regression was added in https://codereview.chromium.org/2884423003

TBR=hans

Bug:  673171 
Change-Id: I792ef68cd87bf2c4b9ebb1feea4837c745940a19
Reviewed-on: https://chromium-review.googlesource.com/646295
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499139}
[modify] https://crrev.com/a5d3d21434575bd221f007057e0ecd5d964cc776/ui/android/overscroll_glow.h
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/833612fe9a0827ef31750e72126d3431e585bfb8

commit 833612fe9a0827ef31750e72126d3431e585bfb8
Author: Nico Weber <thakis@chromium.org>
Date: Fri Sep 01 05:44:00 2017

win: Fix a -Wdelete-non-virtual-dtor warning.

TBR=hans

Bug:  673171 
Change-Id: Ida5e375d4bb4b56cb4a4b19751d08a09edebc50b
Reviewed-on: https://chromium-review.googlesource.com/646453
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499140}
[modify] https://crrev.com/833612fe9a0827ef31750e72126d3431e585bfb8/chrome/browser/conflicts/msi_util_win.h
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07c14f0f3ff915af330aef3092420ece3430d266

commit 07c14f0f3ff915af330aef3092420ece3430d266
Author: Nico Weber <thakis@chromium.org>
Date: Fri Sep 01 06:39:41 2017

Fix one -Wdelete-non-virtual-dtor warning on iOS.

TBR=rohitrao@chromium.org

Bug:  673171 
Change-Id: I34e6a404c71999d29a411eeaae9fd39882c90970
Reviewed-on: https://chromium-review.googlesource.com/647226
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499145}
[modify] https://crrev.com/07c14f0f3ff915af330aef3092420ece3430d266/ios/chrome/browser/payments/ios_payment_instrument_finder_unittest.mm
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/195411ee5a20ed1076240472fed72fdb75349455

commit 195411ee5a20ed1076240472fed72fdb75349455
Author: Nico Weber <thakis@chromium.org>
Date: Fri Sep 01 09:49:30 2017

android: Fix another straggler -Wdelete-non-virtual-dtor warning.

Follow-up to https://chromium-review.googlesource.com/644886
The new regression was also added in https://codereview.chromium.org/2884423003

TBR=hans

Bug:  673171 
Change-Id: I351791a499f1f408f9ee385074b072be2f53163b
Reviewed-on: https://chromium-review.googlesource.com/647227
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499160}
[modify] https://crrev.com/195411ee5a20ed1076240472fed72fdb75349455/ui/android/overscroll_refresh.h
Project Member

Comment 14 by bugdroid1@chromium.org, Sep 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4bee15ad714c69e48d98ae36638376f58eba8b9

commit c4bee15ad714c69e48d98ae36638376f58eba8b9
Author: Nico Weber <thakis@chromium.org>
Date: Fri Sep 01 17:43:12 2017

Fix some more -Wdelete-non-virtual-dtor warnings on iOS.

Bug:  673171 
Change-Id: I25e05829fdb54412e681bc6a58171117644be819
Reviewed-on: https://chromium-review.googlesource.com/647989
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499228}
[modify] https://crrev.com/c4bee15ad714c69e48d98ae36638376f58eba8b9/components/payments/core/payments_profile_comparator.h
[modify] https://crrev.com/c4bee15ad714c69e48d98ae36638376f58eba8b9/ios/chrome/browser/ui/dialogs/java_script_dialog_presenter_impl.h
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b56f9861a1980af23972b2e60b80ff701939cc2

commit 5b56f9861a1980af23972b2e60b80ff701939cc2
Author: Hans Wennborg <hans@chromium.org>
Date: Sat Sep 02 19:35:27 2017

Fix another -Wdelete-non-virtual-dtor warning on iOS.

Hopefully this is the last one. I did a full debug build locally.

TBR=sdefresne

Bug:  673171 
Change-Id: I59e60e80b6ba5e269550abdd578831986df639f1
Reviewed-on: https://chromium-review.googlesource.com/647654
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499403}
[modify] https://crrev.com/5b56f9861a1980af23972b2e60b80ff701939cc2/ios/web_view/internal/web_view_java_script_dialog_presenter.h
Project Member

Comment 16 by bugdroid1@chromium.org, Sep 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af90ff1d0f68fc54ba786e37583912bedfc7818c

commit af90ff1d0f68fc54ba786e37583912bedfc7818c
Author: Hans Wennborg <hans@chromium.org>
Date: Mon Sep 04 19:46:02 2017

Fix -Wdelete-non-virtual-dtor warnings on CrOS.

TBR=achuith

Bug:  673171 
Change-Id: I0cca8ff7c201ff05dcf7bd09ef1a14a7c896e974
Reviewed-on: https://chromium-review.googlesource.com/648606
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499527}
[modify] https://crrev.com/af90ff1d0f68fc54ba786e37583912bedfc7818c/chrome/browser/chromeos/accessibility/select_to_speak_event_handler_unittest.cc
[modify] https://crrev.com/af90ff1d0f68fc54ba786e37583912bedfc7818c/chrome/browser/chromeos/policy/device_cloud_policy_initializer.h
[modify] https://crrev.com/af90ff1d0f68fc54ba786e37583912bedfc7818c/chrome/browser/chromeos/tether/tether_service_unittest.cc
[modify] https://crrev.com/af90ff1d0f68fc54ba786e37583912bedfc7818c/chromeos/components/tether/active_host_network_state_updater.h
[modify] https://crrev.com/af90ff1d0f68fc54ba786e37583912bedfc7818c/chromeos/components/tether/active_host_unittest.cc
[modify] https://crrev.com/af90ff1d0f68fc54ba786e37583912bedfc7818c/chromeos/components/tether/ble_connection_manager.h
[modify] https://crrev.com/af90ff1d0f68fc54ba786e37583912bedfc7818c/chromeos/components/tether/ble_connection_manager_unittest.cc
[modify] https://crrev.com/af90ff1d0f68fc54ba786e37583912bedfc7818c/chromeos/components/tether/ble_scanner_unittest.cc
[modify] https://crrev.com/af90ff1d0f68fc54ba786e37583912bedfc7818c/chromeos/components/tether/connect_tethering_operation_unittest.cc
[modify] https://crrev.com/af90ff1d0f68fc54ba786e37583912bedfc7818c/chromeos/components/tether/disconnect_tethering_operation_unittest.cc
[modify] https://crrev.com/af90ff1d0f68fc54ba786e37583912bedfc7818c/chromeos/components/tether/host_scan_cache_unittest.cc
[modify] https://crrev.com/af90ff1d0f68fc54ba786e37583912bedfc7818c/chromeos/components/tether/host_scanner_operation_unittest.cc
[modify] https://crrev.com/af90ff1d0f68fc54ba786e37583912bedfc7818c/chromeos/components/tether/host_scanner_unittest.cc
[modify] https://crrev.com/af90ff1d0f68fc54ba786e37583912bedfc7818c/chromeos/components/tether/keep_alive_operation_unittest.cc
[modify] https://crrev.com/af90ff1d0f68fc54ba786e37583912bedfc7818c/chromeos/components/tether/keep_alive_scheduler_unittest.cc
[modify] https://crrev.com/af90ff1d0f68fc54ba786e37583912bedfc7818c/chromeos/components/tether/tether_host_fetcher_unittest.cc
[modify] https://crrev.com/af90ff1d0f68fc54ba786e37583912bedfc7818c/chromeos/components/tether/tether_host_response_recorder_unittest.cc
[modify] https://crrev.com/af90ff1d0f68fc54ba786e37583912bedfc7818c/chromeos/network/network_configuration_handler_unittest.cc
[modify] https://crrev.com/af90ff1d0f68fc54ba786e37583912bedfc7818c/chromeos/network/network_state_handler_unittest.cc
[modify] https://crrev.com/af90ff1d0f68fc54ba786e37583912bedfc7818c/components/exo/data_offer.h
[modify] https://crrev.com/af90ff1d0f68fc54ba786e37583912bedfc7818c/components/exo/surface.h
[modify] https://crrev.com/af90ff1d0f68fc54ba786e37583912bedfc7818c/components/exo/wayland/server.cc
[modify] https://crrev.com/af90ff1d0f68fc54ba786e37583912bedfc7818c/components/policy/core/common/cloud/mock_signing_service.h
[modify] https://crrev.com/af90ff1d0f68fc54ba786e37583912bedfc7818c/components/policy/core/common/cloud/signing_service.h
[modify] https://crrev.com/af90ff1d0f68fc54ba786e37583912bedfc7818c/ui/arc/notification/arc_notification_content_view_delegate.h
Project Member

Comment 17 by bugdroid1@chromium.org, Sep 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21936284da46d71f0896e8a1a4e28a5969baa307

commit 21936284da46d71f0896e8a1a4e28a5969baa307
Author: Hans Wennborg <hans@chromium.org>
Date: Thu Sep 07 22:04:54 2017

Fix another -Wdelete-non-virtual-dtor warning

TBR=vabr

Bug:  673171 
Change-Id: Icf9f8eb12fbab8ada82665f82c9485520c518738
Reviewed-on: https://chromium-review.googlesource.com/656085
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500406}
[modify] https://crrev.com/21936284da46d71f0896e8a1a4e28a5969baa307/components/prefs/pref_change_registrar.h
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7e9e8e9ff76b10049eff947fb787899b2d63616

commit c7e9e8e9ff76b10049eff947fb787899b2d63616
Author: Hans Wennborg <hans@chromium.org>
Date: Thu Sep 07 22:38:29 2017

Fix another -Wdelete-non-virtual-dtor warning

TBR=thakis

Bug:  673171 
Change-Id: I89365967a1febae7d16c836715600db91e4d558b
Reviewed-on: https://chromium-review.googlesource.com/656338
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500415}
[modify] https://crrev.com/c7e9e8e9ff76b10049eff947fb787899b2d63616/chrome/browser/banners/app_banner_manager.h
Project Member

Comment 19 by bugdroid1@chromium.org, Sep 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2385249c97edb9e910fab75a101a71997937f425

commit 2385249c97edb9e910fab75a101a71997937f425
Author: Hans Wennborg <hans@chromium.org>
Date: Fri Sep 08 17:12:06 2017

Fix another -Wdelete-non-virtual-dtor warning

TBR=thakis

Bug:  673171 
Change-Id: Ibbe1edbf19d9672488eb4db4045e13b858a08e08
Reviewed-on: https://chromium-review.googlesource.com/657964
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500612}
[modify] https://crrev.com/2385249c97edb9e910fab75a101a71997937f425/content/browser/background_fetch/background_fetch_job_controller.h

Comment 20 by thakis@chromium.org, Sep 10 2017

Owner: thakis@chromium.org
Status: Fixed (was: Started)
Fixed with in the recent clang roll. Thanks to Hans for the help!
►

Sign in to add a comment