Failed to compile Chromium within ChromiumOS using X
Reported by
tony.dit...@gmail.com,
Dec 11 2016
|
||
Issue description
Chrome Version: <Latest>
Chrome OS Version: <Latest>
Chrome OS Platform: <None - compiling only related to X and reproducible on multiple overlays>
Compiling ChromiumOS within Chromium with X drivers rather than Freon results in compiler failures as noted below:
src/third_party/webrtc/modules/desktop_capture/screen_capturer_x11.cc:415:10: error: cannot bind 'std::unique_ptr<webrtc::{anonymous}::ScreenCapturerLinux>' lvalue to 'std::unique_ptr<webrtc::{anonymous}::ScreenCapturerLinux>&&'
Seems to coincide with code drop on https://chromium.googlesource.com/external/webrtc/trunk/webrtc/+/99d036cbdc5908e0f791234ddda823697eb31f0c
Removing the following code allows the compilation to succeed:
std::unique_ptr<DesktopCapturer> DesktopCapturer::CreateRawScreenCapturer(
const DesktopCaptureOptions& options) {
if (!options.x_display())
return nullptr;
std::unique_ptr<ScreenCapturerLinux> capturer(new ScreenCapturerLinux());
if (!capturer.get()->Init(options)) {
return nullptr;
}
return capturer;
}
,
Jan 26 2017
closing as WontFix as per #1 |
||
►
Sign in to add a comment |
||
Comment 1 by tony.dit...@gmail.com
, Dec 11 2016