New issue
Advanced search Search tips

Issue 673164 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jan 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Failed to compile Chromium within ChromiumOS using X

Reported by tony.dit...@gmail.com, Dec 11 2016

Issue description

Chrome Version: <Latest>
Chrome OS Version: <Latest>
Chrome OS Platform: <None - compiling only related to X and reproducible on multiple overlays>

Compiling ChromiumOS within Chromium with X drivers rather than Freon results in compiler failures as noted below:

src/third_party/webrtc/modules/desktop_capture/screen_capturer_x11.cc:415:10: error: cannot bind 'std::unique_ptr<webrtc::{anonymous}::ScreenCapturerLinux>' lvalue to 'std::unique_ptr<webrtc::{anonymous}::ScreenCapturerLinux>&&'

Seems to coincide with code drop on https://chromium.googlesource.com/external/webrtc/trunk/webrtc/+/99d036cbdc5908e0f791234ddda823697eb31f0c

Removing the following code allows the compilation to succeed:


std::unique_ptr<DesktopCapturer> DesktopCapturer::CreateRawScreenCapturer(
    const DesktopCaptureOptions& options) {
  if (!options.x_display())
    return nullptr;

  std::unique_ptr<ScreenCapturerLinux> capturer(new ScreenCapturerLinux());
  if (!capturer.get()->Init(options)) {
    return nullptr;
  }

  return capturer;
}



 
I was a bit previous; removing the above code doenst fix it and results in differing error (it just took longer to show up!). Ill continue to review therefore.

Status: WontFix (was: Unconfirmed)
closing as WontFix as per #1

Sign in to add a comment