New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 673121 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
hobby only
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

--password-store flag documentation is out of date

Project Member Reported by vabr@chromium.org, Dec 10 2016

Issue description

kPasswordStore comment in chrome/common/chrome_switches.cc lists outdated possible values. This gets picked up in http://peter.sh/experiments/chromium-command-line-switches/. The relevant code is in components/os_crypt/key_storage_util_linux.cc, os_crypt::SelectBackend.
 

Comment 1 by vabr@chromium.org, Dec 10 2016

Status: Assigned (was: Started)
https://codereview.chromium.org/2563253002 has the correction; I will send it out for review on a workday.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e19d5fabecf7bf77235fdf5db8350e3b0543d8fe

commit e19d5fabecf7bf77235fdf5db8350e3b0543d8fe
Author: vabr <vabr@chromium.org>
Date: Mon Dec 12 15:50:03 2016

Fix comment for kPasswordStore in chrome_switches.cc

The comment specified the purpose and possible values of the --password-store
switch. It was outdated in both respects. Since the proper implementation of
os_crypt on Linux earlier this year, the storage was used not just for
passwords, but also for os_crypt's encryption key.

This is even more problematic because the comment is picked up to generate
http://peter.sh/experiments/chromium-command-line-switches/.

This CL updates the description based on the relevant code in
components/os_crypt/key_storage_util_linux.cc.

The CL does not change the name of the flag on purpose: it is likely contained
in a lot of testing and developers' set-ups, and changing it could have
unwanted side-effects of testing data suddenly piling up in people's
Keyrings/KWallets. Once the alternative backends for Linux will stop being
used for storing passwords (https://crbug.com/571003), and only for the single
encryption key of os_crypt, it will be much safer to rename the switch.

BUG= 673121 

Review-Url: https://codereview.chromium.org/2563253002
Cr-Commit-Position: refs/heads/master@{#437880}

[modify] https://crrev.com/e19d5fabecf7bf77235fdf5db8350e3b0543d8fe/chrome/common/chrome_switches.cc

Comment 3 by vabr@chromium.org, Dec 12 2016

Status: Fixed (was: Assigned)

Sign in to add a comment