--password-store flag documentation is out of date |
||
Issue descriptionkPasswordStore comment in chrome/common/chrome_switches.cc lists outdated possible values. This gets picked up in http://peter.sh/experiments/chromium-command-line-switches/. The relevant code is in components/os_crypt/key_storage_util_linux.cc, os_crypt::SelectBackend.
,
Dec 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e19d5fabecf7bf77235fdf5db8350e3b0543d8fe commit e19d5fabecf7bf77235fdf5db8350e3b0543d8fe Author: vabr <vabr@chromium.org> Date: Mon Dec 12 15:50:03 2016 Fix comment for kPasswordStore in chrome_switches.cc The comment specified the purpose and possible values of the --password-store switch. It was outdated in both respects. Since the proper implementation of os_crypt on Linux earlier this year, the storage was used not just for passwords, but also for os_crypt's encryption key. This is even more problematic because the comment is picked up to generate http://peter.sh/experiments/chromium-command-line-switches/. This CL updates the description based on the relevant code in components/os_crypt/key_storage_util_linux.cc. The CL does not change the name of the flag on purpose: it is likely contained in a lot of testing and developers' set-ups, and changing it could have unwanted side-effects of testing data suddenly piling up in people's Keyrings/KWallets. Once the alternative backends for Linux will stop being used for storing passwords (https://crbug.com/571003), and only for the single encryption key of os_crypt, it will be much safer to rename the switch. BUG= 673121 Review-Url: https://codereview.chromium.org/2563253002 Cr-Commit-Position: refs/heads/master@{#437880} [modify] https://crrev.com/e19d5fabecf7bf77235fdf5db8350e3b0543d8fe/chrome/common/chrome_switches.cc
,
Dec 12 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by vabr@chromium.org
, Dec 10 2016