Issue metadata
Sign in to add a comment
|
Scrollbar of <select>'s dropdown menu not scale on hidpi device.
Reported by
lxy.lixi...@gmail.com,
Dec 10 2016
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.75 Safari/537.36 Example URL: http://jsbin.com/jalepajafa/1/edit Steps to reproduce the problem: 1. Open the url above. 2. Click the <select> element. 3. See the result. What is the expected behavior? Scrollbar should scale as well as other content. What went wrong? Scrollbar not scale. Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? Yes Does this work in other browsers? Yes Chrome version: 55.0.2883.75 Channel: stable OS Version: Arch Linux Flash Version: Shockwave Flash 23.0 r0
,
Dec 12 2016
,
Dec 12 2016
Able to reproduce this issue on windows 10, Ubuntu 14.04 on latest chrome stable version 55.0.2883.75 Issue is broken in M55. Bisect Info: =========== Good build : 55.0.2877.0, Revision Range-422258 Bad build : 55.0.2878.0, Revision Range-422326 After executing the per-revision-bisect script, i got the following CL's between good and bad build versions ============================================ https://chromium.googlesource.com/chromium/src/+log/7c8a69a86be78286fc7dea6d789154efd73cb38f..cfa4d68b021ddec1b1535d37179b16af29101331 The suspecting Change Log is : ----------- https://chromium.googlesource.com/chromium/src/+/cfa4d68b021ddec1b1535d37179b16af29101331 From the above CL suspecting the below change Review-Url: https://codereview.chromium.org/2363553005 Note: ------ Issue is not reproducable in Mac 10.11.6 malaykeshav@- Could you please look into this issue, if it's related to your change? if not could you please help us to reassign this issue to the right owner. Thank You...
,
Dec 12 2016
Given malaykeshav@ is off I am assigning the bug to oshima@(Based on offline chat with Keshav) Based on offline chat with Keshav this should have been fixed with "https://codereview.chromium.org/2377453004/" oshima@ can you please take a look at this bug.
,
Dec 12 2016
I don't think this should be RBS. I'll look into if we can fix this for 56.
,
Dec 13 2016
I have a CL that fixes this. Running tests (including layout) to verify.
,
Dec 13 2016
+tkent@ who is working on scrollar on popup + zoom.
,
Dec 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b5e5a9d53c9e0596007d2f31c2ad4d0d2545e0d commit 1b5e5a9d53c9e0596007d2f31c2ad4d0d2545e0d Author: oshima <oshima@chromium.org> Date: Wed Dec 14 01:36:44 2016 Scale scrollbar width in popup properly Implement missing windowToViewportScalar on PagePopupChromeClient BUG= 673109 TEST=popup-menu-with-scrollbar-appearance.html Review-Url: https://codereview.chromium.org/2568353003 Cr-Commit-Position: refs/heads/master@{#438381} [modify] https://crrev.com/1b5e5a9d53c9e0596007d2f31c2ad4d0d2545e0d/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/1b5e5a9d53c9e0596007d2f31c2ad4d0d2545e0d/third_party/WebKit/LayoutTests/fast/hidpi/static/popup-menu-with-scrollbar-appearance.html [add] https://crrev.com/1b5e5a9d53c9e0596007d2f31c2ad4d0d2545e0d/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor150/fast/hidpi/static/popup-menu-with-scrollbar-appearance-expected.png [add] https://crrev.com/1b5e5a9d53c9e0596007d2f31c2ad4d0d2545e0d/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200/fast/hidpi/static/popup-menu-with-scrollbar-appearance-expected.png [add] https://crrev.com/1b5e5a9d53c9e0596007d2f31c2ad4d0d2545e0d/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200withzoom/fast/hidpi/static/popup-menu-with-scrollbar-appearance-expected.png [modify] https://crrev.com/1b5e5a9d53c9e0596007d2f31c2ad4d0d2545e0d/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
,
Dec 14 2016
,
Dec 15 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 15 2016
Merged. (sorry, I screw up the commit message and it didn't update this bug) commit c125c00cbe30eb4e16899596ff8a52b57e8dba61 Author: oshima <oshima@chromium.org> Date: Tue Dec 13 17:36:44 2016 -0800 Scale scrollbar width in popup properly Implement missing windowToViewportScalar on PagePopupChromeClient BUG= 673109 TEST=popup-menu-with-scrollbar-appearance.html Review-Url: https://codereview.chromium.org/2568353003 Cr-Commit-Position: refs/heads/master@{#438381} (cherry picked from commit 1b5e5a9d53c9e0596007d2f31c2ad4d0d2545e0d)
,
Dec 19 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/662f94ade995f8d62872ed229e795b3ecd99495e commit 662f94ade995f8d62872ed229e795b3ecd99495e Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Wed Dec 21 05:48:35 2016 Auto-rebaseline for r438381 https://chromium.googlesource.com/chromium/src/+/1b5e5a9d53 BUG= 673109 TBR=oshima@chromium.org Review-Url: https://codereview.chromium.org/2593853003 . Cr-Commit-Position: refs/heads/master@{#440033} [modify] https://crrev.com/662f94ade995f8d62872ed229e795b3ecd99495e/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/662f94ade995f8d62872ed229e795b3ecd99495e/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/scalefactor200/fast/hidpi/static/popup-menu-with-scrollbar-appearance-expected.png [add] https://crrev.com/662f94ade995f8d62872ed229e795b3ecd99495e/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/scalefactor200/fast/hidpi/static/popup-menu-with-scrollbar-appearance-expected.png [add] https://crrev.com/662f94ade995f8d62872ed229e795b3ecd99495e/third_party/WebKit/LayoutTests/platform/mac/virtual/scalefactor200/fast/hidpi/static/popup-menu-with-scrollbar-appearance-expected.png [add] https://crrev.com/662f94ade995f8d62872ed229e795b3ecd99495e/third_party/WebKit/LayoutTests/platform/win/virtual/scalefactor150/fast/hidpi/static/popup-menu-with-scrollbar-appearance-expected.png [add] https://crrev.com/662f94ade995f8d62872ed229e795b3ecd99495e/third_party/WebKit/LayoutTests/platform/win/virtual/scalefactor150/fast/hidpi/static/popup-menu-with-scrollbar-appearance-expected.txt [add] https://crrev.com/662f94ade995f8d62872ed229e795b3ecd99495e/third_party/WebKit/LayoutTests/platform/win/virtual/scalefactor200/fast/hidpi/static/popup-menu-with-scrollbar-appearance-expected.png [add] https://crrev.com/662f94ade995f8d62872ed229e795b3ecd99495e/third_party/WebKit/LayoutTests/platform/win/virtual/scalefactor200withzoom/fast/hidpi/static/popup-menu-with-scrollbar-appearance-expected.png [add] https://crrev.com/662f94ade995f8d62872ed229e795b3ecd99495e/third_party/WebKit/LayoutTests/platform/win/virtual/scalefactor200withzoom/fast/hidpi/static/popup-menu-with-scrollbar-appearance-expected.txt
,
Dec 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/271ac5d900914bddb7b62ecdd8cc78abcc0aa449 commit 271ac5d900914bddb7b62ecdd8cc78abcc0aa449 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Fri Dec 23 07:25:06 2016 Rebaseline fast/hidpi/static/popup-menu-with-scrollbar-appearance.html BUG= 673109 TBR=oshima@chromium.org Review-Url: https://codereview.chromium.org/2600613002 Cr-Commit-Position: refs/heads/master@{#440596} [modify] https://crrev.com/271ac5d900914bddb7b62ecdd8cc78abcc0aa449/third_party/WebKit/LayoutTests/TestExpectations [rename] https://crrev.com/271ac5d900914bddb7b62ecdd8cc78abcc0aa449/third_party/WebKit/LayoutTests/fast/hidpi/static/popup-menu-with-scrollbar-appearance-expected.txt [modify] https://crrev.com/271ac5d900914bddb7b62ecdd8cc78abcc0aa449/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor150/fast/hidpi/static/popup-menu-with-scrollbar-appearance-expected.png [modify] https://crrev.com/271ac5d900914bddb7b62ecdd8cc78abcc0aa449/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200/fast/hidpi/static/popup-menu-with-scrollbar-appearance-expected.png [modify] https://crrev.com/271ac5d900914bddb7b62ecdd8cc78abcc0aa449/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200withzoom/fast/hidpi/static/popup-menu-with-scrollbar-appearance-expected.png [delete] https://crrev.com/58b75f59f1ba2d7c658be97ac0fe04b13c152dd6/third_party/WebKit/LayoutTests/platform/win/virtual/scalefactor200withzoom/fast/hidpi/static/popup-menu-with-scrollbar-appearance-expected.txt
,
Dec 23 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 3 2017
Your change has been approved for M56. Beta RC cut is scheduled at 3.00 PM today 01/03, please merged the CL ASAP.
,
Jan 5 2017
As per the above comment #11, it is merged to 2924. Verified the issue on Win 10(on a high DPi machine and by customizing the display for non-high Dpi machine) and Ubuntu 14.04(by setting the scale for menu and title window to 175%) using 56.0.2924.51 and its working fine now. Hence added respective labels for the same.
,
Jan 5 2017
Gentle reminder for merge.
,
Jan 5 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ajha@chromium.org
, Dec 12 2016Labels: M-55