Currently, the minidump upload logic for Chrome retries the uploading whenever the device network connection changes to a being connected. This happens in MinidumpUploadRetry.onConnectionTypeChanged:

@Override
public void onConnectionTypeChanged(int connectionType) {
    // Look for "favorable" connections. Note that we never
    // know what the user's crash upload preference is until
    // the time when we are actually uploading.
    if (connectionType == ConnectionType.CONNECTION_NONE) {
        return;
    }
    MinidumpUploadService.tryUploadAllCrashDumps(mContext);
    NetworkChangeNotifier.removeConnectionTypeObserver(this);
    sSingleton = null;
} 


However, we only upload minidumps on Wifi - so if we go from being disconnected to connected on a data-connection then this retry-logic will trigger tryUploadAllCrashDumps which will try to upload all the currently stored minidumps - and fail in MinidumpUploadCallable when calling

if (!mPermManager.isNetworkAvailableForCrashUploads()) {
    Log.i(TAG, "Minidump cannot currently be uploaded due to network constraints.");
    return UPLOAD_FAILURE;
}

since isNetworkAvailableForCrashUploads is implemented by PrivacyPreferencesManager as:

@Override
public boolean isNetworkAvailableForCrashUploads() {
    return isNetworkAvailable() && isWiFiOrEthernetNetwork();
}

I suggest we change the code in MinidumpUploadRetry.onConnectionTypeChanged() to just ask PrivacyPreferencesManager whether the new connection type is enough to upload crash data (instead of just checking that there is a connection at all).


If I haven't uploaded a CL for this on Monday feel free to take this bug Ilya :).